From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC42C4167B for ; Tue, 5 Dec 2023 06:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1BD46B006E; Tue, 5 Dec 2023 01:06:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CBA46B0083; Tue, 5 Dec 2023 01:06:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA506B008A; Tue, 5 Dec 2023 01:06:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7937C6B006E for ; Tue, 5 Dec 2023 01:06:39 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 478571C0377 for ; Tue, 5 Dec 2023 06:06:39 +0000 (UTC) X-FDA: 81531730518.01.F31E519 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf14.hostedemail.com (Postfix) with ESMTP id 43FEF100002 for ; Tue, 5 Dec 2023 06:06:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iL1kmkQB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701756397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VsRmRaEO4PHPFPipHn4Io6Xoy0VdHjTgPWI63DWkYRg=; b=K7jaDOlu+BaOPeMBHG+mSB1/KLzxpjOd9y2m7PFRKuLbJoM2nvcTtt1eoAkTtRG4pLX45R J4Fkx6RZe9+NRaISqjsCee1vwoDqUXeuU9q3675of3+dy3kgBBHreSsr5XDWLUuUWwsg8S j972LGV4h1K7BflWyPLosvlRUUy3C6E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iL1kmkQB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701756397; a=rsa-sha256; cv=none; b=dRq1oT3+MUfhsFMDArbgUCRTxtrrIwSsnVq9+hkGpNzLiHKBkzF1JcxoxSXAr0HSKZpZFY sRwuRvtt4vRj/0uEdDwJt7Fvk0bbH3UPJwDvWwd76i9o/WMHaPQRvcsvnlSP+ICwr/W9+n jP8AvV64xvFkfeH2PaHbh60Q5BloY1I= Message-ID: <29bd5cc7-e8e6-4a4d-b526-651c7885a185@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701756394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VsRmRaEO4PHPFPipHn4Io6Xoy0VdHjTgPWI63DWkYRg=; b=iL1kmkQBwgGP924gLcS8obFI0W5s4W9Aku7Jcm3vSTqi6rx5Mvh285Mwy61qfNg3mYiog8 KTi3Ed8WTVAKvMMRpyDjz1MvA+/v740gqdInX9TlLgET/I41EfgBEQ2JuKT6dSqrzX5Mhi mL1tz3beobO6pup7osZZmRP9/24ObJo= Date: Tue, 5 Dec 2023 14:06:29 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v5 9/9] slub: Update frozen slabs documentations in the source Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: vbabka@suse.cz, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231102032330.1036151-1-chengming.zhou@linux.dev> <20231102032330.1036151-10-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 43FEF100002 X-Stat-Signature: xm3ni8dkwqfg4bwokn3rnbx996wegtmq X-Rspam-User: X-HE-Tag: 1701756397-355684 X-HE-Meta: U2FsdGVkX1/C8mHHoL8IoIV4zaDE16LNwPv1OCjJOAXzBA1tJlmP2U0CWQh24Wd4wenRg1XVMUQPWkqf2sa5/DeYu9pZN5o9B324Kxd48qhWPmrncGl2k6ZKcILQakeI+RK3IAFJgmQPdWK26xrsDgf6aEhzhtHaT7bbJm5uQslFSQIdh1ynF42mzuLNh9SayT3j5XY4bL8NQUEeoqrzjVa7DRHSGUjXcGqulyKmsOaWsc27oQNB0/Uq1IEgKG1mpzgKzYEBjYOPvS+19l9VtzEMEyywsSlsnooMpsDpK0aFpJjMhwQj+6vvGMO4isz7XkXMeZEWXeAJklNq2L5ex+ab2giaJcr6CJAGBdOSRQfsOJBAaMyPTL4l+Z/N9cnUIUupFeToKnzBTGOGsfcFWSvLAahH3dRAE4uCS+/vrdEcdbi1DADn1I9SoO8oXNFcnfyQpujwYEAbH+eGy6zn+pp73eoar3wBW68zBiLeHwgsOp9IXgUsXeKhDxsuS8O7Xo4t+dvCScaxj1pXRtqwNyxluxppNnpG4LemEmEkorLmKXxp3HuXjo0xrmZNXzNeRpa3Hj1sE61RzK0D6+sM4+Swwn/lRGU0d5/CUjG31YonyOu381xSmG/5lQ1oQXdlK6706nBDBN1TqI76kcyS5+u2U8vKtMZfUWqmD8+gXeOsRk5OnYF6j6Lcwlc6NJTAO8n05MXMU0kXC0c1Ug3AhAM6fVNqfvVQEjTTdlt22Dvn39Iqy6yKeHW0TlNLil9euetI15gVW/UEsxRB9gd6RF7W6F7SWckl4F8hZpLviW9rMfToUOcF0P3jXmkSWo/6hqTsj98hywzrh3E0WlRs2V0fTZFdHnRDbH6aL7SWp6b1gy94VawCIRmDVaPxkKywK0na0bUrm06TkGyFpOMLvNO8blbMrA/6Tuwd4pzO4Z8qZ3i/Zcg/7B3s6k0xXE68bgDsOTfc4Y85xBr87VZ GI+gClFk eQFNI5uk+SjOnpFdKF01fVHxESQpyZgj4mzeGoFFpIF39+WSpz3BpTuxezLdMNzvpda9ICiI5l1jF7fPbeBWWUy5GNM19oXQGdndMiSwisQ9UfQsVpO33AYmTd6D83peX1OW8mITanfWU9t1BBNctKgdB0QXqPclwca3+uxrcXr637O+AgIQYZIGPBdAqVU8iP8d4ozInb2nuYDPSnXxZ4RRsDeb6A4JqE04VCH0fQQDy2WHhW+u7WmcJYrPeEKdCX6vWaKIEjmVdJyto+dEDd087Zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/5 05:41, Christoph Lameter (Ampere) wrote: > On Thu, 2 Nov 2023, chengming.zhou@linux.dev wrote: > >> From: Chengming Zhou >> >> The current updated scheme (which this series implemented) is: >> - node partial slabs: PG_Workingset && !frozen >> - cpu partial slabs: !PG_Workingset && !frozen >> - cpu slabs: !PG_Workingset && frozen >> - full slabs: !PG_Workingset && !frozen > > The above would be good to include in the comments. > > Acked-by: Christoph Lameter (Ampere) > Thanks for your review and suggestion! Maybe something like this: diff --git a/mm/slub.c b/mm/slub.c index 623c17a4cdd6..21f88bd9c16b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -93,6 +93,12 @@ * by clearing the PG_workingset flag when moving out of the node * partial list. Please see __slab_free() for more details. * + * To sum up, the current scheme is: + * - node partial slab: PG_Workingset && !frozen + * - cpu partial slab: !PG_Workingset && !frozen + * - cpu slab: !PG_Workingset && frozen + * - full slab: !PG_Workingset && !frozen + * * list_lock * * The list_lock protects the partial and full list on each node and