From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F41AC433EF for ; Thu, 16 Jun 2022 20:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2026B0071; Thu, 16 Jun 2022 16:11:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07ADC6B0073; Thu, 16 Jun 2022 16:11:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F626B0074; Thu, 16 Jun 2022 16:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CAF2E6B0071 for ; Thu, 16 Jun 2022 16:11:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 898CF34C84 for ; Thu, 16 Jun 2022 20:11:32 +0000 (UTC) X-FDA: 79585194024.07.57F18BE Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 13D3B18005C for ; Thu, 16 Jun 2022 20:11:31 +0000 (UTC) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-fe32122311so3172358fac.7 for ; Thu, 16 Jun 2022 13:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0/2lPHK5UfMEdeldVC+LjacfATEIIqbuMlENszuskS0=; b=JwDFrcRmWvi+UwEVyuoBAsqo+8IdDLtYFOwFHc7++2OSwhHq+EACTUHG5Hg+ixpX4X bAeZlxYrzmld3IwoVXRU/HT86ix0ILdxcRDSGb84Qnl52BMEXFcTUKVQckkiT3k8UaeU Aa/eR9q9rnjc4IhOjXS9O3yEIqCByr97EzbwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0/2lPHK5UfMEdeldVC+LjacfATEIIqbuMlENszuskS0=; b=PltCUQs+AVJ2kNV0fGasqxjWGgc2uCjGTVLVES753msEfGGGNPL3XPj+KvzAsYzF5P 67rjItdyJ3oqXIWKX0nZ75MKrYimOxvNq7wsxf17+JY2x3l69ufig0cP6LHXTQRUQ0zf mEeQtKvya9AzL+31wY2t/n7/NZkOfavW0SixHzYVofiPZ0Rzc14FPORRdq9xRyVxXHAy jY89HVVuzEF4Yf7u9Ep4PdtD7GkTsZzAdoLbmedr/1FdQsZ6+AqGlp2vuSc3OXSp69iU cZZ4YEX4kXy8Ukg65WIDL+RX8hIfRNn1Rbhy91fu68qSwM58ZlCEjfwOvufkgLW0RDVw jLsg== X-Gm-Message-State: AJIora9yzBCBOzEP3Y5KzQtK5dgomuGPFKc2B+cfoyJitSixmVNux7lG 4LjpT1kaqPanDtKgOIl7BFSPiw== X-Google-Smtp-Source: AGRyM1vyJmHOFQtbOM/acSJRad/rfUJiqXcPsrBXxyNgySY37Cs61TI15mO3VeigBig5WXFiFiU//g== X-Received: by 2002:a05:6870:ec93:b0:f3:3856:f573 with SMTP id eo19-20020a056870ec9300b000f33856f573mr3644633oab.17.1655410291205; Thu, 16 Jun 2022 13:11:31 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id bh2-20020a056808180200b0032ed4543c36sm1314067oib.36.2022.06.16.13.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 13:11:31 -0700 (PDT) Subject: Re: [PATCH] selftests: vm: Fix resource leak when return error To: Ding Xiang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220615093629.1330809-1-dingxiang@cmss.chinamobile.com> From: Shuah Khan Message-ID: <29be48c7-7178-6f25-c99b-0d11eb967539@linuxfoundation.org> Date: Thu, 16 Jun 2022 14:11:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220615093629.1330809-1-dingxiang@cmss.chinamobile.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655410292; a=rsa-sha256; cv=none; b=g2tu/qWtl5A/SUZmC7x1QsP23/SlN7yftXc26zlSTrNhLRxZ5b/BfAe/ZxXYxBNM9GJqR8 p+enCq1NN5hKn4jao+C4exUe0M6VJ4Cd0SmkGAe7vz15/MhaVtaEKG/oxwULx5c25b8g4y JC7l0S7f3AERNdzT6k+dsENqlSXffoQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=JwDFrcRm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655410292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/2lPHK5UfMEdeldVC+LjacfATEIIqbuMlENszuskS0=; b=X4GvcU+XbSueSxxaqCzqT6AYSAz4MENRnRNcY4FBLmRMRCi9WHI7Gqv7ScblifhQlWc/HH vkHJ675dhkGj1GDqk1IS368IlVk93X1znPl82Tqpf/9SkC6f+y+6jx2ygOEiZZKQDhHXcO huTtMPnFddBMtrAOJzpK0AlgK3IboK8= X-Rspamd-Queue-Id: 13D3B18005C X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=JwDFrcRm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Server: rspam06 X-Stat-Signature: 6tqoi7ef3aczhao6jbx6f96w1ikkfyem X-HE-Tag: 1655410291-457211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/15/22 3:36 AM, Ding Xiang wrote: > When return on an error path, file handle need to be closed > to prevent resource leak > > Signed-off-by: Ding Xiang > --- > tools/testing/selftests/vm/ksm_tests.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c > index 2fcf24312da8..f5e4e0bbd081 100644 > --- a/tools/testing/selftests/vm/ksm_tests.c > +++ b/tools/testing/selftests/vm/ksm_tests.c > @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) > } > if (fprintf(f, "%lu", val) < 0) { > perror("fprintf"); > + fclose(f); > return 1; > } > fclose(f); > @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) > } > if (fscanf(f, "%lu", val) != 1) { > perror("fscanf"); > + fclose(f); > return 1; > } > fclose(f); > Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah