From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A77C47DDB for ; Tue, 23 Jan 2024 02:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AED276B0074; Mon, 22 Jan 2024 21:23:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9D7B6B0075; Mon, 22 Jan 2024 21:23:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98CF36B0081; Mon, 22 Jan 2024 21:23:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A9E96B0074 for ; Mon, 22 Jan 2024 21:23:25 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E1FDA1E41 for ; Tue, 23 Jan 2024 02:23:25 +0000 (UTC) X-FDA: 81708979170.08.0039873 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf15.hostedemail.com (Postfix) with ESMTP id 74555A0007 for ; Tue, 23 Jan 2024 02:23:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GRBybsmf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705976602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fy9JI9s5CgHc9vU6scmFm3fgR9U6bOckIRvEe1L/hPs=; b=tHFFD3L65AJ7WrL46p71cjJiaCaFjrRnicpkTURO9pJnb8ChyqukxfBFBFLPXrKnyexzy4 jUDeEXNH59T3T+7xakMp1CmEHab2MVNnNSSwlwn3fXKMJ5EW2WQsD+7G32ueKwh8u/7lGm Z4xfIvQ1bLNXehFBHlaYqUyVwQYNGJA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GRBybsmf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705976602; a=rsa-sha256; cv=none; b=3FasLK9R3sNHbbtedukRGBR7sIlTG8umqzqHxis0joxlr9zd/8oz5mD6EELnlkWjGfQj0M 6eLhjxIiGuZXTcF1fNs+D3e+nR+jzjEZMKb6VyQ+U1gCH34evtm/+ImFEIA/E1TijfVfIs bHFXV7bdaXek/liPwd2GO4MI5r0ytG0= Message-ID: <2a1d6a9b-f486-44c8-6d1d-e6bab4dc3ced@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705976600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fy9JI9s5CgHc9vU6scmFm3fgR9U6bOckIRvEe1L/hPs=; b=GRBybsmfuXKfd/mLRS+wIrZFlZhpe5WRZDKnbLkyNE08NsBjmFBbwFh81efoeyV1P1WVoU 6v4Wtv83tk6Q9yBSGWM4QQd0AFwYf6FQL8TQguA0eKL0vRpmzSPfJrxMlNqbBgsid1RAfm rVJdEY1UzcYcbLOjMvO++uDDfQGi4pk= Date: Tue, 23 Jan 2024 10:23:14 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm/mmap: introduce vma_range_init() Content-Language: en-US To: "Liam R. Howlett" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240111021526.3461825-1-yajun.deng@linux.dev> <20240122220031.pwiravglee7o7k34@revolver> <20240122154031.b710f834b14d9027176f439a@linux-foundation.org> <20240123001830.glqdmrv2qc56zfpc@revolver> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: <20240123001830.glqdmrv2qc56zfpc@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 74555A0007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 799wahj3m4m7xozreg7889b8icod38xo X-HE-Tag: 1705976602-185730 X-HE-Meta: U2FsdGVkX1/Q2uUmM0kGHFo8PEtzYdZLnrYVfMoyG7IBGqyUf+z+LOHweOPsutl86GsMO2LSDdOvcAIW4fIiP3Y+fh90grFhPdS+SfQwA2ONJNB0gC/BJSj3OLArQpvr6/PbH+2yjgl3dcC+PtKYgm/62ygZ1VofUvKgHYHpkMtjhLR0scsvmU7W2ci7sXeL8L11xgR+ZJj9hu5WBEy513IzJF4UifWcgDXtiCmyeT9a8VMg/1t+ue6/7W5CNJKDLTuFEw3bYgQ+L9b506sOcNYVQ2OOgzupYJIMjAQRE+Jd6qld+TwICJG9GHvIB31Amrnot8a3nnj7nDYm24R33SVUf8zQsh9xtG3KEfijhgmUB3iGwse04VWd9FU4RsrIqigNlq5oywX5oZzgazimz2Iv0IKcZ+KkmvYwut7EQKZ/OSKZcsrHOL6ge8oYkn2d3jW6g+VWy+n1HNYDIpBot7XMdqbIpADB1hhLuLpIIGTPfuB/jmqHG+P6A2OyPcGYpE839Fydyua2vF19YGB8pIYDwn18ldy0EHkERbF1XF8e1jFJz1bIHQKpYsk7AYlDd3kNDTdxaOfoDsYHTeRYfBYR4GE0XV6LGeiZRTFkP2a+F2N6KzN68SDz8qBZa0dnfEZ9UONJEvpwoEMd/GBoHMm9ckPyzoYBQXAbSe0S1SDQnzM7GNajfJedLkHDvvAetnX746h8NQivxdEYwLp6sUrFIwlx9FKve2Hukp9KXjQU3mmW5H2qc58URWa5gBtHVSXm75XNBODlQXwocmgdpqHBsPD1bAl+yRg28bUdzJgS+NuoqCjvDCHJkHC0Nz6oLEyCtSPz9dsmz1+tLUltOPfT+CpzUq+Jvorj4gObeCplu8uYyGgmMKi8dVPtEGBxptaXs5i4mysSo1rr5rwO7xlOYqc8oG9rENrKD7BbdrkMj0ZVUfBCbTrUjF356mZk6azLj7zRnFxC+xWTyED GM2kjG1g Os+siu1A61f4wcg2xDUFcYNQ/Gv4vYcGB+IhzfSa8ulX6rcm8lvdwbAYrpRVQBwCukXAGmrd0Q+DPVuJObekoOGOqi2Ubu1YZ+5o97hKMqBKAeGK8OrAcT4jyB3QUf0YMRRcmbVUtyimSKp7C/DSvuUM03lRHJhuWBg4XHHZRwM6SUiSeA2APccetCGvtEJMwbVjpHGbbgb3M+TVQaCiopZXAUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/23 08:18, Liam R. Howlett wrote: > * Andrew Morton [240122 18:40]: >> On Mon, 22 Jan 2024 17:00:31 -0500 "Liam R. Howlett" wrote: >> >>> * Yajun Deng [240110 21:15]: >>>> There is a lot of code needs to set the range of vma, introduce >>>> vma_range_init() to initialize the range of vma. >>>> >>>> Signed-off-by: Yajun Deng >>>> --- >>>> include/linux/mm.h | 9 +++++++++ >>>> mm/mmap.c | 29 +++++++---------------------- >>>> 2 files changed, 16 insertions(+), 22 deletions(-) >>> This isn't a whole lot of code, are there others? We're losing code >>> clarity in favour of saving 6 lines? >>> >> Oh. I thought it was a nice cleanup which made things more clear. > I'm not totally against it; that's why I suggested the changes below. I > think a name change would go a long way for clarity. It's not as much as > I though it would be though. > >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>> index f5a97dec5169..abb4534be3cc 100644 >>>> --- a/include/linux/mm.h >>>> +++ b/include/linux/mm.h >>>> @@ -3516,6 +3516,15 @@ static inline bool range_in_vma(struct vm_area_struct *vma, >>>> return (vma && vma->vm_start <= start && end <= vma->vm_end); >>>> } >>>> >>>> +static inline void vma_range_init(struct vm_area_struct *vma, >>> Any reason this can't be in mm/internal.h ? >> That would be good. > One other thing, do we trust this to be inlined correctly by the > compiler or should this be __always_inline? I'd expect it to be okay as > it is, but I've been proven wrong in a perf trace before.. > Okay, I would take __always_inline and put it in mm/internal.h in v2. >>> vma_range_set(), vma_set_range(), or just vma_range() might be a better >>> name? My thinking is that some of these are actually modifying the vma >>> and not just initializing it, right? >> I'd vote for vma_set_range(). >> > Using vma_set_range() leaves vma_range() or vma_size(), which could be > added for the calculations of vma->vm_end - vma->vm_start. Davidlohr > suggested such a beast a few years ago, but that one would need to live > in the include/linux/mm.h as it occurs a lot more. > > $ git grep "vma->vm_end - vma->vm_start" | wc -l > 198 > > .. for just those named vma. >