From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1457BC4345F for ; Wed, 24 Apr 2024 16:36:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 830B68D0022; Wed, 24 Apr 2024 12:36:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E1118D001F; Wed, 24 Apr 2024 12:36:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681028D0022; Wed, 24 Apr 2024 12:36:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4C8038D001F for ; Wed, 24 Apr 2024 12:36:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A48CD1A028C for ; Wed, 24 Apr 2024 16:36:40 +0000 (UTC) X-FDA: 82044978960.26.890D9D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id A67AC100023 for ; Wed, 24 Apr 2024 16:36:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dlnRzFgC; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713976598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Jrk4gtHl8qK5/GSsCNisBJDr3mbiNNfApp9drceM6U=; b=5y+/d+kUeMubyv5JtBUtakYOnkgCWi05ktokhdr9xzj+CStVRoGwpsUwU560L1PAq6oPMi F/UolNx0iduR+Gl/2CF+oqrr3TwjJCfqeYuHHdTz9TiFN9f+5ucHMqg3vOR0wIeLSRG+Ej AnOxt4vTukCMh/95eipscbpP5AUeJfE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dlnRzFgC; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713976598; a=rsa-sha256; cv=none; b=7pfS296mRWpt6AChn7CA1Ym4SMo42u6UOxKIrRKJcjXsYYvBPUUNOgjOfYDm1QFEWD6m2r 96b459UjCHyZJyrxrsBp5hV4EtVvLNjvx5/KeuF7tZPMON8X5XA+/uDtQ9dCYt7OikAPE8 fL0CiFK77G/7aWJEPjn0A+g5rRBXFHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713976598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4Jrk4gtHl8qK5/GSsCNisBJDr3mbiNNfApp9drceM6U=; b=dlnRzFgCMYbXQ55DC6FAR8kpIrxussBPkaC4u8PNskJtfEbinXITORb2GG3CgcO25C81wH z39zRCC1Ujp0Kw7u2m/HeuPCdWJil5be5BsmKIUPNsTr9h9ayXIs5IwPqUYsww6/t9do9l FzqvjwhSsC3lbtJvR7m1No22dk0mB/0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-qjEkL61qM5yeQuaN9o8moQ-1; Wed, 24 Apr 2024 12:36:35 -0400 X-MC-Unique: qjEkL61qM5yeQuaN9o8moQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41a38f6e371so215825e9.2 for ; Wed, 24 Apr 2024 09:36:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713976594; x=1714581394; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4Jrk4gtHl8qK5/GSsCNisBJDr3mbiNNfApp9drceM6U=; b=RPtOnSO1VbCGHkkP1rh8YeoGJ8Pe8BtGTZwc4Nn5dYz42XNLqTfBhxn0kh9qNxC2B7 TA12n5xAI206PNHJ6LyU5jQz9OdAUMQ9QsNJ1taeIefBc+R1D8bjSCXd8ucTM1icnoRL zilmGrgnkf+KB2UXTvJBJ26/FhrwOMA4HjwSdElbTjdVDf1FzFV7fo3vmXF1xkFn0tED Fs8Fbm/OSJZ7bpq5UHMvv9N5F1sULfr8yQCAuOnpKKOLL6OTyueUmLiRYHm3kb1euWf4 M2r+xqVfwBGAtQeItw9FPfU+hvYawSfnNK7BbatfUmw7y9r5hqM93JvKUh8Uaz9qGfR9 EF2g== X-Forwarded-Encrypted: i=1; AJvYcCXXee/C6LaBG+mm9sI6d2Vzy1RM9xiph0bvRTm7jgeqNmZUbzSwczSK8fhzbi3hYmvVCoz3nBMiX+tyd5Yjij1hgZE= X-Gm-Message-State: AOJu0Yz3poM5vonB2b/Ek5+lxAA+x2SkmlAlqxWLee4/JqHn85d8240c xp1tyg+QaMNnO552nFhsCcxipkE9Gnm1d9WR+HV0FnEhsPXRoEJkVo/UFrUmDjVNjL8YphJDKYZ Xk+yAE/m1Tb3VUBJxR0VbLMtchyNzXiNej1aTAkjYNVv4PfD2 X-Received: by 2002:a05:600c:3d8a:b0:41b:144a:f0c3 with SMTP id bi10-20020a05600c3d8a00b0041b144af0c3mr1065279wmb.20.1713976594095; Wed, 24 Apr 2024 09:36:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgmkfHI6kdz/k8WpzKlP6Ihl1I1xBPf6WTZ0J7t762mXEb4w+GJI6DHiNacD+q2oVRiDDNuw== X-Received: by 2002:a05:600c:3d8a:b0:41b:144a:f0c3 with SMTP id bi10-20020a05600c3d8a00b0041b144af0c3mr1065264wmb.20.1713976593666; Wed, 24 Apr 2024 09:36:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id r18-20020a05600c35d200b00418d434ae4esm24396011wmq.10.2024.04.24.09.36.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 09:36:33 -0700 (PDT) Message-ID: <2a33880e-4e7a-4de1-846a-e81f8de82088@redhat.com> Date: Wed, 24 Apr 2024 18:36:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/khugepaged: replace page_mapcount() check by folio_likely_mapped_shared() To: Yang Shi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Andrew Morton , Jonathan Corbet , "Kirill A . Shutemov" , Zi Yan , Yang Shi , John Hubbard , Ryan Roberts References: <20240424122630.495788-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A67AC100023 X-Stat-Signature: krinyk444wgpch5wd74cxzzh1m75bwsj X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713976598-86718 X-HE-Meta: U2FsdGVkX1+sOuvWdbaMO3oOPddbFI+sg7fsjKldk5B64cxCkdoU6QEaJAHXepoU1VJDB5jWtTOVAIcKtAoEzuaQSgV0UJW/ju15i/bsmLW8j2pZ6J1cKWdiPh1Z3FgVr/K2zzdfToK3VkKjicQHDwo6CVbgTdqDCtvUZ9S06zP6gY8vW61YtTIv4eT87D4cPXkig1lPbMMiJG0JrzYTrOZlkOoMWhBEsTO+d0vpDz2SaEhuZLdaQ02PmRE082evvDPKQp0n7biGegZLrzx3sLInT7A0eLELXjIpcUQUOk6B+y4A61Zn0195qXg2jNAxghbgp9hoQySt214CRbIjnj34XvtSFk2iVz3SkgbeXZ5gjn65pvShfxJDcLTY2FZzXFbT1OYTyXkIsjrCeruhIp6FFSL2eoZxcd7nozPQ8LpoSIySdtNo+6GUlMCI6qlahTjrVq2ED8vZVrTRM1NMEyZr0NHKIsagJOr0Ab5cSP4Q1h4DkyjJm+QPL+qZIgNG+LZWXeGh80fYwqdUSrUARFpvuVwzSfdd3NDrbbrCU0V7JSLlMJ8oLuVwXZwP10yUtsgfPNsvEkFq76awMEDrpaV0rlv7RQ8wWZEtZUC5hXTmwxc2AnFWvkZRFMJ2EysPV/EsajH6e1YMqSJRBaDUMlwBovaKoxZzojvF9wmunMH3kO5utokpQy58ueIF4F+d0PXGvjoHOtX1QHIuhBMWP6I9O4mDN010GZIoljoI3svsRVjhdC9Wq+2LR2DgP5eoyN5aXlrpNo8c6swAz3YJ1D8AVO91YRj1XWmMXF2RaGwWlW0Koh/gEhTIJ+nzzJvKn6XH+YASgTxaOO7hSPzeBwgAgaWRtOPcHvTlkmhfk9sgOTWU3K+YueLmGNdv40UL1NzPIMhOpEz8nwaKo+IDNuDwuATlVg7TCwTmnTDPqNOefC83Ffq4W5AJb2ZkD0c65bTAjTP02S3RW3ujjOL uWHmCBYs EUE9VkaRHyWWQTWDG0NEz8aZ8/qYIVG+Y1fRscLdqrGF5+OYYjk9iaJmoFLplizlI7PiaAQSwdCfNFYPHVdNkJSgxFA2V5AkwjOlHh2AEiGhrGJKJ2gOxRQ94rnDlukAvwHU/v/Z4/L3b22gjUlewrD/GIOKXFMjQZ6ERVo56Ke24oJ5R6pIVpmKYRNh5EJ/6raAT15PrYeVrsH4aeOwbBz562SEH4krZgTUEF9/pkCEJy7fPRwWG4o622HDGapRCtC9H5nERXVBvQ2xzWkgDy0YuldZth4m/AEr39s5AXe9l9TjQyVXA8a1DDXpQVfyOMcWg0QHAe7MsMPvfYBuVzwPf4OTRXxGLg30xfvQrajJ2QJCyUpUcdoiynXRaYl3Manr8C1bMCeQWa4PG6WYxzBKBfJacj0q6CU1R40Oe0KYYaRsMB5Lic+Z5RcGhsU6hKBz/vxd0ZgfFswuK6B4aSCqspaV86IAgXutA9yk27nX3hKd7nPhqSo93jcP6evC3q2/2DtitQWQbZ14g0+KBmiOM2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 18:28, Yang Shi wrote: > On Wed, Apr 24, 2024 at 5:26 AM David Hildenbrand wrote: >> >> We want to limit the use of page_mapcount() to places where absolutely >> required, to prepare for kernel configs where we won't keep track of >> per-page mapcounts in large folios. >> >> khugepaged is one of the remaining "more challenging" page_mapcount() >> users, but we might be able to move away from page_mapcount() without >> resulting in a significant behavior change that would warrant >> special-casing based on kernel configs. >> >> In 2020, we first added support to khugepaged for collapsing COW-shared >> pages via commit 9445689f3b61 ("khugepaged: allow to collapse a page shared >> across fork"), followed by support for collapsing PTE-mapped THP in commit >> 5503fbf2b0b8 ("khugepaged: allow to collapse PTE-mapped compound pages") >> and limiting the memory waste via the "page_count() > 1" check in commit >> 71a2c112a0f6 ("khugepaged: introduce 'max_ptes_shared' tunable"). >> >> As a default, khugepaged will allow up to half of the PTEs to map shared >> pages: where page_mapcount() > 1. MADV_COLLAPSE ignores the khugepaged >> setting. >> >> khugepaged does currently not care about swapcache page references, and >> does not check under folio lock: so in some corner cases the "shared vs. >> exclusive" detection might be a bit off, making us detect "exclusive" when >> it's actually "shared". >> >> Most of our anonymous folios in the system are usually exclusive. We >> frequently see sharing of anonymous folios for a short period of time, >> after which our short-lived suprocesses either quit or exec(). >> >> There are some famous examples, though, where child processes exist for a >> long time, and where memory is COW-shared with a lot of processes >> (webservers, webbrowsers, sshd, ...) and COW-sharing is crucial for >> reducing the memory footprint. We don't want to suddenly change the >> behavior to result in a significant increase in memory waste. >> >> Interestingly, khugepaged will only collapse an anonymous THP if at least >> one PTE is writable. After fork(), that means that something (usually a >> page fault) populated at least a single exclusive anonymous THP in that PMD >> range. >> >> So ... what happens when we switch to "is this folio mapped shared" >> instead of "is this page mapped shared" by using >> folio_likely_mapped_shared()? >> >> For "not-COW-shared" folios, small folios and for THPs (large >> folios) that are completely mapped into at least one process, >> switching to folio_likely_mapped_shared() will not result in a change. >> >> We'll only see a change for COW-shared PTE-mapped THPs that are >> partially mapped into all involved processes. >> >> There are two cases to consider: >> >> (A) folio_likely_mapped_shared() returns "false" for a PTE-mapped THP >> >> If the folio is detected as exclusive, and it actually is exclusive, >> there is no change: page_mapcount() == 1. This is the common case >> without fork() or with short-lived child processes. >> >> folio_likely_mapped_shared() might currently still detect a folio as >> exclusive although it is shared (false negatives): if the first page is >> not mapped multiple times and if the average per-page mapcount is smaller >> than 1, implying that (1) the folio is partially mapped and (2) if we are >> responsible for many mapcounts by mapping many pages others can't >> ("mostly exclusive") (3) if we are not responsible for many mapcounts by >> mapping little pages ("mostly shared") it won't make a big impact on the >> end result. >> >> So while we might now detect a page as "exclusive" although it isn't, >> it's not expected to make a big difference in common cases. >> >> (B) folio_likely_mapped_shared() returns "true" for a PTE-mapped THP >> >> folio_likely_mapped_shared() will never detect a large anonymous folio >> as shared although it is exclusive: there are no false positives. >> >> If we detect a THP as shared, at least one page of the THP is mapped by >> another process. It could well be that some pages are actually exclusive. >> For example, our child processes could have unmapped/COW'ed some pages >> such that they would now be exclusive to out process, which we now >> would treat as still-shared. > > IIUC, case A may under-count shared PTEs, however on the opposite side > case B may over-count shared PTEs, right? So the impact may depend on > what value is used by max_shared_ptes tunable. It may have a more > noticeable impact on a very conservative setting (i.e. max_shared_ptes > == 1) if it is under-counted or on a very aggressive setting (i.e. > max_shared_ptes == 510) if it is over-counted. Thanks for reading all of that! Right, and mostly affecting corner cases. I'm not concerned about (B) really. I was more concerned about (A) before I optimized folio_likely_mapped_shared() using the large mapcount. > > So I agree it should not matter much for common cases. AFAIK, the > usecase for aggressive setting should be very rare, but conservative > setting may be more usual, so improving the under-count for > conservative setting may be worth it. Yes, sorting out A completely is what I 'm working on, but it will likely not be available on all kernel configs, at least initially. And unless there is a good reason, I want to avoid having config-dependent stuff all over the kernel -- and just move page_mapcount() to task_mmu.c where it can no longer be (ab)used. Thanks! -- Cheers, David / dhildenb