From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44983EB64D7 for ; Wed, 21 Jun 2023 19:52:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5851F8D0003; Wed, 21 Jun 2023 15:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50DCA8D0002; Wed, 21 Jun 2023 15:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311B68D0003; Wed, 21 Jun 2023 15:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F90A8D0002 for ; Wed, 21 Jun 2023 15:52:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AAC43AFB0D for ; Wed, 21 Jun 2023 19:52:49 +0000 (UTC) X-FDA: 80927802858.08.989CCBB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id C783D40005 for ; Wed, 21 Jun 2023 19:52:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBqvzi0B; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687377167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vTL4Y8a8sFEsX3Xqt4OIZCRU2/7UfNvPDdjp0N/3dJE=; b=JJmpAhdaEvXCv7tBTOoEYConTlzYo5k/Wky/rZaJuybQxaCgXEzsHUMHT5wUjoHrNbQA5v O5p1d6wb+0v9ZCfA4zSVfWtOdrrXQ5x/mZCIwfb/CDR5mBWLI2MK1OXSGmKb6XJ6SNB2pW Ffp2Llb++oA4xesu9oGp7Upb3odLKT4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBqvzi0B; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687377167; a=rsa-sha256; cv=none; b=R8F/NCcZeysKWuYfe2ddmknP8/t98B4dJ4udFnxGN3lUf8O+FzQh4UPhxfrS9EgxKmhblH 51TcrkzraG/w37PlH5v79LoIg8c+6/Llym33Uih7v6i5u69CEIhx3Ba9pTjfmR2NIHsjvr 0QjHZEhT89BSrKa8b4AcyXG5yN10HsA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED41661658; Wed, 21 Jun 2023 19:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89C99C433C8; Wed, 21 Jun 2023 19:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687377165; bh=vTL4Y8a8sFEsX3Xqt4OIZCRU2/7UfNvPDdjp0N/3dJE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=tBqvzi0BueVyLSEbesqZv6Z2lEPP3VHDK/0ro+NhJgrWCN7POU/GnsfWmg+au/I1/ qhi//1NZGnRyBWC+DfSRBIODYBQomanDaEsbNql7Uti143OqrGRxW4LYitKm3HOUFm 3AFCsCq6C4olFaFCKGiCtIGy0tLgZnX0NusQlw4HgjVra9Ac5A8Ylg7+9/P0lUpR5a +VLBtjm16h891O76lVM1Ta8bhTOaRz+hamckCGdfcbzLfSMEYWZEagHpIq+7Dm+VlU f0RFgH+s7zmUzeMyOo6a8vBaboDD6pPbvwZcf5WIVyOhAezSg+L8WY3I+kat7Le9is Pb20wj8vyk/yg== Message-ID: <2a5a069572b46b59dd16fe8d54e549a9b5bbb6eb.camel@kernel.org> Subject: Re: [PATCH 00/79] fs: new accessors for inode->i_ctime From: Jeff Layton To: Steven Rostedt Cc: Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Eric Biederman , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Tyler Hicks , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Phillip Lougher , Masami Hiramatsu , Evgeniy Dushistov , Hans de Goede , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Juergen Gross , Ruihan Li , Laurent Pinchart , Wolfram Sang , Udipto Goswami , Linyu Yuan , John Keeping , Andrzej Pietrasiewicz , Dan Carpenter , Yuta Hayama , Jozef Martiniak , Jens Axboe , Alan Stern , Sandeep Dhavale , Dave Chinner , Johannes Weiner , ZhangPeng , Viacheslav Dubeyko , Tetsuo Handa , Aditya Garg , Erez Zadok , Yifei Liu , Yu Zhe , "Matthew Wilcox (Oracle)" , Oleg Kanatov , "Dr. David Alan Gilbert" , Jiangshan Yi , xu xin , Stefan Roesch , Zhihao Cheng , "Liam R. Howlett" , Alexey Dobriyan , Minghao Chi , Seth Forshee , Zeng Jingxiang , Bart Van Assche , Mimi Zohar , Roberto Sassu , Zhang Yi , Tom Rix , "Fabio M. De Francesco" , Chen Zhongjin , Zhengchao Shao , Rik van Riel , Jingyu Wang , Hangyu Hua , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Wed, 21 Jun 2023 15:52:27 -0400 In-Reply-To: <20230621152141.5961cf5f@gandalf.local.home> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621152141.5961cf5f@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: C783D40005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nfhe8phfj13p967mdbegdh4tp8uieix4 X-HE-Tag: 1687377167-136819 X-HE-Meta: U2FsdGVkX18e39hHgu9oEx5n4gX/11on7FlSl7ZErS1yKjR3cwfK8E8A2H0CHSuSYrEk3fK/qwRlpy9iog+IX2HD+oUnxoi+w0QNzXsMHqYTThWjzgT86fo8QKRGctNnSG89+6lM2ThQWIciem0CsZChDkqa34X7n4miw40wnZFsv69KcFksE/U4n/kg6aBushS2S7tpYTx5h2/+xF/hDleXHzQki/QIGqV5cY1j0Od7InLgQN5H1lknaxSekT33s3lSqpE4WXA3ERB07woaYcVTy3TzGs/MLeMHmw29+XdXPeRMLzuoqmwkMoM8GsMnCkQOeO0lv9Q8MWSVj7uJEz8EjvWTvHSdGQKZg/kA6ECBk54H5W0YCvZDnRIf4ixUmKcPszsWIDyBnbGmDyVzRq9bpg1ow6liZLm5J6BwtOAQHhHxFWz87RT8ig+af1nRaloCmSHyCe293P8z3tRx7ld3xkpFSplx9xEb2+rH+9Rb0TgQf+y+F47oGSd2dwYJ1gpt7eFYjvlLW08/tiNlL28nNguULd/VCucE/Yq6569Zqvxx0F1kmN5yzVN1bAfwDg4G7oeXGpJE0257T7CM2xkYpE3792YzoIXTT6Z+sECsJ2nzah3LNKh+BTYaTo0lNvnpTcavlcsh0F+CJIoS2NpjBhZygLJoIBzLFQXEEnRT+k6TS+WkCwP86ro6ozBttXAzX2hwZycHws5WPEETzEHt9gTGQACB5At2Hg8IomuLi2toh7WvHTd+iL+D9vNM0uISB/qAxkiUrkbh4Bf97jXCkQ8RZkcYpLUEfH0AYKTERfJvER9TKsHVICzzo6nKTOWH9807i7ChsSLZXg2eq+YPK6gueZiB4PjIMBgxrAU1/xIqE7Z0a+Qswc74Dfjokd2YuImA6Ic2DtXFUPxbJTmeW13eFJgxVh8E9MJDs4OKISia/CRlFAFBxHrAogiumWaDtrwS7L5S5q6jJSp 3m60cdKK saffGWQcJTHenxLCfWZOc1gxumiJvmlpPGRkCsmqOzZ6j3fvrm5M2pduofs1U0Qt+l06PWryZX0G/YfhcDBkgcRSnKX31dlSJSQkq5Um5BimzQKAiFTZc8gcmO2AfYlZQ2qO1JyjbU/iUH9t1O5WTz3Cwxoh45gDZ5RtKnCJqaY2PAKLUPwSt7G9gDTJVpLsxMuSQWDGCxsbqmtzNbpqIgJgvpf6HgQWWtLWL0yPZof9n0l22Svfh2vcxZ/EjqiJtatMQoDcvEIzzer3EzWJdV4i9qWsKEua7cC7yJGqXIMqsTBLpx0BsyOekYg891XqdCleYk9vexvqemkNy6XwpuEw5NXAGeSrrhAKkKj/N9UeCy0zAse8jUVOj9/hJUFbZPDgJ0JS/I9CgTgVfZaGSQ6mZhH1sMYYiDtR0EzS/LgrsvBcrQP6d/Z5ddaOcvgyln0j5vnuRb5+6lHel4XrwC3T+8Bp/8VOjwckfM3seFjVJ3Ra/fB623kgi8TK1l11QQxtY30m08SVMZDJhdkvFAiaGS3vqJJrcwUL/sIzbC1JxyVkpUHg7hkdq36HwflymM680/W+zXl85fCVz9NxlC4/oE2mOwEY8/rgcZ/6nh5oNJGQmLIHKSag7Up8liVN+JEOQQuOZLLC8NmJh+weaip2JtjYBmscBGQm9OiAashGXc53hXER/HOj1sptY+ZWnmy1CCyPIdoHMqJeKL3glz4s/sxBkyJ05+z7jEQ4oyUY+OzulBc6HEPSv/Zw12AsRYoQJMJULllqMjBr3pgZHj9CLwjpxsBJ6JTFi+lblACqWqzJWXXP1b7KzWFsceD/KF9u7Elj4PMTYgrj8x6lDfl4pVFPdt4wN86yOkkhU9Pq4egw3qt3O1gokIv9CK846L3m/Qaoxidydb7oJJvLvsSfkYjzuEN0953Vij4QSIoU3pO7V3yOe0Ro5wiljvsLgG/QMcfaFUifhDrSb6c/IRDZ6fqkM Yv86DPK3 QYMMxp/Var7Yl8oIqlpq2ZZaI9NeodRqVdpGKj2TTLTvDFU29XdTkpmQaj95Ckpn0rkhgWPFcsbyne0/VJzPa7qPxZZ/zwtjV5iC+R8l/YGKY/dHGD1uJUvjYb/3oKcUt71lMAen9+YrqEhz3Fj1sPQQhoVyQ9dLV4P298dkRsCRj3pXagroUKqWGnFg0eGhFTG1+XKS7PFFJOjEXFmxV4B/Pe1ntxtlhkyE4Qjlt0yi5R8aLOXnlLpCt3ITVpvH2uPLr15v4iVewSk6QtE6ZFTqOLPTsWvGifj8XU/xn4n6pQJ41OCgyre5U35jAHl0M0ouEmCHjEL37bi8aVDbfqFGUhkOIKMNB5qxHIw3OJlfmovi5P2oxvA+eaCJKi9MGD0aHAVzHVJr/ZHDOm/ReDInRJukfS9oKrEEdnMRI/cuvAHula/HsYjUIEA4N2p8b4bPasOlt1s9MD0umCnp3hRw3VINs2oYlatMCpL9fHit9l9LSpY/z+pes6tTOcg4RfK6BtFsZ8Xsc3fsWcxewExJSt5mJkqVFdH65dIlWOb36lSnuYsHSNhQKQOi4PKZHQQAZy8v8TfmTUOv/MekXYOZ77yH4IyvnRlUjYIyCivQUuJV/vv+diIZAQFtFfQjW/mZjhNEwElPV+xrLmbE8P9C0I6jeXY6wexoWrUyDsOeIoiZ+mRgxAA6bQuTCiy33ddemHhAsbUfCgU4RYge+KReTmkgdLLGEnkfYm7paMN4efZUabdqeUUyv58CnWUwmCAJ59tDVw2lt6qo1xXCUi6p7Ijrytr0df6wddI8EboSjjAK4yt+UZXLFeIVXYr4Ig6lH/Wo7zrLsHA6/UDGHqMI0PXNNgfcwqWOnf+0/5uXsaFOymW2FCeFLKufzkTrBNDCjrteYbGRMo74FL4ah8s7mtpI2bND0PUgNxvbDznacdetfrflqoBVkJptxUAuSWPdpdMa2Lq3akKTWJiKjIl42E1MC Cok41596 47VkbXYT9RJmxDxtih28bO5NB3E6ruSYKDDH372ppKYUBf1AVteYlmxUl9LXqUva0TEEERqnhPjyq2p2Vuys9QcGNix6ff4Jt3STs8UB04c+bYusguqFrbJRWxuXP/Ghrj6tcrdr2pEOKVw4UZ4GhaGQa9c/rupbT68ABL7QV1a1Tn5olufbKDZMvD7vukvrG8A9IIcV5qHVSg0dRrGCeXL2gL4T6xVZbrc142UAr0VXeVyjxNuxONH1hHpk87dT9O1jPsQTfekkmzQn2WRZcit7RlblplMB9FR8vJvLn/DVQY2Vftk5aGz27wK80dBDK92eqC1aDLeF/rQh7FkJ7B1cjCeP+Wv7JLZJWM9FiNgjEhhfcK7PDSdTc94JLh6yxUiJU/7MOelXUuETnEDCCW3bxGqp8p8jh2bWo+9ggkDgTNKY6CTZZWaLfCkMOkMW62Cjx3zCvqx0R1TP7PqPldeSUuHM6+y4H97HSa1DHu0TKxUvmQIBFkiy9V2NgDlvz/kZNjtzTpog2nj4ndM6tm0prDAVGdQfWNxucmucVlfIoVk5NuyBAeSmSKTHIdZ95E6TiLr+GzmOS55d7tUuptY3hxOhh4bqgAkql3CRFEsG6eE2MHzm94TTnPT5ZOyeb1y4BdGRYt1bzwKrxfza1588mqdd2hrs5JczvylYxbncsqmhZCmrSwrzQMjTWizFLlJKGmmFKWLWaLrBzzeRH46ONjPEVuBj0TW0RIkFxAZbSNqOLebUeFqYwjIUPZNt2/qyCIFgGP0y4dOPXf3mY3M0DmgCzOQ31pNarpLKOdOwCzUqvw0umtkWJ+x0PzS0ynzCyZRuozDGPN2bCmxJmLgx/oGkZqcLX7NLM3J+Tncvnr5QSIwuVkNh5c8mjqYMn+yS+Z2JIxM8x6GDJ3Gh4kiTvdxW/877HPu4dgTGvAWeQ7u+SFykwOeTySAAcqG/3qpgKpRBbhzyYH9CQG6roXl2Xeumb 3LNQWN0P IK7G5rT5X0mqhVPlq6AQrrKtqHx5p0flR20I/tZPXaAiCB2IrjSDuj3dK7yiyH2eQ79wmHqnc4foU/PuYU37NfUAU0rs1zVrhrRipkVsGohy+mIHTTVzBHeXfMQXcNOvGblKk+SGd1vPrqxCiD4el1AyTIXE3wGltOEsqxo54eHjisFZqr8saoLLuIMbzxw26ILYRk2Hpx+/gturYCt3QsJ+JL4RoMt5aTGI4PMzlb5obq6x9js0iDZLofnAKR21MZOJ/EkkGI032Ezqlnvv8Q8x0knu+naJQhMpFARE/0lcZBJn6lNJoM9PfC0OpRErguidjGFlNi08GKthEHUgqyrKMKXDXf9INbsZgo5ZFrC6lHbJc9dSu6TXq3txEAElY0BWX9ISk/TD7qvrWd62FpGWhKQDNUkRIZstHMztJMjpLNAltnoc82mHlynfqAQcnG4OzV1KMGgdB/i3AiXBlh73ALsVkgDRsqIivfDYyp5ja2sayOFDpdDaEWyFdPnguU4zhbWwh+8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: >=20 > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That will come later, as we convert individual > > filesystems to use multigrain timestamps. >=20 > BTW, Linus has suggested to me that whenever a conccinelle script is used= , > it should be included in the change log. >=20 Ok, here's what I have. I note again that my usage of coccinelle is pretty primitive, so I ended up doing a fair bit of by-hand fixing after applying these. Given the way that this change is broken up into 77 patches by subsystem, to which changelogs should I add it? I could add it to the "infrastructure" patch, but that's the one where I _didn't_ use it.=A0 Maybe to patch #79 (the one that renames i_ctime)? ------------------------8<------------------------------ @@ expression inode; @@ - inode->i_ctime =3D current_time(inode) + inode_set_current_ctime(inode) @@ expression inode; @@ - inode->i_ctime =3D inode->i_mtime =3D current_time(inode) + inode->i_mtime =3D inode_set_current_ctime(inode) @@ struct inode *inode; expression value; @@ - inode->i_ctime =3D value; + inode_set_ctime(inode, value); @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_sec =3D val + inode_set_ctime_sec(inode, val) @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_nsec =3D val + inode_set_ctime_nsec(inode, val) @@ struct inode *inode; @@ - inode->i_ctime + inode_ctime_peek(inode)