From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B97FC43334 for ; Fri, 22 Jul 2022 06:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C50F6B0072; Fri, 22 Jul 2022 02:12:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 574538E0001; Fri, 22 Jul 2022 02:12:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462AF6B0074; Fri, 22 Jul 2022 02:12:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 38CD56B0072 for ; Fri, 22 Jul 2022 02:12:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F70AA06CC for ; Fri, 22 Jul 2022 06:12:55 +0000 (UTC) X-FDA: 79713717510.08.D04736F Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf06.hostedemail.com (Postfix) with ESMTP id 3B03918006A for ; Fri, 22 Jul 2022 06:12:54 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LpzYm0q23z1M8DM; Fri, 22 Jul 2022 14:10:04 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 22 Jul 2022 14:12:50 +0800 Subject: Re: [PATCH 3/5] hugetlbfs: remove unneeded header file To: Mike Kravetz CC: , , , References: <20220721131637.6306-1-linmiaohe@huawei.com> <20220721131637.6306-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <2a72c02e-3a08-dd66-146c-1b4da06951dc@huawei.com> Date: Fri, 22 Jul 2022 14:12:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658470374; a=rsa-sha256; cv=none; b=VL5vXFzmszVdEQkgaDqZ7QlYF2T/8sCovqxokkzLStyJ1xYXUa4VvBLUt7aH05WU9oS+cs 1Z7wgM6DSWIjz0Ui6gM35iNUt4kdxwHWKg2CEs3F4xEvZqlyYrzZ/cmQQQhHqB73kod+v3 jEBPJU9/Zujokyqi+4ftIdXjV+MoQFI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658470374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BEX1ywZvT/c0M3PE/cZ8vmCEpY77lKKEx0puEe4Sf3I=; b=aDxuC/tDgZHNlpUM8YRtmXb6G26OG/NSlt0H86c1kuxADqLM6o9hjigji2/cOMjRVMvey2 41VTIOSp2P8GYJvwukv7MPMjc9Go5ImaqMY8XiZ7azTACSykqMDttkW6QEq4A/ZF4MJlEw eB+eOmtFIlaRUy7VhiAqnAddEyB98aE= Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B03918006A X-Stat-Signature: czrf7d3yfpgtskjtihwaq7uucoo7fjz5 X-Rspam-User: X-HE-Tag: 1658470374-638699 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/22 7:18, Mike Kravetz wrote: > On 07/21/22 21:16, Miaohe Lin wrote: >> The header file signal.h is unneeded now. Remove it. >> >> Signed-off-by: Miaohe Lin >> --- >> fs/hugetlbfs/inode.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index a10156df5726..aa7a5b8fc724 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -11,7 +11,6 @@ >> >> #include >> #include >> -#include /* remove ASAP */ > > I see the original '#include ' with this 'remove ASAP' comment > has been there since the initial git repository build. No idea why it was > originally added, and can find no reason for it to be there today. Me too. This might be a historical vestige. > > Reviewed-by: Mike Kravetz Many thank for your reviewing. >