From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAE0C47DD9 for ; Fri, 22 Mar 2024 09:24:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 442356B0088; Fri, 22 Mar 2024 05:24:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F21E6B0089; Fri, 22 Mar 2024 05:24:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BAF96B008A; Fri, 22 Mar 2024 05:24:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A3F96B0088 for ; Fri, 22 Mar 2024 05:24:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E70B0A1047 for ; Fri, 22 Mar 2024 09:24:54 +0000 (UTC) X-FDA: 81924140508.21.CB334A7 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf05.hostedemail.com (Postfix) with ESMTP id 16616100009 for ; Fri, 22 Mar 2024 09:24:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711099492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I8uHjlu16AjqAEeseHfO0a200Pi5aGA00Cly8jsvsTU=; b=HwhxhNp9CTRpB1kFUaHZ46r7fs3dWBlTyu8cNKjBbIMIT1RUkxVnli6gTlyQgGdmmzlYes iLK/8Xkq8bwO/3vpsujrD/jypkJVHm3sLXkocj3KhvQqjPpUfMIAd4klJInQiNkuW5rkBP 0tulTh1Jj56AOs+4X5FwX9fUA8JjlK4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711099492; a=rsa-sha256; cv=none; b=3Nn/I/r5i7Z/x+u6Xoc99RIA+ESogrG/hQ2u1pmeEGUOx7QZ+UOmI1NiUs8p0mxQMIZCTz NlkDUuFJO7xqPGZ0Jr8i2ov1+soekITQfpMP5Y5koAVOlUPzDE/HuUmpBKfdXxl7uhNMeC w79ko3emv6mzZwWS7H7rtLUbAph7MX0= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-79-v95uIj2DP4yt8BN4J_ZXpQ-1; Fri, 22 Mar 2024 09:24:46 +0000 X-MC-Unique: v95uIj2DP4yt8BN4J_ZXpQ-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 22 Mar 2024 09:24:21 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Fri, 22 Mar 2024 09:24:21 +0000 From: David Laight To: 'Russell King' , Ard Biesheuvel CC: Jiangfeng Xiao , "arnd@arndb.de" , "keescook@chromium.org" , "haibo.li@mediatek.com" , "angelogioacchino.delregno@collabora.com" , "amergnat@baylibre.com" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "douzhaolei@huawei.com" , "gustavoars@kernel.org" , "jpoimboe@kernel.org" , "kepler.chenxin@huawei.com" , "kirill.shutemov@linux.intel.com" , "linux-hardening@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "nixiaoming@huawei.com" , "peterz@infradead.org" , "wangbing6@huawei.com" , "wangfangpeng1@huawei.com" , "jannh@google.com" , "willy@infradead.org" Subject: RE: [PATCH v2] ARM: unwind: improve unwinders for noreturn case Thread-Topic: [PATCH v2] ARM: unwind: improve unwinders for noreturn case Thread-Index: AQHae3ROEuI+AaCprEesIWGaAOB7ebFB9uHAgADsd8GAAJnLsA== Date: Fri, 22 Mar 2024 09:24:20 +0000 Message-ID: <2b2993fb215c4a5abd7d77ff1c984113@AcuMS.aculab.com> References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710906278-23851-1-git-send-email-xiaojiangfeng@huawei.com> <84a57ca8-8963-ca24-8bd1-ddc5c33bf4da@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 16616100009 X-Stat-Signature: pxdx1nbaxxnqoo981auww88ogs66isd4 X-HE-Tag: 1711099490-695039 X-HE-Meta: U2FsdGVkX1/QdhYrHMnFoo062ypCCirD7iZzTif8mZPtP7d+8Md0sRq2XE3jleUJXHWdDrFiPOdV1tuUfE420x8LyUUNIU2ws2xbPSFZk3LPCGlYUjXV2iAyZ5XTxnsf8odqNEVRa8YgEy5n49Ktf1df5fhO4izcbXx7+Rr0SiSMBqo3x3DAA+ZX3V8WncelzIuyO6/GknoztPp9yaJnPlA80oJDXW90MqLtMxGCesY3bAAl7lyH29ym9X/6kmO2qZwbDi7sDr3hmSAiNm4psN4hgj5s3+cqedxA1uqqSOQxPiVP4h7JG9bYaUsyxq7NhtQBSPhwvQmbASyPx38ZjbnBdniuJlhiIr/JgsWRUGKA5NbiX/ngweix3rYxDYam1Ibm3kjytCnTknxXA9trZpmKQMj0Iy/kXIHrZb4kHyPplf6mL+teLfY6emLPWv5gVAbSdy6hNiNptlrPxUfvDJOTBB5QruAFn8fFutfzGDyLq+AYZ3BBEdO0zMz14YWUiSS2Js8qMTKxpq86mS3A+RdvIP5FCCef5f4IAmnxdPrGEOxOKCCq7XQrcUGdLy8khIa1zXa9cz2sq0G+BPI23jWM6S/82Jaz+niFi/n0drXTq9R0a8U6jh8tj/AccKLIawxhBGqU296WV5bd3CkkobOMgf8zdd2YGyv6WYUSAzaG32SsJdwsXJ/Ic32uSsPQ2dKvf6ZSU80SJUf1tdxU7FX17Ir2RXymcayTJzDrKpW+yxsURsWTZQSPHXm25gF52gG8rhI6cCKGhIeui7AwCLcloG/p08ttxMKcJy+wO/pnOgbsw2ynP/ouuryoXmIhOlrqq7N2ig6p6A9JvW1IudXmrhIDGp94vRZS05w2D1w3YUIYug5LgFc6UNxBOi1Ps55DRRe+o0iyXAaFb8+GazsJiZnThEYpC3vVvMxbyRf1smPEZABFUcUmeDQRFA2icswzb0EjwznNnfbEwYU s1Btv20H FkOa+EPsEia/yBibfxCUlU5ywxQF4I3Xyq20M8xyos1tEc6/+fS25xYzQ0d4hdF656HE+6MMTwCTbBDjY5u5JccKgFp1BUJcCRPAYHtJjdRWuXTr1hiKM+xD2y1rBOyEQEszmT05vd0BQ9MqtEGYBvWP7WDFbm+pxxikNVd7pvoujUUV85Jvh50X9JSxm+xuASENFY0vKiCMz6yqFCI9ziJW4PF0l/n0cC2WxTL74GmpfnTs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Russell King > Sent: 22 March 2024 00:09 >=20 > On Thu, Mar 21, 2024 at 11:43:41PM +0100, Ard Biesheuvel wrote: > > Given that this particular issue would just disappear if the compiler > > would just insert a BRK after the BL, I'd prefer to explore first > > whether we can get this fixed on the compiler side. >=20 > Arm32 doesn't have a BRK instruction. What would be appropriate after > the no-return BL would be OS specific. It would need to depend on what was being compiled. For the kernel it could be much the same as BUG(). (Probably without any extra data.) I suspect that arm32 could use 'swi' in kernel space, but you wouldn't want to use that in userspace. Looks like armv5 has a bkpt instruction - could that be used? Or does the kernel need to support armv4? The last arm I wrote anything for was a strongarm. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)