From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87902C3DA4A for ; Mon, 29 Jul 2024 22:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7186B007B; Mon, 29 Jul 2024 18:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D565B6B0083; Mon, 29 Jul 2024 18:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45566B0085; Mon, 29 Jul 2024 18:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A87AF6B007B for ; Mon, 29 Jul 2024 18:10:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5680912070E for ; Mon, 29 Jul 2024 22:10:57 +0000 (UTC) X-FDA: 82394186154.03.EB8DDE2 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 582B6A0008 for ; Mon, 29 Jul 2024 22:10:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gx51g8O5; dmarc=none; spf=pass (imf15.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722290995; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KsaV4aHVmDy9BEabdtZUIrUBdmxkjCnLJv1JmYCf5Ew=; b=LWGNYpOVxe+CgLwRVQa4+rm4jxbpOmeO0RKFHub55DQz7DcNcjMIiI6f8hRZMrKbaVTHvs /TNsLFK7zKBskECV9ZAjVm4TpYxpH2web3yhZ7/sAqtU95TZGlfW6UY/jf7yNrtNjjrYZO jh4Rgnz73SKFpo5IhEuafObpnyq7Lbs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722290995; a=rsa-sha256; cv=none; b=LG98DK2p58KbrLM7oPRhBd3hlFjeXZfkshD6jBRHHjJbh9ExzsI0+EGYvpQ7RQVdyZXO/Z uZmQ1xPBwqw+/NNGvSd1xO2jVrjp4ziheiWHzluIi+QErrmvP8Nfnaum938731pFGU1bsz ctq6REbMRC5X+fFHBjBPo7bUGDwSZtc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gx51g8O5; dmarc=none; spf=pass (imf15.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=groeck7@gmail.com Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2caff99b1c9so2286922a91.3 for ; Mon, 29 Jul 2024 15:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722291054; x=1722895854; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=KsaV4aHVmDy9BEabdtZUIrUBdmxkjCnLJv1JmYCf5Ew=; b=gx51g8O5awmLb3WYqu5zOFjwW2ttiKn83b6cMOuzsYVj78goda4fVbX5HmRvi2HlLj 5Dr5UPlu6BOBWHFSlEDgR3LJSI/1xiSxOcJ4sXbn21CVqOUw/LUOHII6D9M8ygUKIkyD vMFUBAdstYwvqSy1Nqh23SqgS6RgAfAXM/xDAslgvKgmXlObENHhZzYbdYnFkBzwLHr4 EWMtTFWh2MXpVbkpiEOGWC0tXa56ZOo0g/aeIBudsGafIA+34+g70OmY7FOaImdFfA6q ObdValE//PpVPL6RoF8SCh3j5IfuzgYPNiIEbXROuhTqlxODKSVZU66DDqy0xr5bZa3L yTAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722291054; x=1722895854; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsaV4aHVmDy9BEabdtZUIrUBdmxkjCnLJv1JmYCf5Ew=; b=XMnwkBK0NlJucCERUvJFr3WmNX7kjmw/ZmjLsOmB/ZY/RuvXdmnxiDoJWJvKI2XQNm M9ahMEcjHTgho++0fU9IP16lnjHDPjAcDYZY3HLWxY3xHaLgYqTqGG+fiHwed810tmXV EmisMQ/tkqWDk1eymV+rFTJVoX6ra02mU4IN0hsM+69H+Qk+la5ts77uVNF3ooAmE/pX a4rFE+4xYjE1y+EE1UKWFmcgvLHxRyU6XHCeU9cAZvEOl7khm/2E4T0W39umOmS0FdGV AVfxXrUa+P88hBNow8rEI/0LXrltIN2JV9wBzxqpf65hX8ctNffc5ITy2pvxdPbVi8Ye dtLw== X-Forwarded-Encrypted: i=1; AJvYcCWIqt1TFTmiEUL4C7QEKD/rlg0dVzGi2KSt+KyFsXUJODFMa0YXQx6qvXCJP4qJ52/mrgmPCBhstTEtQJJIipaMqY0= X-Gm-Message-State: AOJu0Yx2Tu+6R6LOaaOw5USf9TnJGoL6fLYG6HeNLiLrCcf6S616okmL WE8GRcGOF7t0HWbL5xQwe5kZ+ttkvDv4qQIngGUWu7Fv7Zc72K9Y X-Google-Smtp-Source: AGHT+IHFgFcC7a2AZ2iDodzdSo6v8vO5cepaMu/+vRjjPgAt8xw8okI5cuuhotMAuv9cY44n3r+MCw== X-Received: by 2002:a17:90b:4a0d:b0:2c9:9b65:af4d with SMTP id 98e67ed59e1d1-2cf7e098639mr6500208a91.7.1722291053817; Mon, 29 Jul 2024 15:10:53 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cdb74e9d4fsm11164225a91.35.2024.07.29.15.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 15:10:53 -0700 (PDT) Date: Mon, 29 Jul 2024 15:10:51 -0700 From: Guenter Roeck To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Oscar Salvador , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v7 16/23] powerpc/e500: Switch to 64 bits PGD on 85xx (32 bits) Message-ID: <2c7adbc9-609d-41a9-8a3b-a63d59e21a1f@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 582B6A0008 X-Stat-Signature: tn5odocks3upwe585nz4i1aauqiwj8mt X-Rspam-User: X-HE-Tag: 1722291055-423680 X-HE-Meta: U2FsdGVkX1+eVehtor08UXkETVuPgNWJjT+35vc5foWdYbMIE+4wKBlE0ZNEPLzu+e+98FwNyr2xKiXgyO057SbAOlGHaq14ewGMi2oHqbnLQzgLd17QMpQkXjfBfItPeEINDkIEzoELWGEj5V9DTj8Sodwtpt9yVlw0B203y5XYxYuQR7jnBHiNRoUOi1BQH2xuJnMqLenezc5G7JfcqJeBc8V4xPvHDtuBHKkl4yKhV7sS7Pdb0nGgPXdJdyS/urqyuq2UZV+mLhOIHNTjAsTZJMbYIomp4QpVNJSQvRVWmv6YW5nArBBRmyDUZglFOeYOemmVkPGcAfSZwrxXtnaoqbZcN+WDBsLHWbS/92AZs5NijwsFXtmAJxrJO+uRAfYmLykGYgNunretrGRyAlxsTcDEmXO19HlytuZZeOWOPxk5FpEXDfZdxC+RH/eg7PxuJ7+ewasrkMT8sP90ByuZDwjg6sJzl/AqRbwmoKS8ebkJvFEIrvkM2F1Q9V8zTxeGpWHFLLKWQtwK+wMMA5jMEM2r0ZDmz/NAHKkCbJMztv9ucboY0DEgoGEOW4nV12W0TxYh1fzvwPFKL3fIZOntAoDIDIbCOCb62za0OBD+lkiV6afXz5LQlPruq951r0mOYUEn2ufVBOaCYlHBJV6fMaA61cih7s68aPYw5hUCG/kHq7Ltz5NbClCTwAxrcsgCY9DGXzuSBjheeosRTDcMCmHjXU63wLl+Gdr66idDzmlhWLfgeUDAcnIZuToHGSR8G2bohNKWDyM+PAW/Zk2AD4rv5wSE2ElkbP9lIcZpb6XMrOlUOJY0d+Y9+NgqKjFymzOKs2l5Ib/o5kAOz/AG2hFenJ3b3BxvUnGo0sR3aLpDTdEN//w1PCRDWsxQHjmo+b1pSkSLwftuqw2YtJscFO2/TDEfiGVd2DjhKXu5VC9NkVoADdqK+0Hv0ImuhojxTUMLwGGHfdFEFBQ mP4VKx8L WyfgBDI4gOMpH49wM7hXSJS6oXigKnfrTk/z7EV6C0gZZOCf3gRBjTetdK5K0p3MQ1pmYveOFfsR2WP+iFLplaz7E87n7wTu+PqbxTTAu21CKfoPSycfhb1uCVHVDp5Dr2dKd/jgP1Jvsijmet4R4k/Gpaa37HgOoQnI08zJySN1Dznvpy0Z5byml1JdzA+45ouFX3CQj3KWIILODpE0FxbayRC7qB3jDDhuFYc2w7X1WEkDB610mk58L9gtVz1unRvh4I7d9y0kGTUrLI3rjpF6h0dJSSJ4ur46mOT5V2GwgX7gSeUeVlsIcNACEWFzp8c6F1Zhw27GRjGuNS92bL8xoEh5VDHudgoCSHDhnTnTWQHKycuw9ZI1YSeAKlm2UIv1dLIAooE5xnaz99ahMDYKXeTNoCEpz/2PdmL+FcoqaZDUNzmsea7TIzQdzF720YjV9g8aTfLcGg8mwCWq8jzEF+W3VPoykSTlOop1+MT+CmmYqiIOwqBQgpb45IvzwOKmLDvQKn8pivXlMvWuISIBKmBCjJAlfX35IDIHFTH/302kuS+vr4+zkhhWfpmL9txEqAIea9Q9/Me3Q3tz7ZZ3BYH8mrVh6XyIN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jul 02, 2024 at 03:51:28PM +0200, Christophe Leroy wrote: > At the time being when CONFIG_PTE_64BIT is selected, PTE entries are > 64 bits but PGD entries are still 32 bits. > > In order to allow leaf PMD entries, switch the PGD to 64 bits entries. > > Signed-off-by: Christophe Leroy With this patch in the mainline kernel, all my boot tests based on the mpc8544ds qemu emulation start crashing. Example crash log: kernel BUG at include/linux/pgtable.h:1599! Oops: Exception in kernel mode, sig: 5 [#1] BE PAGE_SIZE=4K MPC8544 DS Modules linked in: CPU: 0 UID: 0 PID: 1 Comm: swapper Tainted: G N 6.11.0-rc1 #1 Tainted: [N]=TEST Hardware name: MPC8544DS e500v2 0x80210030 MPC8544 DS NIP: c01f51b8 LR: c01f6fec CTR: 00000000 REGS: c4135c40 TRAP: 0700 Tainted: G N (6.11.0-rc1) MSR: 00029000 CR: 24228288 XER: 20000000 GPR00: c01f6fc0 c4135d30 c415bf20 c762e3f0 c29c9318 c7624ff8 0000026b b5fc2ea1 GPR08: 00000000 00000000 5a5a5000 b7f4dd55 44228282 00000000 c0005014 00000000 GPR16: 00000000 00000000 00000001 00050003 24228282 24228282 00000000 00000095 GPR24: c1375b30 c4135de8 c4135e48 00050003 c762e3a0 c762e3f0 bffffff1 c7676a08 NIP [c01f51b8] pmd_write.constprop.0.isra.0+0x4/0x8 LR [c01f6fec] follow_page_mask+0x150/0x17c Call Trace: [c4135d30] [c4135de8] 0xc4135de8 (unreliable) [c4135d40] [c01f6fc0] follow_page_mask+0x124/0x17c [c4135d70] [c01f7170] __get_user_pages+0x158/0x5d8 [c4135dd0] [c01f7750] get_user_pages_remote+0x160/0x560 [c4135e30] [c026838c] get_arg_page+0xb0/0x25c [c4135e70] [c0268dd4] copy_string_kernel+0xf0/0x200 [c4135eb0] [c026a0e4] kernel_execve+0xbc/0x190 [c4135ee0] [c0005108] kernel_init+0xf4/0x1d4 [c4135f00] [c0016224] ret_from_kernel_user_thread+0x10/0x18 This is with v6.11-rc1; the actually observed crash differs from test to test while running bisect. I can't just revert the patch because subsequent patches depend on it. Is this confirmed to work on real hardware ? If so, do you have a suggestion how I could continue to use the mpc8544ds emulation for testing, or is it just dead ? For reference, the configuration file is mpc85xx_defconfig. Bisect log is attached. Thanks, Guenter --- # bad: [8400291e289ee6b2bf9779ff1c83a291501f017b] Linux 6.11-rc1 # good: [2c9b3512402ed192d1f43f4531fb5da947e72bd0] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm git bisect start 'v6.11-rc1' '2c9b3512402e' # bad: [6dc2e98d5f1de162d1777aee97e59d75d70d07c5] s390: Remove protvirt and kvm config guards for uv code git bisect bad 6dc2e98d5f1de162d1777aee97e59d75d70d07c5 # bad: [30d77b7eef019fa4422980806e8b7cdc8674493e] mm/mglru: fix ineffective protection calculation git bisect bad 30d77b7eef019fa4422980806e8b7cdc8674493e # good: [c02525a33969000fa7b595b743deb4d79804916b] ftrace: unpoison ftrace_regs in ftrace_ops_list_func() git bisect good c02525a33969000fa7b595b743deb4d79804916b # good: [8ef6fd0e9ea83a792ba53882ddc6e0d38ce0d636] Merge branch 'mm-hotfixes-stable' into mm-stable to pick up "mm: fix crashes from deferred split racing folio migration", needed by "mm: migrate: split folio_migrate_mapping()". git bisect good 8ef6fd0e9ea83a792ba53882ddc6e0d38ce0d636 # good: [a898530eea3d0ba08c17a60865995a3bb468d1bc] powerpc/64e: split out nohash Book3E 64-bit code git bisect good a898530eea3d0ba08c17a60865995a3bb468d1bc # bad: [00f58104202c472e487f0866fbd38832523fd4f9] mm: fix khugepaged activation policy git bisect bad 00f58104202c472e487f0866fbd38832523fd4f9 # good: [e081c14744f4a93514069e1af1a7273d5451b909] powerpc/e500: remove enc and ind fields from struct mmu_psize_def git bisect good e081c14744f4a93514069e1af1a7273d5451b909 # bad: [57fb15c32f4f6a4f1a58f1fbc58a799c3f975ed8] powerpc/64s: use contiguous PMD/PUD instead of HUGEPD git bisect bad 57fb15c32f4f6a4f1a58f1fbc58a799c3f975ed8 # bad: [276d5affbbaea4d369d1e5b9711cb2951037f6ee] powerpc/e500: don't pre-check write access on data TLB error git bisect bad 276d5affbbaea4d369d1e5b9711cb2951037f6ee # bad: [84319905ca5f3759c42082e20ed978c81f4dead0] powerpc/e500: encode hugepage size in PTE bits git bisect bad 84319905ca5f3759c42082e20ed978c81f4dead0 # bad: [6b0e82791bd03b2326c7f7d8c1124c825742f2a4] powerpc/e500: switch to 64 bits PGD on 85xx (32 bits) git bisect bad 6b0e82791bd03b2326c7f7d8c1124c825742f2a4 # first bad commit: [6b0e82791bd03b2326c7f7d8c1124c825742f2a4] powerpc/e500: switch to 64 bits PGD on 85xx (32 bits)