From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651A9D1624A for ; Mon, 14 Oct 2024 11:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E13586B0082; Mon, 14 Oct 2024 07:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC2E56B0083; Mon, 14 Oct 2024 07:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C63516B0085; Mon, 14 Oct 2024 07:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A8D6C6B0082 for ; Mon, 14 Oct 2024 07:54:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1ABF3C0DB8 for ; Mon, 14 Oct 2024 11:54:30 +0000 (UTC) X-FDA: 82672050510.02.345C0E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E04434000D for ; Mon, 14 Oct 2024 11:54:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VL3CSidd; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728906734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sw8SdMoxvkqT+oJ6QjaS4Mdlocpgg8B3j/K0BV38W8E=; b=h8gPNtRQ1DfR9CguRcHobIe03QrOsik5LjQuQaW+hlq7SBuyv3dG0EwlRjJLqKYtvXtMH+ papl9a2g/dHys++OVCs1QOVXlx4qXJ9SFff0bwe+4Sy53LxOTGa1baI03Fpz0aI3uAnEtM oyr2zPxbdAtNW/IBi8uVB50WoniGjwM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728906734; a=rsa-sha256; cv=none; b=bRk5DBvDxRPgqCWdhZcIrkNbrBy9RrlhhAf4tDQbMzvYiQyrnrLCxcOmgaIsyFEjNMTG7Z bYbWuCiA6pw42w5dtjKyS2UzUBeJbV/J3uCAIRJn2VIiVFtvM7Ek/iqJM5SM8qSto/fgaU OZigtsBE+ytQTLOsmxzf08v3ivk6H0Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VL3CSidd; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728906875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sw8SdMoxvkqT+oJ6QjaS4Mdlocpgg8B3j/K0BV38W8E=; b=VL3CSiddjHisM2EEwn7QfUrdS3ka8bTb1nThfjTtkFM+vdbT9M63j69CoRz8bzEqTkF0SE SdBSQ3n9xrj3zujoqsK9f8ZSx+nthWJ6ae8V3hOB6Abwe+D93kUXpXf9S6652DHx5ngcre oSYEOdlUiG/xkkSuO3kzIODG3UN3laQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-yItSptFcPXSq0rhJBx6inw-1; Mon, 14 Oct 2024 07:54:32 -0400 X-MC-Unique: yItSptFcPXSq0rhJBx6inw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d531a19a9so1539982f8f.1 for ; Mon, 14 Oct 2024 04:54:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728906871; x=1729511671; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sw8SdMoxvkqT+oJ6QjaS4Mdlocpgg8B3j/K0BV38W8E=; b=L9VAauYhCvFMCzzPITvqzkFmD5KUtS//W2AcyD1RIREDROAs5FjEtCZYAbUPfsq9kS irOrgFSSM+IXzGdeJLILNLDCiwVouEz3LL6PUP7cMVvbuBAlkDyAxTIqbweJoNSFLFdA eX2vKGqnBsn52PbCK+a2IUjpK9MoXA7tLaI+xHaF6igS3w3Cxg6boS8SO58VYmz4Bq28 aC1ugGeaVKDLf79gV7JqPJwmYKMZmdPbh9NvLNBPe3BLYmcbwWG55BXluKi5C/4qSdxo ZHmHeR2+Q9R/yJiXb4hLiX+edhSohz+OnJ6ggfTmGBYC9fEBLpRq7vBegoOFak1GBU2N X7bg== X-Forwarded-Encrypted: i=1; AJvYcCVtXSMH6Jct6BZCt58i2gJYRCAnrmz6B/AIIMUwJlvzRR5v5FYtsFEIL5eYOfFiHsax9hjZbnGzOw==@kvack.org X-Gm-Message-State: AOJu0YwBWrPUoFMjHzb3xse11pKzyZ+9vwqXOC9pmxAL5L1HePTBSWHc NT24pEYbSbk6p0ojJDNewT0gHA1quMiCu1wOzZp8wUbpkMmn5vjsOBp+ECmuQxySIwn0tVnlggB DUt6/aPvUhClVT58gfrgfh863YMBU6JNIDr9MOSHRLVhe6EzF X-Received: by 2002:a05:6000:1092:b0:375:c4c7:c7ac with SMTP id ffacd0b85a97d-37d552cb121mr7706947f8f.49.1728906870987; Mon, 14 Oct 2024 04:54:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEACD/nWJW6zvguB1SSmBU+FZvicY4wNaBqIk+Gz5VEXsWYT2ZpRvnBnDHGA7inU6EB3h6eQw== X-Received: by 2002:a05:6000:1092:b0:375:c4c7:c7ac with SMTP id ffacd0b85a97d-37d552cb121mr7706932f8f.49.1728906870578; Mon, 14 Oct 2024 04:54:30 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6bd584sm11152917f8f.31.2024.10.14.04.54.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 04:54:30 -0700 (PDT) Message-ID: <2c854e5e-c200-4ed9-bf21-778779af7e5b@redhat.com> Date: Mon, 14 Oct 2024 13:54:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] memory: extern memory_block_size_bytes and set_memory_block_size_order To: Gregory Price Cc: linux-cxl@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, terry.bowman@amd.com, lenb@kernel.org, dave.jiang@intel.com, ira.weiny@intel.com References: <20241008044355.4325-1-gourry@gourry.net> <20241008044355.4325-2-gourry@gourry.net> <039e8c87-c5da-4469-b10e-e57dd5662cff@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E04434000D X-Stat-Signature: in5wbaby58orgz5gymw11dpnhdiuckum X-HE-Tag: 1728906869-813227 X-HE-Meta: U2FsdGVkX19JLJYgB8szQ8UsXPod8vX5dyhe7g8Fmf3sx2eeZl6d0k/ZQOp2T8sEq0XAocfjVPxKneKRubg3U5/bBROCW3IGIiEh2ktBOiC5YmH5jjitg659atCDT/GWUvN/o2fZXo9JZlMwb26BvjEdB2jHzzEkR47bZ4KV4YDeQIHfNc50/bPUs+OHHYCBMdUebYWDOAPhUqwu/WmxU3IivKmkqxY2p94O4AcMIpAyJxiHf7xc1pPS7NukYv29xMBYErkz4bqSzfvtwIZGuE9mJAvMPIHnmlIOd9/WTRyMxJWdS0fQyZrlrHuH8DHk4TrFFZ41W60jriHCr52DYTcQLThcFOp+NyxMQ23oPiUDkHaxCzum2lRx9Su2SPqvMFblG0DEqXkuVRoDtjHWU9D2OXUgfIe3+3URbxd3KmxSRhyKh1DPKA79gg31Z9ruB+py2RrOmytum3HJyh5HSHIq36mYO/fE4wDDGxHZKANP6g+gb3xWJodPzy6KbbTQ9n5jJEkX1xXxAxAmqYN1d5lUGzB9V1/Sso7UA0aiD+X1u0U7j9g70XjqOoP9iVM/79+D4LDJZkS/OoanMK9pOXqYM8cDn8memzrybWgZy+aWYEkIqyX9z5RcmiJZlHKunMaG34SXA1T7c42e72QQBiN6APL0WXiwptBekUIQIrjXWqmNU+AhDS9am57FtAn7cGOpHIndY8lvD78MCRSvZIM4GSsPrk3Wc+o6V8CWv+9hIdNdCBpNOVJz/4IFDfp5w/kCwIOO5ubEDthWrNs08cujBIpmJnB+eOwMAQsdJA336pmXVdLm7tVDHBf1fovD+yYzKoI/CSTn55wrlnXMVrabloM3RTJdUkdYT/SuIXgEk3kgJeJKtWe8HFdDo/LTn+KEGF52OOJIii4WtjesmwPClm6/xyI1fWSfP8dRZIr2h0hO3JvAxAcawKUCquMih9AkZBfPtDlagFAUxkW a2ICEdhn HxWtawhCP/zHrs9hgRIP3zyqeWDFdnSc1OuzUiVT55OZOQVhJspz/uke9OW/k0seBhtl4g+KlQJ5E5aXUNbTj1w60wmwiap8t6syyKj/CXapiDnwgaRA6JK8H6v10AHAVi87em30N+YB78HqFEmv0RV74HicpLlrd10jHrXcOdIwwLgUVOOKzBSvN5AXTzG6kbMk4DHAR0FuOaogJiMc2Wr9Vxp4CzwCxdnagm4ebHvLHCjnz37BBX6YSyX8O0TAefUTSIxcdUys22w9TmAfFqgJUAvHQyFTYQKmnTQ8G8DNkD15HNJ1RLwHcOo5YQ+g4d/RU7JxFNNSmGYjIrfxT1/TESRkhm0bAoldebzP9eY2e35G5ymieFsHoj/AHhw88s0+gcskPvRQUqec35+PZHu6P//9xY5ZrnLdm5RHaACA1+saJxO3M8xVpWPJj8KifqRnWsPdr4TxxtmlYrD0N4/LKw8T40ZISbKtl69m8U89ZGH7xlvQJsSp8bnXep3t9h+Wk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.10.24 17:21, Gregory Price wrote: > On Tue, Oct 08, 2024 at 05:02:33PM +0200, David Hildenbrand wrote: >> On 08.10.24 16:51, Gregory Price wrote: >>>>> +int __weak set_memory_block_size_order(unsigned int order) >>>>> +{ >>>>> + return -ENODEV; >>>>> +} >>>>> +EXPORT_SYMBOL_GPL(set_memory_block_size_order); >>>> >>>> I can understand what you are trying to achieve, but letting arbitrary >>>> modules mess with this sounds like a bad idea. >>>> >>> >>> I suppose the alternative is trying to scan the CEDT from inside each >>> machine, rather than the ACPI driver? Seems less maintainable. >>> >>> I don't entirely disagree with your comment. I hummed and hawwed over >>> externing this - hence the warning in the x86 machine. >>> >>> Open to better answers. >> >> Maybe an interface to add more restrictions on the maximum size might be >> better (instead of setting the size/order, you would impose another upper >> limit). > > That is effectively what set_memory_block_size_order is, though. Once > blocks are exposed to the allocators, its no longer safe to change the > size (in part because it was built assuming it wouldn't change, but I > imagine there are other dragons waiting in the shadows to bite me). Yes, we must run very early. How is this supposed to interact with code like set_block_size() that also calls set_memory_block_size_order() on UV systems (assuming there will be CXL support sooner or later?)? > > So this would basically amount to a lock-bit being set in the architecture, > beyond which block size can no longer be changed and a big ol' splat > can be generated that says "NO TOUCH". > >> Just imagine having various users of such an interface .. > > I don't wanna D: Right, and it also doesn't make sense as explained in my other comment: this should never apply to loaded modules. :) -- Cheers, David / dhildenb