From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Parri <andrea.parri@amarulasolutions.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Hocko <mhocko@suse.com>, Minchan Kim <minchan@kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning
Date: Fri, 31 May 2019 09:59:00 -0700 [thread overview]
Message-ID: <2d8e1195-e0f1-4fa8-b0bd-b9ea69032b51@oracle.com> (raw)
In-Reply-To: <20190531024102.21723-1-ying.huang@intel.com>
On 5/30/19 7:41 PM, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> Mike reported the following warning messages
>
> get_swap_device: Bad swap file entry 1400000000000001
>
> This is produced by
>
> - total_swapcache_pages()
> - get_swap_device()
>
> Where get_swap_device() is used to check whether the swap device is
> valid and prevent it from being swapoff if so. But get_swap_device()
> may produce warning message as above for some invalid swap devices.
> This is fixed via calling swp_swap_info() before get_swap_device() to
> filter out the swap devices that may cause warning messages.
>
> Fixes: 6a946753dbe6 ("mm/swap_state.c: simplify total_swapcache_pages() with get_swap_device()")
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Thank you, this eliminates the messages for me:
Tested-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2019-05-31 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 2:41 [PATCH -mm] mm, swap: Fix bad swap file entry warning Huang, Ying
2019-05-31 6:10 ` Michal Hocko
2019-06-01 0:14 ` Huang, Ying
2019-05-31 16:59 ` Mike Kravetz [this message]
2019-05-31 18:27 ` Dexuan-Linux Cui
2019-05-31 19:16 ` Qian Cai
2019-05-31 22:36 ` [EXT] " Yuri Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d8e1195-e0f1-4fa8-b0bd-b9ea69032b51@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).