From: David Hildenbrand <david@redhat.com>
To: yanfei.xu@windriver.com, akpm@linux-foundation.org,
vbabka@suse.cz, pankaj.gupta.linux@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()
Date: Mon, 19 Oct 2020 13:54:44 +0200 [thread overview]
Message-ID: <2dfd5820-ca92-8a73-6dcb-00b6ce6c735a@redhat.com> (raw)
In-Reply-To: <20201019115044.1571-1-yanfei.xu@windriver.com>
On 19.10.20 13:50, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
>
> There are two 'start_pfn' declared in compact_zone() which have
> different meaning. Rename the second one to 'iteration_start_pfn'
> to prevent confusion.
>
> BTW, remove an useless semicolon.
>
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
> Acked-by: David Hildenbrand <david@redhat.com>
^ huh, where does that come from? (you should only add acks in case they
were explicitly spelled out)
Anyhow, now you can keep it :)
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-10-19 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 11:50 [PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone() yanfei.xu
2020-10-19 11:54 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dfd5820-ca92-8a73-6dcb-00b6ce6c735a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pankaj.gupta.linux@gmail.com \
--cc=vbabka@suse.cz \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).