From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F2BC10F16 for ; Tue, 30 Apr 2024 12:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00A446B0098; Tue, 30 Apr 2024 08:57:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFC646B0099; Tue, 30 Apr 2024 08:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D764B6B009A; Tue, 30 Apr 2024 08:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9C876B0098 for ; Tue, 30 Apr 2024 08:57:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 66520A0143 for ; Tue, 30 Apr 2024 12:57:15 +0000 (UTC) X-FDA: 82066198830.15.0616BE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 34D53C000E for ; Tue, 30 Apr 2024 12:57:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dpYqt1EW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714481833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tdmWCPpmVqkWt86tR0W6U1iJvD4JBKCQgQGu1erF8SY=; b=IVlL117YBg0L+/oxgddeSlHxGLLbuEhiuay07G4T5YeqOrauBGEa7uVWZTZcd9v4dPsC4r IHT8QKIqlPBEasRmxUdZqyUiVOc+xkeb3TWU2u/9xAJdQOdY4p0Q1a8l+3Fnz3uXp7QSvc vJM73Vd5T1cbxOAiHhiFsxNPWCiyz6A= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dpYqt1EW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714481833; a=rsa-sha256; cv=none; b=SYeAk7ZltRJpUZx7luBgb6O9+Fj9zK7k5yeyAAgr6M3RMmFiLIoxB+uCgBUet6Ar0gUhjR onqoeYvbIoH6FZ4mqc5sCKVZehKktQNa3HWKDd2VKn/27gf5gJ6pNevBlafj9wq1YxiN+v OYUeriKUgEk+jR67AVoYR69soBbm+NA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714481832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tdmWCPpmVqkWt86tR0W6U1iJvD4JBKCQgQGu1erF8SY=; b=dpYqt1EWfnVLnvEgJ2CXUJsmaQOuX9OxjsEHoxSnfkswjprX05f2FnweEuILwbAYbsJ10T mgMcKtE6tpa7lGtT9ASjOwat82CbtjQcQzHMSHJ9qq8JgrygUy7ja7nDQCQUwnh3wsOYBw pANSrgO5JfQ7OoOmg1PCzUjqL2OU/lg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-5L9TlJVyPCuaq--BHd-p2w-1; Tue, 30 Apr 2024 08:57:09 -0400 X-MC-Unique: 5L9TlJVyPCuaq--BHd-p2w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d871086a09so49837931fa.1 for ; Tue, 30 Apr 2024 05:57:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714481827; x=1715086627; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tdmWCPpmVqkWt86tR0W6U1iJvD4JBKCQgQGu1erF8SY=; b=a/isAtNd3zegZnhKSETDUsvr0X75d99N9uoSSvVZL6SHZ3GTUtxxwHjJqR7TMoFt+K kKD40XMmJcRjCMvUaHwIB9ccmjQGKW/hrpY872jem39E8I4xdCnafXT/IVskhaRt1HJg 9I3DyDHzdb9dB9zCcpdrkg9/J7i6FRLPrVErx4Tt/JrIS2X9WtmkL1jCfCAJ0ymQfiUE KKcRwakCJPuL8bzL8FmN/Zxz1VfdRZAcV5WeLxAED4uNoEq41iBRiXPPohkcNsx+lavw ZgnPNdLr0MH3nmgAcV1KXMUPpeSo0uAPT204HGohLjZUo6qBp3LPQp0nex0dN85lA6fs 4DCQ== X-Forwarded-Encrypted: i=1; AJvYcCU+AmjgCbVYiUuyYmlMAAdPeCRRCFL0Sesj6zrnpByji1YwKrrFj7uYLHL3C1JV710M2CfG9PJNhbAJ/L3v6ecrbWE= X-Gm-Message-State: AOJu0YwawgTndYZpNVB9MKdgI82979Uz5DvkTYrNAKgFFpOizdCBPwKi L78RQM/+zkmWZhvUy8ez9/6SyCXTCvnFs+W5CIbUVd71F97JydjuIiUrxLWh/TD4OrpPrYKaoMz 9uxxfOs80wW9siqP+pXG1i0s+/rfMfIJSol9QXt699eIzK7Rr X-Received: by 2002:a05:651c:1203:b0:2df:b800:5bff with SMTP id i3-20020a05651c120300b002dfb8005bffmr1950516lja.7.1714481827488; Tue, 30 Apr 2024 05:57:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHA9aBhSm3Z+YoODJcL3qGk7/YolGF5A4cU9eyC5WpAQQZTSVCRHwNLK+yS5LAnJY/RSv4gIQ== X-Received: by 2002:a05:651c:1203:b0:2df:b800:5bff with SMTP id i3-20020a05651c120300b002dfb8005bffmr1950507lja.7.1714481827073; Tue, 30 Apr 2024 05:57:07 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id r6-20020a2eb606000000b002d6eee825bbsm3933124ljn.133.2024.04.30.05.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 05:57:06 -0700 (PDT) Message-ID: <2e074a0b-7ab6-4381-9216-31f68a738a07@redhat.com> Date: Tue, 30 Apr 2024 14:57:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm/ksm: rename mm_slot_cache to ksm_slot_cache To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, izik.eidus@ravellosystems.com References: <20240428100619.3332036-1-alexs@kernel.org> <20240428100619.3332036-3-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240428100619.3332036-3-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34D53C000E X-Stat-Signature: q3xk7xb7m5gfzjua8tedodfhji4y8y3x X-Rspam-User: X-HE-Tag: 1714481833-286480 X-HE-Meta: U2FsdGVkX1/TCZCnCL1cu3b5q1OAqfpk6VKsT6QXRXNq5c1WSi+NYZF1aNMgkDXT27VzyVTIaimhNnsVDrEsifpadEQgJOpkNakREyuELfNy0s9Xmb4zhUBXa+c9gccWxWijMvr0hnUdd2bvf6kgGAsrTAw6U5onMG0iJ1EYQ4dzk3p4ArRONU8P4i8iKp9z/bQFAg1YBjKolOFkyp2PCKO5jgNFrmeB1uaWNCYM1lPcc06ydb1IkI3uUGW1m5KwLizfYrWD4IE4YyZ4s/727aNCGgjGPWyYelN1CVI8HH6ONxSwKWwtPPsDxw8A9D305jyhMXQDVJszLLXeZrEd4TI7VWHLGznEpCiyzBkjx6rwac6cthVCeS55P3P2VekzZeXAYL90bKjLW7S3ZjKrCA2FS8Na5j0PKtZsh2rhlDbrXmPP/uOQaadppNMW4QJllPap8Qv5UJwYqAxj3S2sK1wE7xDO3dKpB02VYFA8aJZr3tCNkAtbDXDiB7n8qRs/RrBbR7PgM0j9ykZLJYZTENIr+OnxUvca47LzRhg/B+1EY3puaT4+Ue+uJbV6vCOPT/x5HoHXzktqCS0GONYfdOpwwQHSp1J55VZmdn7GjkV+pvXfGq2FUrZbHFYBXLs++VzdYhRkDvQuBIQn8rE02bekdGAOkL3xAQnOLN37kHSYpLXWO4NI5JGz1kfzUgHGCq769yjdGPOEpudCxpNEtDZz7Wflw6i4EKPTAlG59kWVhvRi1yrTkT3cDPVxvU6VOcqnlwRPfptijfgEOVfRolI9Oo6srXeJdC6jwFarwuMqz4VgsnWIkljBmfsHBo4sgVVdIl32HW+AOPhF7Ek0oZGEBG39bk9MsVVj/diJmMRrlEo2c3rYFwU3OC4C7otVnn8cRamPjNQXuiDdingAzK6WueA8SESMlA6Zcw5tLEuV3qxBkzuwfES355+/CquaiYBZwsK6Mh7Mj8cxy50 zcuHuPGt AUg1N/ekxkiyawd9+F59VhHN5Ehen2/l7PyC1GJMbfvDWUXbgC69ME47Wnz4hXytkPqg5ZRkXIZBL6muOCFdJKEcJ7cgt0zKbfWXvvO1dcFrdurOS4HqTbq66Eahve5XpZOhGBVAYFr2vsQmrmq1C7XgEHukyo4RhzT1H+PBwzcJTiLAi+iDTqyqeVBkcCEMWOtGdcqVj8DQMEj593vcY237o31/1gps7gf/E0PyYYhEs8QE/x2hbAn1e82aA2j6r4pHBZFCqVAVWEVB0CHCwLoSR8nt0VL1FXa1CHWXLN3T5UPkDrAgVSdshv9gIqp5j766dtU+8AULU5X8ni05bu39GWJ98sLgCeds3Rl901KXLMU53WC0l5h6DwMP7wh2JurSwEingtDXXntOSRV2eM34cTNy5vbwL/dJ0iWnoSyPEHtYcva6u5t803+XWrDZX9R/TnKMKvq4lm6HNSsnZbXGpO61lDh4OOr/bhIX1zQ+lbCtg8xDD6jLMuruMlFpcRMu1SEsjyJfZ11NAn2aByhXAu1ZxyBNLMScU93csHU78lq3q+O9wA0eqsBxltdiAReVY1UiFZCywXOykXAoDGEw+cb7duUFDpPj6USYNf/MqRZb+PWLzh7xMqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.24 12:06, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > To distinguish ksm_mm_slot and mm_slot for better code readability, > rename mm_slot_cache as ksm_slot_cache. No function change. > > Signed-off-by: Alex Shi (tencent) > Cc: David Hildenbrand > --- > mm/ksm.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 6efa33c48381..22d2132f83a4 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -247,7 +247,7 @@ static struct ksm_scan ksm_scan = { > > static struct kmem_cache *rmap_item_cache; > static struct kmem_cache *stable_node_cache; > -static struct kmem_cache *mm_slot_cache; > +static struct kmem_cache *ksm_slot_cache; > > /* Default number of pages to scan per batch */ > #define DEFAULT_PAGES_TO_SCAN 100 > @@ -502,8 +502,8 @@ static int __init ksm_slab_init(void) > if (!stable_node_cache) > goto out_free1; > > - mm_slot_cache = KSM_KMEM_CACHE(ksm_mm_slot, 0); > - if (!mm_slot_cache) > + ksm_slot_cache = KSM_KMEM_CACHE(ksm_mm_slot, 0); > + if (!ksm_slot_cache) > goto out_free2; > > return 0; > @@ -518,10 +518,10 @@ static int __init ksm_slab_init(void) > > static void __init ksm_slab_free(void) > { > - kmem_cache_destroy(mm_slot_cache); > + kmem_cache_destroy(ksm_slot_cache); > kmem_cache_destroy(stable_node_cache); > kmem_cache_destroy(rmap_item_cache); > - mm_slot_cache = NULL; > + ksm_slot_cache = NULL; > } > > static __always_inline bool is_stable_node_chain(struct ksm_stable_node *chain) > @@ -1244,7 +1244,7 @@ static int unmerge_and_remove_all_rmap_items(void) > list_del(&ksm_slot->slot.mm_node); > spin_unlock(&ksm_mmlist_lock); > > - mm_slot_free(mm_slot_cache, ksm_slot); > + mm_slot_free(ksm_slot_cache, ksm_slot); > clear_bit(MMF_VM_MERGEABLE, &mm->flags); > clear_bit(MMF_VM_MERGE_ANY, &mm->flags); > mmdrop(mm); > @@ -2713,7 +2713,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) > list_del(&ksm_slot->slot.mm_node); > spin_unlock(&ksm_mmlist_lock); > > - mm_slot_free(mm_slot_cache, ksm_slot); > + mm_slot_free(ksm_slot_cache, ksm_slot); > clear_bit(MMF_VM_MERGEABLE, &mm->flags); > clear_bit(MMF_VM_MERGE_ANY, &mm->flags); > mmap_read_unlock(mm); > @@ -2972,7 +2972,7 @@ int __ksm_enter(struct mm_struct *mm) > struct mm_slot *slot; > int needs_wakeup; > > - ksm_slot = mm_slot_alloc(mm_slot_cache); > + ksm_slot = mm_slot_alloc(ksm_slot_cache); Similarly, this makes the code more confusion. The pattern in khugepaged is similarly: mm_slot = mm_slot_alloc(mm_slot_cache); I don't think we want these renamings. E.g., "ksm_mm_slot_cache" might be a bit better than "mm_slot_cache". But then, we are in KSM code ... so I don't really see an improvement. -- Cheers, David / dhildenb