From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8F5C07CA9 for ; Tue, 28 Nov 2023 16:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79236B0271; Tue, 28 Nov 2023 11:59:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B01496B031A; Tue, 28 Nov 2023 11:59:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86BBE6B031C; Tue, 28 Nov 2023 11:59:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6F5936B0271 for ; Tue, 28 Nov 2023 11:59:03 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3B0D6A0301 for ; Tue, 28 Nov 2023 16:59:03 +0000 (UTC) X-FDA: 81507972966.27.40FD7E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id CC195C000A for ; Tue, 28 Nov 2023 16:59:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gpB+Q9JO; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701190740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ARXPoGFWKY6GPjLpkC0tgTNlXBydSFtVB0gMxNB1348=; b=0nl8z+I0hnX6ZlgnUgUTJMIfJScjLCUIvh+Zfrlvkz/yb4wNBK0QBX3IShMuDa9I/MaAzC HFbihvO/f03tDh0pv3SiIGXd8dhyBRg6ppVIvOgPpqTzJDMmcxv626e09tRPhJnbYgMyb8 xn6YwYQwO1BDrzmft7loFIzaCUv0xKc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701190740; a=rsa-sha256; cv=none; b=yVw6+G0pphZ3Qt81CiA+ww/kQMTad4VM9pmxvII6pAovcPrhJmUPu3s7360htK2HgVBcGU vBI/DwnzaRTLRniQN9wfWGq+P+Bzk0jOeIYRj7e8TjXkB/OOiYMHazH2yflFOMEI4PTR35 y7n5BW4njGInLZnxRASZa9jrVmTmwk8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gpB+Q9JO; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701190740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ARXPoGFWKY6GPjLpkC0tgTNlXBydSFtVB0gMxNB1348=; b=gpB+Q9JO80TBZXZlKmIeGQgaq9oqYdDE7RAn4w1jbHAnGMWw8oF2/qFQ3tPXi9aSkyw1cO FErVlqg3vCMJgH5UR3YeJkWnUvYBLjgMK1K1uepw+T6QKnY8Th5m6FRaTPKXtK1KkuWXm5 lQKVcU/W5kEetdzmB3rXSD6c3OQxnnw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-M-sPcwSRNNW3eOeoZBRANw-1; Tue, 28 Nov 2023 11:58:58 -0500 X-MC-Unique: M-sPcwSRNNW3eOeoZBRANw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-333030e0708so1568927f8f.3 for ; Tue, 28 Nov 2023 08:58:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701190737; x=1701795537; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ARXPoGFWKY6GPjLpkC0tgTNlXBydSFtVB0gMxNB1348=; b=vPEvmI9zsgYO34UX3Ku1fzop0S1T1SGpLncyux1tVv85QM51D6o4XsSTSagcKxN1uL otTAiE7nqE6RnJ585mrbnhs32+ZPT2uoazHKw1pWhN/AVLwcEClAuG+MAVRImx57sd8S 0Av0Iac4ejwKuI5NOd5jBBSAUBh1x+/CLpogVAQIbMAIi3fG08wFITcxgvkaGUPipXca RkP4cp51v7GBmB6hfhCXC7ojtheitTJfq4Kl6FaIyh5JFv8vAGGLwsAfYkVxdZRfqvLa 4CjIBcOn5+3oZkKd7DDfzULKdr3To8KMwijtPXv27dcsRePRXlDRLOcbEedY3gQ9jeii MN+g== X-Gm-Message-State: AOJu0YzWz5Ubypm5JXHqt6w6X+n1oTZOHydujhlNQN3NiV7ANnDMhNW8 aDIZ3JZSoOQkUT2jJsJO+C+kWv0ZN+s4012qiqvoaJIgcPDJkF2YZIinJMV/wLRHZTO/Erkk4U3 xZ8NgFmqK8D0= X-Received: by 2002:a05:6000:b44:b0:331:6e10:e51d with SMTP id dk4-20020a0560000b4400b003316e10e51dmr11664600wrb.31.1701190737613; Tue, 28 Nov 2023 08:58:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrI5mA/WuLGFqFY7554t1sO60OVxHSrP19L9qI42Lhus8e7ZvfT9ziI2Wde4LI9kXUjO94/g== X-Received: by 2002:a05:6000:b44:b0:331:6e10:e51d with SMTP id dk4-20020a0560000b4400b003316e10e51dmr11664570wrb.31.1701190737210; Tue, 28 Nov 2023 08:58:57 -0800 (PST) Received: from ?IPV6:2003:cb:c708:1d00:99ec:9656:7475:678d? (p200300cbc7081d0099ec96567475678d.dip0.t-ipconnect.de. [2003:cb:c708:1d00:99ec:9656:7475:678d]) by smtp.gmail.com with ESMTPSA id m6-20020a5d4a06000000b003330aede2aesm2717126wrq.112.2023.11.28.08.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 08:58:56 -0800 (PST) Message-ID: <2e2d3f51-34e3-4982-b982-ab7b555cba21@redhat.com> Date: Tue, 28 Nov 2023 17:58:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 06/27] mm: page_alloc: Allow an arch to hook early into free_pages_prepare() To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-7-alexandru.elisei@arm.com> <45466b05-d620-41e5-8a2b-05c420b8fa7b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC195C000A X-Rspam-User: X-Stat-Signature: wnma18hiydcqoibp7qk13f3f5u16o3xd X-Rspamd-Server: rspam03 X-HE-Tag: 1701190740-671568 X-HE-Meta: U2FsdGVkX1+82VzUtyDjJH7QGnwT7Oqbbfow6GOZkx8j5OahUlmegZ+SOHiD2WgRZlFJDFWDYYUmuTfRJatYWbKfgIYTpapeFECE6pBnqeBreGUv35ODSeP1L1bONtdzMvP/ujnDDjEFgWEIxt2KpVAwVEAnxhW0TZtKaNN6LvibkX5osZM5bFBbUoSm7Aj775l0hR0UKXkFytaVnDVTK5yP+mPn53aMSwpHYsZBrZYfE62u+WdXbI2W9LRcpsH/JiKy14TYvUx2G+pMXtmzlvO4F6gdh+4VmPwCMv3Fbtd8H6wRusQWrccd/bZmLvEKD6Fwr0Ro2KUe5eQ50m05yjRzy4Ihc1tLPS1ETmOYiwMVx/7oWJG8MBzydXKeZgz9YRyI9JZdomA4Vk2KjZMncdZ0ukrH80LzRUcoeR0luOlNf1ePbemau8dIPvji7WWDTFWoehdJ0SBGw/wDE/me7+8hsBhCji53dn6wx1/QNeoqvucFC2aGOESrG0+I8XlfJJAn/97C5w/PwT8bRMKHtVYduyMjVaKP/SGIajZHeip9vUAq2bxUVyhakpJ8ewobj2xYVSO+9L8f2nwhQke+ctfbVK9/zRETNNoNBHpWgj2q7c6L9JgZZXT+rcMvJyygaXLSepHTKCNr5+4/o++ZWWpXO9oQXgkCpGCwsbSuXbG1tNvBAZJu8e+u/EpNf7HxkwSWB2EJacytJYR5i4l7mEKUJuhrp2qf4VzUBSq9BRFLdZEHpOVqKtFPjYeyu5hCLy9dEzZTDrrNgGqrsMsKy2oI7zIdP8kyFfA7Nq0ulp6sTPh75STwoxr8aWNwZUe/YwCnX+lHwqRADXtRCTuwtmKObn9tCGFTqjTRJqwCmbxlTtnyEzhyAdPMq6/yEmLpSqatAUNkOo3xEKrdB135DP35ie8VU+kbvHa+jPIC9CO4vfnJHd8Gsm8n23DXgA6rpOuttxwVvJSk0KD4RHT CR15jUE7 hugoUN/2eTFUXORnfeSnDjeu5gFwcg6JBzApmicuIkhSv7wnvlOkcyYdU8olZJJQprdRjdio9DgSWh6KgsVUE//RZZc/jU/dAmymHflspH87h3RPDOzYlx2+YAELBdZ7TgOCAmtfkIkKB7s0dN/iMI2BhsyZS6Io8ooRsSKKdV8+Y+eZpx6+6sIEbzLUhFL5+BoBABrnjPk52zAYJgyAnfmHVFHrWoV0661FBZDnvz+OETciC6aOsDb1HXCM6LnNDIzbR1mqa4HsZiiQqGIU4Y5cy21xn2OrEkjN8PWrjY0Bv3L1PjB6XPeUTKPGPkQXKglHRzn+4HWdEqKYYFvm7wlXi8BTkTZq9NvfH1s1fUike3beU0RHSOz4Zur3TEsSg8/AKMBdh22tvmsQZtG+qpX5t1eACa01xC4D8Z7H4MY6O3rxaMZbkmirgtexLl0SeoZWIoe9cO1bzWxtlhP67JJEDYA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.11.23 14:03, Alexandru Elisei wrote: > Hi, > > On Fri, Nov 24, 2023 at 08:36:52PM +0100, David Hildenbrand wrote: >> On 19.11.23 17:57, Alexandru Elisei wrote: >>> Add arch_free_pages_prepare() hook that is called before that page flags >>> are cleared. This will be used by arm64 when explicit management of tag >>> storage pages is enabled. >> >> Can you elaborate a bit what exactly will be done by that code with that >> information? > > Of course. > > The MTE code that is in the kernel today uses the PG_arch_2 page flag, which it > renames to PG_mte_tagged, to track if a page has been mapped with tagging > enabled. That flag is cleared by free_pages_prepare() when it does: > > page->flags &= ~PAGE_FLAGS_CHECK_AT_PREP; > > When tag storage management is enabled, tag storage is reserved for a page if > and only if the page is mapped as tagged. When a page is freed, the code looks > at the PG_mte_tagged flag to determine if the page was mapped as tagged, and > therefore has tag storage reserved, to determine if the corresponding tag > storage should also be freed. > > I have considered using arch_free_page(), but free_pages_prepare() calls the > function after the flags are cleared. > > Does that answer your question? Yes, please add some of that to the patch description! -- Cheers, David / dhildenb