From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB415C8303D for ; Fri, 4 Jul 2025 12:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64D276B034F; Fri, 4 Jul 2025 08:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FD626B0350; Fri, 4 Jul 2025 08:26:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C52C6B0351; Fri, 4 Jul 2025 08:26:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 361256B034F for ; Fri, 4 Jul 2025 08:26:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 56FAEBDBED for ; Fri, 4 Jul 2025 12:26:31 +0000 (UTC) X-FDA: 83626505382.25.1C3D09F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id BA20A40004 for ; Fri, 4 Jul 2025 12:26:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WOO9VWAh; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WOO9VWAh; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751631989; a=rsa-sha256; cv=none; b=1S/68dhBGkxuzAeFEupjC1ArfzA1Z4D50axKl/aSlPtuI8PwoKKOIkfvIdsRlvjGQ6urCY 9Tc78il3FAECwF25M3rbLDjI2Q/fZca+O7Bbfj3s4k+99r+JxfidmLVOurJPJ/GHsGUaIa XFTex9N6uesN0t9QtXkJ/sRW14aqG4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751631989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LwrtP2ohqgww8L0pkCnMNZNw56s3R4h9U7S/03uZr+U=; b=KhvSr6typfhdgKlxxpQdP/BgvTdF7EezmMqv3eBHwDsBxUfOAvNaqYUlIv6B0wgn3hHyKW QlJAcS3D9FdsQ/GvxNexGIiV+91CjlL0QZZJzBeWganTVhGHmsAH4RS4hgiTyQBjlH+CkD 9uhlme4s6kIsqoNsoO/1/R8aKd+/PbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751631988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LwrtP2ohqgww8L0pkCnMNZNw56s3R4h9U7S/03uZr+U=; b=WOO9VWAh5rOBZMLQtTuXRz2F4fbIjbzrP274ZscyLL2XD6Z6oH1XA19QLyWCuWnF2TB/2r 41nQscyspeC/2APuEnpda4OHyq+MyDOwfO+TOfftMwOFzC5bPuZglQWogs+HGCSenlPPrh Nnhl1WgUkq8uF9N3Gx409SCzOpKGJD8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-IwonHdSOPgeEcp4YTD98FA-1; Fri, 04 Jul 2025 08:26:27 -0400 X-MC-Unique: IwonHdSOPgeEcp4YTD98FA-1 X-Mimecast-MFC-AGG-ID: IwonHdSOPgeEcp4YTD98FA_1751631986 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so385912f8f.2 for ; Fri, 04 Jul 2025 05:26:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751631986; x=1752236786; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LwrtP2ohqgww8L0pkCnMNZNw56s3R4h9U7S/03uZr+U=; b=YNzaqv+/NYeYAodl9Bs22+8eTFdvs0hnsa/LKQjeun6MBl8dTu+PxHLl86cjhb8m2m E5naR6Ej16c7f4W82uc7FNtbngkfl7+FL+7+hZU6wT3TVYygtc0+kriI86mZaITvhaAl /b/n3qSHhU6aoig2hVYFjrySo0bQo+xPyCJibALaeuDI0I02KaARJEF4jhbGbqO9NRk0 3nbfsaHd5iqtpYaS/tlvX7F7s3fyOW3On5Mee1QcbkueQcbMpverhhLQDb0yee4sGl2x VhkXsx5JG2ZsLYHH8QBIjQmiieyLtDIhXkaFi4rnPISjjNwezOzJM+GiNXQ8Z9LleRvf qDbA== X-Forwarded-Encrypted: i=1; AJvYcCWQdX2Rga2AiVNwH0yo3CeWUJoF/iKKYEy0zlT4A59k4YNCH9OLP6QHPrMVRJtuT7MvyKm99Z5+cQ==@kvack.org X-Gm-Message-State: AOJu0YzdxKLpl7LEnuf64mlg7qfooRYzX+fPlRxFUHOQA0DcGVKdmDoV HnDcnk46kYpdsrkfFXKbTGUihRtUEt/+ny1C6BYURQ/QlcrwxYWWJU/zlRb5fBL3aOFctTxOGsG mwqmfGpKk4EMc6Gf+tITteD4j3I0+SQdY37iwJdj1ZaXaoBgZ5fxbYMNlUSbcdwY= X-Gm-Gg: ASbGncvgHve7Zw4oocKcU3X4WMHJBckehykvfHqAiO2wHIUGeowRH1gohqIbVfGHUFw 0BpnQhW16/Hf8lomf9bhAuodzr7UZ0uPVF5n3E5Ms4szQ48xLfbp2SjgqLghr9iCUP3L2AlaUra f31p0YKtGLz9ZhdFPIex0FN4VQBPXmBVMQnp5YnYXs0oCprz6QpHiZNayUpPq2F9FPW+p3NF49s /+9OMF9yOtO5vq95wOFQ53oYjFIND99224bMVixYST+umQK1YGjTj5uSumvaFPZyYLz5Yu9eTau IXIdRQ1UtH/qntJJvtnwdXlLfAJdXMjJHP/nJs9HpGFryVNa152uKXYtqG2sIDi7UwCENJcwEQI 4B3lNLdZ+96xkUnYEtg8Z2WZCu/CkPFM3/KzQmFoMGMxlF5o= X-Received: by 2002:a05:6000:2210:b0:3a5:39d8:57e4 with SMTP id ffacd0b85a97d-3b4964f7100mr1994277f8f.41.1751631985604; Fri, 04 Jul 2025 05:26:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGif9mwF2i7UqA82Ew77czIh0FcIerZ/4mVS/jiEFbY6IbIQ2Gu3YRNQOoDcjdhckmR2R0taQ== X-Received: by 2002:a05:6000:2210:b0:3a5:39d8:57e4 with SMTP id ffacd0b85a97d-3b4964f7100mr1994253f8f.41.1751631985050; Fri, 04 Jul 2025 05:26:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b97732sm2419638f8f.59.2025.07.04.05.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 05:26:24 -0700 (PDT) Message-ID: <2e7855c7-0531-4e9c-a6ac-c413550e78af@redhat.com> Date: Fri, 4 Jul 2025 14:26:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm: pagemap_scan ioctl: add PFN ZERO test cases To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250702142052.45116-1-usama.anjum@collabora.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250702142052.45116-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VTBT8DtdEbwbIv91sEtoULB_ry_Rby6MynKlI87gknE_1751631986 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BA20A40004 X-Stat-Signature: hh63u7rzgdf96nn9az1yq6y6bhccobi6 X-Rspam-User: X-HE-Tag: 1751631988-673417 X-HE-Meta: U2FsdGVkX18sbskdSlCeGREdYV0e7pvmKaHOY6Q0ynk6C/yh5UGjVk+7pd59uXg06r2FK7zv4YrbLIisTRPYS2yW/IkY/ZeE4mz0VQlWZ5ve+YF1aucGkt2dyryE2lf+yopFbTP1aAYSfEHBm/oyDKQ7grphywHHMH8vahDq7Av531J8yFJ9sdds9aCWLrg9doQzyMpKVaVhDSq/yRy7vZLPkaBRSmI06zeJ/0gTZ3HPdIBzA+FCuhi6vAg+Kzl/HJ1QzTWT3ZWwARSrvFa76zhb/eFclXJ624GnPe1vbzx8ZA9TK8VGjHRmzneyAHDN/7o2B11/qejFmOOdO3zJ5Br3+X3KVP3yaLxyXSzMJyKvDOqqDJfVIfWsVmaozPflJtVOM3pKMrYJalq+L61foGzDRuCF+9gho+QmXavBHssHc+jWe/a17DSKXTHrhm529i9Yp8HJzYroY6R01EKrN1TUE21XxZTxmc0Q0Z5nKyQsWVFQd2UT4az/q+mLaW/EIsmZJcVNoq6VdRSBKtp4AfezSeDTNNqNCwPgftYVydPDElxg3qfhoZTw0dkcakAEnbSlZ112R477dkkAzZKbE9IABLKHsP4j8A2Y53wGqt2fI6gl/0+7pJRF35SlAaqh1/NpQ06y76J0sz04ogbxki3i/2IeRbWCizR7efDJFF+ziRJaJuvJqRBlrQEPPud1U3QJQxPbRDq33IE3LTo0x1IYioiWyC1kk7/DjOIoH5wWfZDRE2GJFvssWsrSmSZcsdMM+2ySKCtpYF2jhUGZnfj3MCGuUmtrpkZIk24MdbBvoJpLqL01QsTS4qJN54rtRYTQQx3TEWPQwf2j3G/5eSEDAdMNH96ivFPgsbf08Fl4sVQMAxftsVGWLkZDM1HkTT1JCHiEcb5SfbaQr0drRpPcp4cV3jo0Dr0WYq+dzwx5IxB2yGNgi7RdvIMECWX1lntCPmXQ1Pp7WD2KSs1 PSVK5G7T 18SyVF0niP/NpiJPsCQKZatVT0+GVgV260Xv/lavwfa2nS0ppUtjoME68ZOpcSQQ7qmsisa/3vL0tK+5dDPxcfrLABoHotQ6jmDmJHIh/5dNiG8sXBkOtvPB24fgXtP4fuC4D4DQ2Ux2bdd6UOnkZTg4+rmETRkBzmxpceDiHQebAzywnhxBMlY5qeChQZzwkSlT1t0pzbhEqhYhIr1p4vIeZlkrfWM0h1VSJzJRALZBeetXXWzhn5nlVHcXrlYe4BK2XptpeRnwzCI6PpjzrvAbJg66Y55X1fg+OEXttOZjNwCyXok9sMni8hIgWR2vL6HXK5Psw3Q/94IU5TQYTKUtVEA8qWIxCcnU145qWvoYgLd3bWUYSTOh7FUswRn+yiCEE7wsilF5mPw8kwJQn7v35WfL7GYZDnvAWJB91KfShTgq4nIW+6lxsPE+DFRStjdJcoxHwtGj9HchkPMUXG6ptlWsBCq7ZFsLLfDt0N5g0C7AQQQ7Qq2AhB2tadszWdqIEa5xKbcFZfikpoLA+oSKVoQw/FnnAzoOPQ7V6JEnDB/n/mYcHYVhmY4YZDFZQFhIXF4eiX0U0WfA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 16:20, Muhammad Usama Anjum wrote: > Add test cases to test the correctness of PFN ZERO flag of pagemap_scan > ioctl. Test with normal pages backed memory and huge pages backed > memory. > > Cc: David Hildenbrand > Signed-off-by: Muhammad Usama Anjum > --- > The bug has been fixed [1]. > > [1] https://lore.kernel.org/all/20250617143532.2375383-1-david@redhat.com > Changes since v1: > - Skip if madvise() fails > - Skip test if use_zero_page isn't set to 1 > - Keep on using memalign()+free() to allocate huge pages > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 86 +++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index 57b4bba2b45f3..976ab357f4651 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > + > #define _GNU_SOURCE > #include > #include > @@ -1480,6 +1481,86 @@ static void transact_test(int page_size) > extra_thread_faults); > } > > +bool is_use_zero_page_set(void) > +{ > + ssize_t bytes_read; > + char buffer[2]; > + int fd; > + > + fd = open("/sys/kernel/mm/transparent_hugepage/use_zero_page", O_RDONLY); > + if (fd < 0) > + return 0; > + > + bytes_read = read(fd, buffer, sizeof(buffer) - 1); > + if (bytes_read <= 0) { > + close(fd); > + return 0; > + } > + > + close(fd); > + if (atoi(buffer) != 1) > + return 0; > + > + return 1; > +} You should probably factor out detect_huge_zeropage() from cow.c into vm_utils.c, and let it return the result. > + > +void zeropfn_tests(void) > +{ > + unsigned long long mem_size; > + struct page_region vec; > + int i, ret; > + char *mem; > + > + /* Test with normal memory */ > + mem_size = 10 * page_size; > + mem = mmap(NULL, mem_size, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0); > + if (mem == MAP_FAILED) > + ksft_exit_fail_msg("error nomem\n"); > + > + /* Touch each page to ensure it's mapped */ > + for (i = 0; i < mem_size; i += page_size) > + (void)((volatile char *)mem)[i]; > + > + ret = pagemap_ioctl(mem, mem_size, &vec, 1, 0, > + (mem_size / page_size), PAGE_IS_PFNZERO, 0, 0, PAGE_IS_PFNZERO); > + if (ret < 0) > + ksft_exit_fail_msg("error %d %d %s\n", ret, errno, strerror(errno)); > + > + ksft_test_result(ret == 1 && LEN(vec) == (mem_size / page_size), > + "%s all pages must have PFNZERO set\n", __func__); > + > + munmap(mem, mem_size); > + > + /* Test with huge page if user_zero_page is set to 1 */ > + if (!is_use_zero_page_set()) { > + ksft_test_result_skip("%s use_zero_page not supported or set to 1\n", __func__); > + return; > + } > + > + mem_size = 10 * hpage_size; > + mem = memalign(hpage_size, mem_size); > + if (!mem) > + ksft_exit_fail_msg("error nomem\n"); Didn't we discuss using mmap() instead? See run_with_huge_zeropage() in cow.c on how to do the alignemnt yourself easily. -- Cheers, David / dhildenb