From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF48C636CC for ; Tue, 31 Jan 2023 14:06:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A3F56B0072; Tue, 31 Jan 2023 09:06:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82B586B0073; Tue, 31 Jan 2023 09:06:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3A36B0075; Tue, 31 Jan 2023 09:06:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 57F0A6B0072 for ; Tue, 31 Jan 2023 09:06:22 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1EFE11A0BC4 for ; Tue, 31 Jan 2023 14:06:22 +0000 (UTC) X-FDA: 80415269004.30.CFC6A6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 315DF180004 for ; Tue, 31 Jan 2023 14:06:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpsK4qCu; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675173978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9t7OLLXi4skInjN2+18+qU6/sB4l5NfmMr6BbX3yli0=; b=lmCQvnwYsg5vJGAs3qViFQuy/W+6So71pZvOBlDQiLzy955HRU5mKWx6C4w+qiLZA/yepb a4cZNDTH8c3zV+wFZoB7GITr1neTW5Vros4HwgS585RkcX8aFOkbltOseCFuFWm86ggILY VJ4YVdHQ9dZtu+5Gf4Fo0B6U3dKVHo4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpsK4qCu; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675173978; a=rsa-sha256; cv=none; b=rfN+HxqvzesCGff2oaUGwJb2KQ3XZY0Tl4gY0/j7h2Nj7tJ4fBDPkH0fx/KQI0uDu9qVmH NbtGVkUwO2p/z4c4BULq4/v3r7Vgv6Sp5hR/WjFrvFSYA5wyp5kmE3mQD3427dlWQzmyrp 6nfkdqN/rvKSCbn1L/sx5Kj/9inxijA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675173977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9t7OLLXi4skInjN2+18+qU6/sB4l5NfmMr6BbX3yli0=; b=bpsK4qCu4L05rluiZUA5uAn0Wz8onQPX8B5lyzRkiTd4M20JtjooIuF8MtIeWA7MkfDR5L xnUxLw046FqESJ72OZN6H+xEUnHxIToqQNGtaLQZw/Kv8Qsk4h02HeQZADS2VQuGE0rw+2 K6nQ2KXJTcVbwTveRES+GM4LKITko04= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-rcPbsAurNcexUpSVCclbUQ-1; Tue, 31 Jan 2023 09:06:14 -0500 X-MC-Unique: rcPbsAurNcexUpSVCclbUQ-1 Received: by mail-lf1-f70.google.com with SMTP id f17-20020ac25091000000b004b565e69540so6897841lfm.12 for ; Tue, 31 Jan 2023 06:06:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9t7OLLXi4skInjN2+18+qU6/sB4l5NfmMr6BbX3yli0=; b=MsvBy67bqklPrgCU0ZHeSFrw8lX1Dg9plf7Lm5PFDrSCVs6pv9Jqs2/TqV3YkgfMww 9L/7NbAVtFPdfo5oU8DAkfde8ILjyNaZ2MdOXKAUDZkGmVWVX0QQQOADQ2H1+WN9gD16 75CjC0xQTmdXCK+tZLSFKIR1pWGEHNYardaQ9EPb23Q51Q6Log7Dmuvq58poGE38tIUK BH7S9fQgXYzz4NPmEAGF4iZizotCVH+9St6FdBUCK+25we840MjtJc13jcl2Rs7v31+Q JJQOKTSwtKfmW2xkzpdStXUwE/oF3EiKG9bTpMkqKyBIlh6td59Q6brVoacTsCbcoGHb 3qcg== X-Gm-Message-State: AFqh2kr5HwJm2aFnZKYu04Y9aNiGy+y6pgyZcfq/s7BHNx7KuPRce6iM RWibF0W6P++MVmMgJzuJdziLEziDVOzEH5aDyyccUWLZXZQ5PAnZOrjk0bX7RH8CsuEwYOTxU+H fL6wRitsYyoM= X-Received: by 2002:ac2:44a7:0:b0:4b5:580f:2497 with SMTP id c7-20020ac244a7000000b004b5580f2497mr12384942lfm.17.1675173972609; Tue, 31 Jan 2023 06:06:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXtA0p71nxA5Z0/5H9aAiSX6mfy5IKwcV36g3anoGiNtTFdcpz/YNCVXKyXo4vEMIRkqH8QCdQ== X-Received: by 2002:ac2:44a7:0:b0:4b5:580f:2497 with SMTP id c7-20020ac244a7000000b004b5580f2497mr12384914lfm.17.1675173972161; Tue, 31 Jan 2023 06:06:12 -0800 (PST) Received: from ?IPV6:2003:d8:2f0a:ca00:f74f:2017:1617:3ec3? (p200300d82f0aca00f74f201716173ec3.dip0.t-ipconnect.de. [2003:d8:2f0a:ca00:f74f:2017:1617:3ec3]) by smtp.gmail.com with ESMTPSA id m2-20020a056000180200b002bfb5618ee7sm14804139wrh.91.2023.01.31.06.06.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 06:06:11 -0800 (PST) Message-ID: <2e78d261-9ae9-d203-446e-eaa3c652ca6e@redhat.com> Date: Tue, 31 Jan 2023 15:06:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH 00/19] mm: Introduce a cgroup to limit the amount of locked and pinned memory To: Jason Gunthorpe Cc: Alistair Popple , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch References: <6369225e-3522-341b-cd20-d95b1f11ea71@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 315DF180004 X-Stat-Signature: xf6rzp799dii81jt4oreeuj9dx4c6xts X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675173978-854323 X-HE-Meta: U2FsdGVkX1+kIk0lWZsPBllpOzPApRB0SH1oEzd+Ss+KUXWUh+zOFDBrLvs+iElzKahsWYfCSdxsTTjZAyj2z5HFskEYZ1WfOvAlHzkcUAqsc4am/rSfNXke7r0GHHqgNqMdFF8LqckRXHURbUNDGHO0nnqWoCqMNkZJ2UcEgGxhl2/0bBP54aVKYApZj3QdKtYWlLMoQxbBU0xKuZyVcyCj4WRwSHeWW3VoILtP+A/GfGNuzvBi0wWP78UHeIMnZksUOVTiGsxNyRc/odw6Te1ycSig3ZFT/cqDsE+JNJRcLntvZaHa4oLmwKma5xrphtHiUNCN5Ekay5OBfCgTjGalmCnrJZcb+mk/gJuaMiO8Y5jTRqXN6Ix40CdkatcDrLEWSAe2XZU/5XvTW+5o8JLVjgdaWeJfAMm0mSeIHWj7y7nGdZwh+IEGBTjyJYGY+2ruH8yKYUzsWoXzlWaHh6XhnQg9C0Ga3CONbFA5fNKm1tUJ30sHUtLGYY2MCuKkCfFfwgCRII91sC0zdxnjKEDjOORiCNdzYJatnWIodY5gaFiT8swtZToken/ZE035TMFj4XPsVUKuRDpibZISE+IagimgnHNh4YXkxyPwz+hSrSIhSDoknz3CK57Ve3MXGp7PzTidBk7bRhKYkjb/tENrPLGnw8rJnKZhNNk4hMdKzLOMFStwxX0/CFsGjTw8PN00MQZWhMSBed7Q0aCRHk6C9/EM27e0jql4miXDv7XbLYkKPF4bnqUv72koxs6ra5Ds909YQUK7FEnvQM3ooqijt8V8SXaSqC70tpM5EmtsTqEZF8DwA7n1y9mbr+jrj4d+JMy18Rez1QHf59PcGeorrRgZRD0E7w5+1WJ8n8x7UmUGOBiuuHApSJFC8r1yc9z5EjZd94P9AQ1I418O5PjF2hl2WAgUBR5HCBYVdZCgcJLAwOvmrNP0fiwcdAEZJlZFu+TDmxogIj7l+oA XoGAmbCO GVLXshJ8LLK0NxRgYHQx86uUrw7nag0j7ExyiJQ+0V+7oG2UmCFfIX1JTGBE+NhQm/kL+a0SEeLLx5L37isXXSbZhL9E/TxAMGRTP3eRJXqM7wegNc3nV7BZUde/Ipb0l/NciWAr1Hjthd1uQuC8BDiw/0Dk0pKqvK7O1jxorDA2i510UwvTPL7qEUO6TH2ieyDuTr0m2Z1PLhEEXHwlnv+e8GsVBrQ3g9JUAHh5u88Fh58wiO0vyQ3HzIAuyG7qNauW/5Mn29JeJ57t6O2TMDbRg2ganGiqPT4WNSDiaOmUXqk/MXZYQkW9fcjihqgByk3f0ElwBKAqDp1YfMojWNHY3SD5HIt+xiUvBWmagqFMk6jC49j8hEY4WLL6xGiHoxJZSRaG2WJVCVuaiWFz2UwwU4h1KaWeVcMoDB2Uo9zgz7azNAfFTJHVL7DdEnZ0nlYSzyi2zBncmFEnoVPiKWldAKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.01.23 15:03, Jason Gunthorpe wrote: > On Tue, Jan 31, 2023 at 02:57:20PM +0100, David Hildenbrand wrote: > >>> I'm excited by this series, thanks for making it. >>> >>> The pin accounting has been a long standing problem and cgroups will >>> really help! >> >> Indeed. I'm curious how GUP-fast, pinning the same page multiple times, and >> pinning subpages of larger folios are handled :) > > The same as today. The pinning is done based on the result from GUP, > and we charge every returned struct page. > > So duplicates are counted multiple times, folios are ignored. > > Removing duplicate charges would be costly, it would require storage > to keep track of how many times individual pages have been charged to > each cgroup (eg an xarray indexed by PFN of integers in each cgroup). > > It doesn't seem worth the cost, IMHO. > > We've made alot of investment now with iommufd to remove the most > annoying sources of duplicated pins so it is much less of a problem in > the qemu context at least. Wasn't there the discussion regarding using vfio+io_uring+rdma+$whatever on a VM and requiring multiple times the VM size as memlock limit? Would it be the same now, just that we need multiple times the pin limit? -- Thanks, David / dhildenb