From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14977C31E42 for ; Thu, 11 Jul 2019 16:52:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9DAC2084B for ; Thu, 11 Jul 2019 16:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9DAC2084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 67E018E00EF; Thu, 11 Jul 2019 12:52:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62D8A8E00DB; Thu, 11 Jul 2019 12:52:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F4C48E00EF; Thu, 11 Jul 2019 12:52:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by kanga.kvack.org (Postfix) with ESMTP id 2D9F38E00DB for ; Thu, 11 Jul 2019 12:52:29 -0400 (EDT) Received: by mail-qk1-f200.google.com with SMTP id c207so4405171qkb.11 for ; Thu, 11 Jul 2019 09:52:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5HH44TW5l4v0zcaldmJvyjHPb1AkgYBohJLpVn/gCPM=; b=YIoYSfj9eqfVXJ7C478tKXGil6XtT2fezkqlxrjPomYt0GPEIV926rshxGo4M+gfuk 9qNzBkM2+zNs/5wwcRJTmVN4gW/BPU6GgpPtcuXmE/U3PYFiKss9xXmUOJNJhSSZaGEL 9LCrE/j6nUc8bm7LDglk6AvnEbb7Qckn+qRJVNk7BEd4/DD3TJQxbnef3iWlu+ImLAud R/EXa/P4VEdJn3CsBxc3B6WCVZ3ve+R4J9H40sUrPpuoJ4LJoOx/tgloBIdQawjj0StI BX4SCXzOxDmrN8eTVr3Xze67zhVH4AD99ZTgTYtcSxZVBcRFsyM31gL0t3r107PAQgg5 PU8w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAUzTMBIFHQzj28SLPiuOmrLqrL91DIYMtVDi5risGQZ4Lg6KVEt ahxYFTV6FW0s4BPO6K+xcded+dyqy6i0jnrIfzXLHX9xAyeB8krtXQ3SHCi+ZG3FFy2/Ie/e06C U1fkS7N3zw1GAaN8w+uI9HB+UwpiunO+OqGUYR4kviMA8xb083sr/kjxweLSTt4l8TQ== X-Received: by 2002:a37:be41:: with SMTP id o62mr2647968qkf.356.1562863948960; Thu, 11 Jul 2019 09:52:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+U9bk+XHpoDD+M6X6gwXiZ6AarVT3Ab/xdk16cprr3DSFQCEpBlMn7A5RcUlcfV1NhPjU X-Received: by 2002:a37:be41:: with SMTP id o62mr2647941qkf.356.1562863948394; Thu, 11 Jul 2019 09:52:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562863948; cv=none; d=google.com; s=arc-20160816; b=xXYZqFB/ARhvKMmq4eR0yYZGZit2NkvVH879SQ6Y22ly903lm+uRSvQyo5g9yMZHNM L7mOv5SK7yXWxma/aSjaRNyxeMqGb63N4Ll+6i7eUHQN+zbsszFMrwc3wxpvejtXOnBZ A+yCHfvze2+QAPZtkO38qtviQ4v+2X5vqQOHo2rypS7PZzCiWGx/OmASyPKRl6ouk/vQ OGqEDAsA+E96orNkFYbu36/qTL7HCpaT1pcda46D8P4ZkKvoF9aEqP9bLrQ5LgwCJC7K Se07bRHKwIncpNQM6GhxkXHf29gKN+LhEf+MULQXqWoxcggvKxJcy05p4V73d+zUVkQf hZnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:to:subject; bh=5HH44TW5l4v0zcaldmJvyjHPb1AkgYBohJLpVn/gCPM=; b=idCp78u5scOfF9VUknSoWm9SV/8fO4/dqrEqnu8QmM9WM3LZV5BJRuJtriAadxOuxm r43PnPKeEv6JuRWkX4fxG7D1Dibj296soDWjS426kyngg0tCAUuxv3PHPf01/mf5ekh6 adSP+zAuVuipYPMgNzGdQe90NLHend6NyjfLjYEdxgbFxzi8WZJYme63TCHd7zsbjsMc vjF6ywi/LVpOL+7vR3BrNp7wfq65thMGSoCxAHyyJGtmpQ5gSJ65ziapglN0OBcQq3Vx 6n1c2eI1Uc6Uiw5XY1uP2hSfPzNQPdqxz3V2lBoiFJlyVMwl4ciiD9w58PTHe6LEvdEj 3Iog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id e33si3630806qtb.0.2019.07.11.09.52.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 09:52:28 -0700 (PDT) Received-SPF: pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 827A38666A; Thu, 11 Jul 2019 16:52:27 +0000 (UTC) Received: from [10.18.17.163] (dhcp-17-163.bos.redhat.com [10.18.17.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5D145D720; Thu, 11 Jul 2019 16:52:20 +0000 (UTC) Subject: Re: [RFC][Patch v11 1/2] mm: page_hinting: core infrastructure To: Dave Hansen , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, yang.zhang.wz@gmail.com, riel@surriel.com, david@redhat.com, mst@redhat.com, dodgen@google.com, konrad.wilk@oracle.com, dhildenb@redhat.com, aarcange@redhat.com, alexander.duyck@gmail.com, john.starks@microsoft.com, mhocko@suse.com References: <20190710195158.19640-1-nitesh@redhat.com> <20190710195158.19640-2-nitesh@redhat.com> <3f9a7e7b-c026-3530-e985-804fc7f1ec31@intel.com> <0b871cf1-e54f-f072-1eaf-511a03c2907f@redhat.com> <719ac813-01d7-7602-0951-6c90f1f7efc1@intel.com> From: Nitesh Narayan Lal Openpgp: preference=signencrypt Autocrypt: addr=nitesh@redhat.com; prefer-encrypt=mutual; keydata= mQINBFl4pQoBEADT/nXR2JOfsCjDgYmE2qonSGjkM1g8S6p9UWD+bf7YEAYYYzZsLtbilFTe z4nL4AV6VJmC7dBIlTi3Mj2eymD/2dkKP6UXlliWkq67feVg1KG+4UIp89lFW7v5Y8Muw3Fm uQbFvxyhN8n3tmhRe+ScWsndSBDxYOZgkbCSIfNPdZrHcnOLfA7xMJZeRCjqUpwhIjxQdFA7 n0s0KZ2cHIsemtBM8b2WXSQG9CjqAJHVkDhrBWKThDRF7k80oiJdEQlTEiVhaEDURXq+2XmG jpCnvRQDb28EJSsQlNEAzwzHMeplddfB0vCg9fRk/kOBMDBtGsTvNT9OYUZD+7jaf0gvBvBB lbKmmMMX7uJB+ejY7bnw6ePNrVPErWyfHzR5WYrIFUtgoR3LigKnw5apzc7UIV9G8uiIcZEn C+QJCK43jgnkPcSmwVPztcrkbC84g1K5v2Dxh9amXKLBA1/i+CAY8JWMTepsFohIFMXNLj+B RJoOcR4HGYXZ6CAJa3Glu3mCmYqHTOKwezJTAvmsCLd3W7WxOGF8BbBjVaPjcZfavOvkin0u DaFvhAmrzN6lL0msY17JCZo046z8oAqkyvEflFbC0S1R/POzehKrzQ1RFRD3/YzzlhmIowkM BpTqNBeHEzQAlIhQuyu1ugmQtfsYYq6FPmWMRfFPes/4JUU/PQARAQABtCVOaXRlc2ggTmFy YXlhbiBMYWwgPG5pbGFsQHJlZGhhdC5jb20+iQI9BBMBCAAnBQJZeKUKAhsjBQkJZgGABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEKOGQNwGMqM56lEP/A2KMs/pu0URcVk/kqVwcBhU SnvB8DP3lDWDnmVrAkFEOnPX7GTbactQ41wF/xwjwmEmTzLrMRZpkqz2y9mV0hWHjqoXbOCS 6RwK3ri5e2ThIPoGxFLt6TrMHgCRwm8YuOSJ97o+uohCTN8pmQ86KMUrDNwMqRkeTRW9wWIQ EdDqW44VwelnyPwcmWHBNNb1Kd8j3xKlHtnS45vc6WuoKxYRBTQOwI/5uFpDZtZ1a5kq9Ak/ MOPDDZpd84rqd+IvgMw5z4a5QlkvOTpScD21G3gjmtTEtyfahltyDK/5i8IaQC3YiXJCrqxE r7/4JMZeOYiKpE9iZMtS90t4wBgbVTqAGH1nE/ifZVAUcCtycD0f3egX9CHe45Ad4fsF3edQ ESa5tZAogiA4Hc/yQpnnf43a3aQ67XPOJXxS0Qptzu4vfF9h7kTKYWSrVesOU3QKYbjEAf95 NewF9FhAlYqYrwIwnuAZ8TdXVDYt7Z3z506//sf6zoRwYIDA8RDqFGRuPMXUsoUnf/KKPrtR ceLcSUP/JCNiYbf1/QtW8S6Ca/4qJFXQHp0knqJPGmwuFHsarSdpvZQ9qpxD3FnuPyo64S2N Dfq8TAeifNp2pAmPY2PAHQ3nOmKgMG8Gn5QiORvMUGzSz8Lo31LW58NdBKbh6bci5+t/HE0H pnyVf5xhNC/FuQINBFl4pQoBEACr+MgxWHUP76oNNYjRiNDhaIVtnPRqxiZ9v4H5FPxJy9UD Bqr54rifr1E+K+yYNPt/Po43vVL2cAyfyI/LVLlhiY4yH6T1n+Di/hSkkviCaf13gczuvgz4 KVYLwojU8+naJUsiCJw01MjO3pg9GQ+47HgsnRjCdNmmHiUQqksMIfd8k3reO9SUNlEmDDNB XuSzkHjE5y/R/6p8uXaVpiKPfHoULjNRWaFc3d2JGmxJpBdpYnajoz61m7XJlgwl/B5Ql/6B dHGaX3VHxOZsfRfugwYF9CkrPbyO5PK7yJ5vaiWre7aQ9bmCtXAomvF1q3/qRwZp77k6i9R3 tWfXjZDOQokw0u6d6DYJ0Vkfcwheg2i/Mf/epQl7Pf846G3PgSnyVK6cRwerBl5a68w7xqVU 4KgAh0DePjtDcbcXsKRT9D63cfyfrNE+ea4i0SVik6+N4nAj1HbzWHTk2KIxTsJXypibOKFX 2VykltxutR1sUfZBYMkfU4PogE7NjVEU7KtuCOSAkYzIWrZNEQrxYkxHLJsWruhSYNRsqVBy KvY6JAsq/i5yhVd5JKKU8wIOgSwC9P6mXYRgwPyfg15GZpnw+Fpey4bCDkT5fMOaCcS+vSU1 UaFmC4Ogzpe2BW2DOaPU5Ik99zUFNn6cRmOOXArrryjFlLT5oSOe4IposgWzdwARAQABiQIl BBgBCAAPBQJZeKUKAhsMBQkJZgGAAAoJEKOGQNwGMqM5ELoP/jj9d9gF1Al4+9bngUlYohYu 0sxyZo9IZ7Yb7cHuJzOMqfgoP4tydP4QCuyd9Q2OHHL5AL4VFNb8SvqAxxYSPuDJTI3JZwI7 d8JTPKwpulMSUaJE8ZH9n8A/+sdC3CAD4QafVBcCcbFe1jifHmQRdDrvHV9Es14QVAOTZhnJ vweENyHEIxkpLsyUUDuVypIo6y/Cws+EBCWt27BJi9GH/EOTB0wb+2ghCs/i3h8a+bi+bS7L FCCm/AxIqxRurh2UySn0P/2+2eZvneJ1/uTgfxnjeSlwQJ1BWzMAdAHQO1/lnbyZgEZEtUZJ x9d9ASekTtJjBMKJXAw7GbB2dAA/QmbA+Q+Xuamzm/1imigz6L6sOt2n/X/SSc33w8RJUyor SvAIoG/zU2Y76pKTgbpQqMDmkmNYFMLcAukpvC4ki3Sf086TdMgkjqtnpTkEElMSFJC8npXv 3QnGGOIfFug/qs8z03DLPBz9VYS26jiiN7QIJVpeeEdN/LKnaz5LO+h5kNAyj44qdF2T2AiF HxnZnxO5JNP5uISQH3FjxxGxJkdJ8jKzZV7aT37sC+Rp0o3KNc+GXTR+GSVq87Xfuhx0LRST NK9ZhT0+qkiN7npFLtNtbzwqaqceq3XhafmCiw8xrtzCnlB/C4SiBr/93Ip4kihXJ0EuHSLn VujM7c/b4pps Organization: Red Hat Inc, Message-ID: <2eab8e20-a87d-a5be-5d55-cdaa0b377b1d@redhat.com> Date: Thu, 11 Jul 2019 12:52:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <719ac813-01d7-7602-0951-6c90f1f7efc1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 11 Jul 2019 16:52:27 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/11/19 12:45 PM, Dave Hansen wrote: > On 7/11/19 9:36 AM, Nitesh Narayan Lal wrote: >>>>>> +struct zone_free_area { >>>>>> + unsigned long *bitmap; >>>>>> + unsigned long base_pfn; >>>>>> + unsigned long end_pfn; >>>>>> + atomic_t free_pages; >>>>>> + unsigned long nbits; >>>>>> +} free_area[MAX_NR_ZONES]; >>>>> Why do we need an extra data structure. What's wrong with putting >>>>> per-zone data in ... 'struct zone'? >>>> Will it be acceptable to add fields in struct zone, when they will o= nly >>>> be used by page hinting? >>> Wait a sec... MAX_NR_ZONES the number of zone types not the maximum >>> number of *zones* in the system. >>> >>> Did you test this on a NUMA system? >> Yes, I tested it with a guest having 2 and 3 NUMA nodes. > How can this *possibly* have worked? > > Won't each same-typed zone just use the same free_area[] entry since > zone_idx(zone1)=3D=3Dzone_idx(zone2) if zone1 and zone2 are (for exampl= e) > both ZONE_NORMAL? Yes. However, the base_pfn and end_pfn will be updated with the zone1's base and zone2s end_pfn value from page_hinting_enable(). Isn't? --=20 Thanks Nitesh