From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C933C52D7C for ; Wed, 21 Aug 2024 22:11:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 713B56B019E; Wed, 21 Aug 2024 18:11:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C3E56B01A0; Wed, 21 Aug 2024 18:11:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515AB6B01A1; Wed, 21 Aug 2024 18:11:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3267D6B019E for ; Wed, 21 Aug 2024 18:11:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C48541410B2 for ; Wed, 21 Aug 2024 22:11:06 +0000 (UTC) X-FDA: 82477648932.22.341D2F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 65F24C0022 for ; Wed, 21 Aug 2024 22:11:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UhxW09iB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724278205; a=rsa-sha256; cv=none; b=bAjQqyhZZxLTK+B+aRdVSzyBB8mvvocDOCblYHHn+aluIUiXdtkzR+uzKeyySUDfUtxjQM m3xGZr79a/ajaWVzJepaLqPQqEwYK2CtcgHC9wz7llBsej/z5SNHT0WxjMAyaAR+ZRW1vi VnYH1azZ3WkJRM+Gawf4SXJsv7HyqhA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UhxW09iB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724278205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4C6IPY41QjQyfxamoEtFU55HAv1LSBDkPc6d1+SI6CU=; b=MPq50P0Eeqw8kY+8OXrDqPSI7CLGnNjhBFR8LOFLODcw0DBnTofET7kHgJHyaOiS0AaAMi KMjYhHRH34QnOPMwpwqW6s8VlJerKB2zowloTjHmsG2YQF05xbtqX7TOMKemWAxskZaKSc i/kp3/L9zvpkjfvXnlm09iu0MY/ItTI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724278263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4C6IPY41QjQyfxamoEtFU55HAv1LSBDkPc6d1+SI6CU=; b=UhxW09iBTcWmcOtAEO5C38HrMMxWIaGqeutnNaAPW+C4LQ0DfNX/zacnqITcwrf1EuKSTZ ZiY7l90UaJOG0DpuKs2QTyhAc5WivLVPLMkcrXrl6XD71PoZ5ew9Etz1+h5mgBqIFdTDl+ U7frytDiK+HVsdoiAJhdzWe4oLOrCbA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-QllwZcIKNuidLqscreW2BA-1; Wed, 21 Aug 2024 18:11:02 -0400 X-MC-Unique: QllwZcIKNuidLqscreW2BA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42809eb7b99so593525e9.0 for ; Wed, 21 Aug 2024 15:11:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724278261; x=1724883061; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4C6IPY41QjQyfxamoEtFU55HAv1LSBDkPc6d1+SI6CU=; b=HOZnVjlRhkU952PQZwcfAPqLwNilNctqNieakyEjZepwRtWyOC1nHTs6E18u+OXVAa MjMmgvXHmtzu2yu8rGfUKl2P+v0BfYg/CwyHUR8ZsMnXTSf3bn/0EPH6xMY6QU4eCNMk 0pz0vHJUdJ2uKGHLZauPxKpiLx2U6EDzZk/b3XaXPGxsSTw/ixZTn3erBNv0nxayVOSD wCSeOo9Kx/SmbzxVE2ZsbkqFU9TrJwes3VnvPcJAPYPxVVolcK/QLQbxf9Nt/RpPKb0t u+DA3eD1QEyD8WS5FYZfUIelMoqYE+719UYkJxjDlZEDOPnpJ9DzHvHOPTuz8GX89sXP ODmw== X-Forwarded-Encrypted: i=1; AJvYcCUFoKMQRLLtMRe7xNRbGCEdfqX9YzbMChq7MpV/yhNbCgaJ7xkkYqcYxUvfvXxyRPxViVTndHFEoA==@kvack.org X-Gm-Message-State: AOJu0YwEJ7TmFGojsBGzRcvJMAIj86puLSIk2icx5q4d8RwK19gcKg5s ljlVKpEGSEJtgUTSE8gLv3iDBVgYeOGneypMJr14JHoYy6OpPRuzK9jq1laod1fnb9/+XNIcNTw 0zGQqKF41GxMylmiMlT3eI1SAdnrgzSXM0gySFlm34Hru9M1X X-Received: by 2002:a05:600c:3b13:b0:426:526f:4a1f with SMTP id 5b1f17b1804b1-42ac38c7c13mr5129575e9.16.1724278261256; Wed, 21 Aug 2024 15:11:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3qs5flbuwzfZzhE697TlriPivymU4U833EaKMKvrJ+X2rrFmyp24vAau8qXdUtGIcvMprJw== X-Received: by 2002:a05:600c:3b13:b0:426:526f:4a1f with SMTP id 5b1f17b1804b1-42ac38c7c13mr5129395e9.16.1724278260361; Wed, 21 Aug 2024 15:11:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730815c0f0sm74928f8f.51.2024.08.21.15.10.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 15:10:59 -0700 (PDT) Message-ID: <2ed6c403-b7a4-4e03-92f3-7debd05d965a@redhat.com> Date: Thu, 22 Aug 2024 00:10:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: collect the number of anon large folios on split_deferred list To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, ziy@nvidia.com, yuanshuai@oppo.com, Usama Arif References: <20240811224940.39876-1-21cnbao@gmail.com> <20240811224940.39876-3-21cnbao@gmail.com> <6c01b794-7c51-4d90-a215-210ac21401d2@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 65F24C0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k1h75ipyoesjkrm6ni1bu6aunrwix39r X-HE-Tag: 1724278264-92297 X-HE-Meta: U2FsdGVkX19W853uWZ+Ixl5SH309iFYlWP2OQfdPE4K/OGWLejZnoPv0Xz57J8NoGQoCzMbvRUXx5J2Jv5NwDuILvCELEouH2fuvp4gh2wRloBwNBpzKRepICSdthgZhdDuzQEFisTWEyPKIqfVo6Wx0beKjojXvh66u0ngJcOpRfR/tduHhWOu0lTuqzX8Wf+vB7dBC/1ouMpp0Gt2iAhZ26UyAmqmDTUAdvthX1zz3B8reMBJ4wBFW6LGGbAA7qit20qx9l97QQMp/fcQFTKy+KrnX5UXbopJmB/ZgH219uWCLSJDmKq7UNd7H4vxIJmRbD5iB9abrIhsnSdFYiRxBdhFYlQJe5nnyRxi260VdIlCu5eE3gxWrYBFNZCpZgf8XRg3uKvFjUdD4qv3sr2AXggF41dKPDFvL3lbKgedmBumWEq8pac+GH2/k6Y30dMTrpzYBhBDJlJdmwY0rKdhLgwWULPRiXyK549jd0dlIbIbjVTIPGLdkzjxfzXUn6NaF7XlSzbPhVSA4YWmsofVH/mNWQi2zxy+Or2weUEguIdYV8zLpTIMVUlElS3EsyvpcRaKyh7q/94ygDs7fHnqm/P3pl/GVHi4G9cvuAr5gIkpKFuav96SbDq77S1IbN85TRInN8fBvOddN5mPTHJ6H+0MPC6E/2KFYPLoSinjOEidYwcpocAtWiexEOlFKjgSuUtr4gtDaPlH2+5z+jK9n/XzhmHwMFwPdvY25/cu9VeGOG2dnY+NflIlxU4Ld8Fdh1xBJ1+AnMB40cQGvUPUOJbGPEsmJupyc3UWiRNlgyfLZAY7Zs2eFyhfU7TvaRWdjeEfC28e9ot4dxSljaYCztXwZHbIj8UQyxUs/u8ia6MtQyJBkD3TkIj6xtR54f+qvSeBo9y+IP3TWbdx7LIdNtTU4bzO1iD4mgBbq9OJJt4ItSwqbiqXjW9ECpzODwG4PXoeDhspd7hD6xfq psdYdNdA yfgWac0cw0ALLlimV2zn6jR8OVbgMkQA3fJewdab4+W01vsliEDDRTT2ryCnbpk861WTGu+u4aE3i+GgecdEIKEFdTaCdC/0WI5QVtxR6gB1BhzVa94tosjdnL1MbBT/7F3Iuu1uMP6oCBozK/Tf3u/FLnl7f810ea/Dabk4yG8pYV/0Pr7Yus/8LWySwlEqgpUjzuxaSKmSgyaOe8TMcL41jWw9E4132e1JncGxwGjx1pQiW9dw0Rh4kkSAHpKo9y+diKaZOjKBRTuCdNd5yao459r6kr9CLHa+vosTMka4tGOiNcxenqfNuDPsPzsVbwrndyn/DrM6eX66mmdbx3xjRIk1JdhEn/JDVPVHEolkW3QJZ1dzHa73xKpN7ENbo1UVmgciTHqmDERoLTnEUsoWgszKPZ6PK1duHbsTB2E1ii49vKaUP1+JrpxWpUGn8PoivQRXb5IhZx2Dt14M8BHcDh5k+dfpGAFlJnjtRiTN69XNR92H7NMo4OOMUxrpphvffvM9/9BoZ6vVNjfymFU6dFeRS9COpbCq6bysFSXBJKXoc3ncZd/BKSnJW5kw3WZ7OKP0YVJx3dlui9Y3egmVrptZdVsx/yi0wBkeYKVNQ8SbrCHdYb17jXAQYWBIDMKy+iLkvTFUP4FUqJd7p1ny7YFEy9Xjw+w6Rv3WgDuqZhuc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.08.24 00:01, Barry Song wrote: > On Thu, Aug 22, 2024 at 5:39 AM David Hildenbrand wrote: >> >> On 12.08.24 00:49, Barry Song wrote: >>> From: Barry Song >>> >>> When an mTHP is added to the deferred_list, its partial pages >>> are unused, leading to wasted memory and potentially increasing >>> memory reclamation pressure. >>> >>> Detailing the specifics of how unmapping occurs is quite difficult >>> and not that useful, so we adopt a simple approach: each time an >>> mTHP enters the deferred_list, we increment the count by 1; whenever >>> it leaves for any reason, we decrement the count by 1. >>> >>> Signed-off-by: Barry Song >>> --- >>> Documentation/admin-guide/mm/transhuge.rst | 5 +++++ >>> include/linux/huge_mm.h | 1 + >>> mm/huge_memory.c | 6 ++++++ >>> 3 files changed, 12 insertions(+) >>> >>> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst >>> index 9fdfb46e4560..7072469de8a8 100644 >>> --- a/Documentation/admin-guide/mm/transhuge.rst >>> +++ b/Documentation/admin-guide/mm/transhuge.rst >>> @@ -532,6 +532,11 @@ nr_anon >>> These huge pages could be entirely mapped or have partially >>> unmapped/unused subpages. >>> >>> +nr_split_deferred >>> + the number of anon huge pages which have been partially unmapped >>> + and put onto split queue. Those unmapped subpages are also unused >>> + and temporarily wasting memory. >> >> The name suggests something else ... like a counter of how many have >> been deferred split :) >> >> Would "nr_anon_partially_mapped" "nr_anon_split_pending" (or something >> less mouthful) be clearer? >> >> (likely "anon" really should be part of the name in any case) >> >> The name we chose (and the implied semantics) will likely have >> implications on the handling of Usamas series. >> > > Hi David, > > Your point is quite similar to my V1, though not exactly the same. I aimed to > make the name more meaningful for users. > https://lore.kernel.org/all/20240808010457.228753-3-21cnbao@gmail.com/ > > Ryan felt that the name should be consistent with the existing split_deferred. > https://lore.kernel.org/all/36e8f1be-868d-4bce-8f32-e2d96b8b7af3@arm.com/#t Right, it's an increasing counter of how often we added something to the deferred split queue. It's more like a low-level primitive, although currently only used for one reason (anon + partial mapping). > > It seems that the existing split_deferred may now be less optimal with > Usama's series, as entirely_mapped folios might also be on the list. Yes. > > Ryan is out right now, but I suppose he will be convinced that > "nr_anon_partially_mapped" is probably a better name once > he returns and reviews Usama's series. :-) Maybe ;) At least it's clear from the name what we are talking about. -- Cheers, David / dhildenb