From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC437EB64D7 for ; Fri, 23 Jun 2023 08:18:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EF6E8D0002; Fri, 23 Jun 2023 04:18:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 279208D0001; Fri, 23 Jun 2023 04:18:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F2C98D0002; Fri, 23 Jun 2023 04:18:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC8AA8D0001 for ; Fri, 23 Jun 2023 04:18:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE74F40D5B for ; Fri, 23 Jun 2023 08:18:36 +0000 (UTC) X-FDA: 80933311032.30.D4944CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 7CF82C0005 for ; Fri, 23 Jun 2023 08:18:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ao9NPA2p; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687508314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=538N1r15WdNADQ+cR7jmSkw/+/p0HMNuv1u+y+d1dIU=; b=tmVorQpguDExt/Q9LFGWfmAX+edVCB7SB0fenpjzZiWwN7JlupJespaS/L37phuc1Q8FrF NNtL3BSf6Xcza9bAxJgwxC37mcJIteFOlBq2VYeMMUPZ02qnHWoyNoF1qE2M7qY4av5oms D/CJRgzBJP7pnbKFKcPaCfG0D7IMxgI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ao9NPA2p; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687508314; a=rsa-sha256; cv=none; b=uewD1DCd4X/LL6qc+b4iG5WghrTcN6ep36esDT7dxun6uArFkfcCBdihan5QUcPlsYw8nH lEPyO3A3mo1RZoZTa9VFnexW6esz235QTjjl8DIRiBzpT3Biga8CNQegRFcpETSD5HI3Gt /7KkIcbVZGeBxEpG1aSqReGC7N+6pGs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687508313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=538N1r15WdNADQ+cR7jmSkw/+/p0HMNuv1u+y+d1dIU=; b=ao9NPA2pO1YD0BpH5sTwPVVU8n9BmwZ0zZPtImlTn5BAS36n1M//J9HCDWBfdkZ/bXMUdP yn6hbuntPDkWtELOYqBNXxLW77Da8fCDYC7fdfUeKV8QnsriYyiJ2+1CKsiX8cbsULuDcz Y1Wf43TstQb2MLPYQSmEasoKb8wau9Q= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-sikmvpeyOx6XinGTgETs6A-1; Fri, 23 Jun 2023 04:18:29 -0400 X-MC-Unique: sikmvpeyOx6XinGTgETs6A-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-62fea7a5de9so943436d6.0 for ; Fri, 23 Jun 2023 01:18:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687508308; x=1690100308; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PkaQxx+Y1hANa87C64UPOn1w6sw0j2xvZ0R3DPOEvLI=; b=KhgmeFWbkX5OoU4WVevwVkH0GoISTHXmyRjrHS0SeBviyUUyFUk0LPD/f/ry7b2KmJ KYox2XyIDyIHcd0Sao+p2g2xoqlLhFGb1lrtjYITK8q2jqYxVOcfbaeMhIvcmhxMOSna +UqI9zNXnCgld4kEBt2rsbXNBj7KhYur06T6C0pYOnVWYNgUFwy1IF8fyT2Grv6Dh5/B B3K4QMHqki31TDzGH0pxLnrNPkfjEzmOSTxYgkskcFXqOKvwk32nVqxAK+/EFaCb+VfY DbdzykZ8oXNeE4AULwyroSFv8FKmh1T1n8zTayMLfKAHP8ecpbaNbIZ7kmRTA1yEkuv2 UlFw== X-Gm-Message-State: AC+VfDw5UM/Zm1OFiydUxVjWd8sIhRyY5k16Xab/FO/Ry8AqNrmPvzTm DHWKXbGQ6j+VFi3JsNyw8mPr2g1BAz/AwbVf/zlqDFPU/s9SZHGDnWqUtyiD78lypOMG5tmA1+h GLvP3TKoCCuc= X-Received: by 2002:a05:6214:2426:b0:62f:e386:1e45 with SMTP id gy6-20020a056214242600b0062fe3861e45mr23780101qvb.1.1687508308659; Fri, 23 Jun 2023 01:18:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4FUnG3bG8uHAhc8j3r/ENi0CHUWTQvEeqCtObZFm1IgXCwU67fCwyZEOd9Nuyxm4AXcz667w== X-Received: by 2002:a05:6214:2426:b0:62f:e386:1e45 with SMTP id gy6-20020a056214242600b0062fe3861e45mr23780085qvb.1.1687508308351; Fri, 23 Jun 2023 01:18:28 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-231-243.dyn.eolo.it. [146.241.231.243]) by smtp.gmail.com with ESMTPSA id m1-20020a0ce6e1000000b006238b37fb05sm4759922qvn.119.2023.06.23.01.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 01:18:28 -0700 (PDT) Message-ID: <2ee000f803bd1a099aa8fb02ef79c7b25e5f5b08.camel@redhat.com> Subject: Re: [PATCH net-next v3 02/18] net: Display info about MSG_SPLICE_PAGES memory handling in proc From: Paolo Abeni To: David Howells , netdev@vger.kernel.org Cc: Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Menglong Dong Date: Fri, 23 Jun 2023 10:18:24 +0200 In-Reply-To: <20230620145338.1300897-3-dhowells@redhat.com> References: <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-3-dhowells@redhat.com> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7CF82C0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1kiorjco7xqt3d73b7ncjx6kxp9to9op X-HE-Tag: 1687508314-254124 X-HE-Meta: U2FsdGVkX1+ZmeahzcEAtCPifRVOzizLv1vTA9Dgmob/SwsRZcl5LgNFSlGibzyhyfflpB3B6fagxVTsUKg1MRU4DKYWpg0Gy8sM2kYxydmCT2p5O/2+M3QEdg8YXUS/oGWkOiylgTBLjOq6OYLGEKrkYioGPK1Ru1Y48kGfPIj3sOAiY62W1VSK7pAq49wI5Z2EFpc0uBfc4cu+mTaOna18IuN3lNTjL/Je33fv3oHy5dcHDp/BlyLGaXZFeqi9yDNs0tKWF0FRuiPsG00eOVdGPUmwtJnKaN4RykOJl0/cPcVEurBx1ObllNTOk+ulf2CMIahzMhLZNTssLY9yoeimkDUEVbJx5k0wvxXExvOcZttQ8r58aueWyGylHHlyPMZushpjodE6j3MthdWVV2YKsSUt3w8o4JWpSCLahFcdXow4G9mqnIMFKQQF1G5SQFdbERXzckdvFh6gVc6zz4Z27z4DB2JL8CwI/P2geQpyvppMbI1UFxQ2+Dc8C5BbemIhAcDSIFQNYBQoUEuMKENYaqybfsGLbqUmUijqHcZqU/LIM5nxKUYxyd3Z4cAmhigxXN+zNE/5cS4nFtaK47WieXJsgKTNGxcf4wS7ZIxlSl23qUicP6sFF8QSIv7sfd9cC4jFIwrUCABwmZwb73og5cRhrdwRnjKclCgvY1qvoypytDq/EazzbE/9xmUXFR5nuCR/mHKwH969GgorhlSbExDagcBUV2mGoYL3xq0vhpcsgwfxKuKthoM6i+BY3UH+5dAJEiqKgrVByn/ceTaNSS19dqaUJUJN1aUKF+rBxC0fXXGzh+4IQPfXd/a58QK0U6TsjHV4NHvn1rUXwQHA1Zl7DA4o2g7YeCLeMyvUlKqJzPii1YJZ3dLz+MVRjLbKqLZi2vdQ9aKLoZEVWde6YMBLNzqFnT6mGKtwa1xIrsUBBo2Ukp/iiok3JQBLTxvCf/nJ7jfoKvHgLHs iXLdtYAm adabjWgD9pCZ501cDIRY3gPPKKs78PtuOcvjnc8kfIeYc+2ctCNDiZw69acx88Db9lCVS/73dO1D2WrijXtOBm+vICS7p1icHySrg9TSyjJrDQ3clPILLiOtuxC4T+VWTOXJbBEWXhEPHoF8yqJutzuSah6ulvPCCoKKf1ZQ/vaM2JY9mj82pI1fPU7mSFQhVg8DTgJMz3FOMsJIEQGW9+3kkDy82BlEphJjiFHFHu1AbdWtKw87nRLk9MAztc/ON0bRxWyVybfc10rKBagCWMCdSxrkNpW/Aeyc4W4rma/y3k8i9T6aqB+/rK/MtFp7M/vohON4FTTFXQl1lXAx1Az+FskX7qGPewRGccnMVdXw658sQxWWPw7QIjpml2lxmMm8/POoPAdl/xa1ntmxXZV+cbG4l3xd1Ysc9De3LfziCVoKLL9OEvH4TZBvpzqM+ky7yszFUIJtcqplNsAEgnLMyi1OnTbl1367quz13OKKJlNF46OVpyivmT8d+2yH4OfMnrvI0s8BBTApEOvO8dDW61YfxvA9znwpJGR0+8IRtpZEHz1Q7kCSisuc5+Mo+dOwKZyl8PK0eQMPpOANDoR9B1reai218Q7QZZpk8S8bU2L33qCKYOebl0CAb//G+a6JJo7l1q16swD4rJ3viBwWaETEBixed4Da43IIGA0sNfLqHb5PtgKh491k9g+T27wmfVvBUkmfDX8CtbOLCgU3Bc6k/yCtj8kjrpKeRcEEH7iRkpELvrQI82qw13iKa0nXQzhPXbJ5YHOHhjJKT7ea0c6qOYexnjvrf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2023-06-20 at 15:53 +0100, David Howells wrote: > Display information about the memory handling MSG_SPLICE_PAGES does to co= py > slabbed data into page fragments. >=20 > For each CPU that has a cached folio, it displays the folio pfn, the offs= et > pointer within the folio and the size of the folio. >=20 > It also displays the number of pages refurbished and the number of pages > replaced. >=20 > Signed-off-by: David Howells > cc: Alexander Duyck > cc: Eric Dumazet > cc: "David S. Miller" > cc: David Ahern > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Jens Axboe > cc: Matthew Wilcox > cc: Menglong Dong > cc: netdev@vger.kernel.org > --- > net/core/skbuff.c | 42 +++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 39 insertions(+), 3 deletions(-) >=20 > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index d962c93a429d..36605510a76d 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -83,6 +83,7 @@ > #include > #include > #include > +#include > =20 > #include "dev.h" > #include "sock_destructor.h" > @@ -6758,6 +6759,7 @@ nodefer:=09__kfree_skb(skb); > struct skb_splice_frag_cache { > =09struct folio=09*folio; > =09void=09=09*virt; > +=09unsigned int=09fsize; > =09unsigned int=09offset; > =09/* we maintain a pagecount bias, so that we dont dirty cache line > =09 * containing page->_refcount every time we allocate a fragment. > @@ -6767,6 +6769,26 @@ struct skb_splice_frag_cache { > }; > =20 > static DEFINE_PER_CPU(struct skb_splice_frag_cache, skb_splice_frag_cach= e); > +static atomic_t skb_splice_frag_replaced, skb_splice_frag_refurbished; (in case we don't agree to restrict this series to just remove MSG_SENDPAGE_NOTLAST) Have you considered percpu counters instead of the above atomics? I think the increments are in not so unlikely code-paths, and the contention there could possibly hurt performances. Thanks, Paolo