From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA72CC43460 for ; Thu, 8 Apr 2021 16:44:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43C8A60FE6 for ; Thu, 8 Apr 2021 16:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43C8A60FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D1F996B0085; Thu, 8 Apr 2021 12:44:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA8A96B0087; Thu, 8 Apr 2021 12:44:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B71E16B0088; Thu, 8 Apr 2021 12:44:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 967066B0085 for ; Thu, 8 Apr 2021 12:44:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 53C428248047 for ; Thu, 8 Apr 2021 16:44:38 +0000 (UTC) X-FDA: 78009773436.20.5C087AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 9F0CE80192F1 for ; Thu, 8 Apr 2021 16:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617900276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfhnCQAyCfEthQPScFLk5+XhVK1UjdBG138qICZvuow=; b=ahwqdaQ/TlcPPR1c+lVWLLH3XP/irC2raLNwDJnl8Itpener71pWA7JAvpyKi47szZ7W6j haQjtfXfQj5gOGYA9xCpl6z6H759aQXwGQW9avcPZaxNCVMuUiBFdQ+FMlPCc7oDcjywzv SiARmRieQO8P9rQXypYzKggHKEBR6gs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-x1HZ9uJoOgSGPofB8dKw8A-1; Thu, 08 Apr 2021 12:44:34 -0400 X-MC-Unique: x1HZ9uJoOgSGPofB8dKw8A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA2FB801814; Thu, 8 Apr 2021 16:44:30 +0000 (UTC) Received: from [10.36.113.26] (ovpn-113-26.ams2.redhat.com [10.36.113.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63A0A60636; Thu, 8 Apr 2021 16:44:24 +0000 (UTC) Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Linus Walleij Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> Date: Thu, 8 Apr 2021 18:44:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Stat-Signature: b6i5xt7ptuh5fmkxm8kz3gxojopj8ex3 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9F0CE80192F1 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617900276-727793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.04.21 14:49, Linus Walleij wrote: > On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > >>> This is something you could do using a hidden helper symbol like >>> >>> config DRMA_ASPEED_GFX >>> bool "Aspeed display driver" >>> select DRM_WANT_CMA >>> >>> config DRM_WANT_CMA >>> bool >>> help >>> Select this from any driver that benefits from CMA being enabled >>> >>> config DMA_CMA >>> bool "Use CMA helpers for DRM" >>> default DRM_WANT_CMA >>> >>> Arnd >>> >> >> That's precisely what I had first, with an additional "WANT_CMA" -- but >> looking at the number of such existing options (I was able to spot 1 !) > > If you do this it probably makes sense to fix a few other drivers > Kconfig in the process. It's not just a problem with your driver. > "my" drivers: > :) I actually wanted to convert them to "depends on DMA_CMA" but ran into recursive dependencies ... > drivers/gpu/drm/mcde/Kconfig > drivers/gpu/drm/pl111/Kconfig > drivers/gpu/drm/tve200/Kconfig I was assuming these are "real" dependencies. Will it also work without DMA_CMA? > > certainly needs this as well, and pretty much anything that is > selecting DRM_KMS_CMA_HELPER or > DRM_GEM_CMA_HELPER "wants" DMA_CMA. "wants" as in "desires to use but can life without" or "wants" as in "really needs it". ? -- Thanks, David / dhildenb