From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Paul Menage <menage@google.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH] mm/cgroup.c add error check
Date: Wed, 7 May 2008 05:19:45 +0900 [thread overview]
Message-ID: <2f11576a0805061319w581f69d4ye593416db6a9e80a@mail.gmail.com> (raw)
In-Reply-To: <4820A431.3000600@firstfloor.org>
> > but if GFP_KERNEL is used, We still need error check, IMHO.
>
> Yes, but no retry (or if you're sure you cannot fail use __GFP_NOFAIL
> too, but that is nasty because it has some risk of deadlock under severe
> oom conditions)
in general coding style, you are right.
but not down-to-earth idea in that case.
call_usermodehelper() is just wrapper of fork-exec.
I don't hope change largely exec() code patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-06 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 11:02 [PATCH] mm/cgroup.c add error check KOSAKI Motohiro
2008-05-06 12:43 ` Andi Kleen
2008-05-06 13:02 ` KOSAKI Motohiro
2008-05-06 18:32 ` Andi Kleen
2008-05-06 20:19 ` KOSAKI Motohiro [this message]
2008-05-07 5:08 ` Paul Menage
2008-05-07 7:45 ` KAMEZAWA Hiroyuki
2008-05-07 7:43 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0805061319w581f69d4ye593416db6a9e80a@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).