From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: apw@shadowen.org
Cc: linux-mm@kvack.org, Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] slub: record page flag overlays explicitly
Date: Wed, 28 May 2008 01:06:55 +0900 [thread overview]
Message-ID: <2f11576a0805270906x35a1f15eu7fe7414bbfe5c4b4@mail.gmail.com> (raw)
In-Reply-To: <20080527145250.GA3407@shadowen.org>
>> > - if (SlabDebug(page))
>> > - printk(KERN_ERR "SLUB %s: SlabDebug set on "
>> > + if (PageSlubDebug(page))
>> > + printk(KERN_ERR "SLUB %s: SlubDebug set on "
>> > "slab 0x%p\n", s->name, page);
>> > }
>> > }
>>
>> Why if(SLABDEBUG) check is unnecessary?
>
> They were unconditional before as well. SlabDebug would always return
> 0 before the patch. The point being, to my reading, that if you asked
> for debug on the slab and debug was not compiled in you would still get
> told that it was not set; which it cannot without the support.
Thank you explain!
Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-27 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 16:33 [PATCH 0/3] explicitly document overloaded page flags V2 Andy Whitcroft
2008-05-23 16:33 ` [PATCH 1/3] page-flags: record page flag overlays explicitly Andy Whitcroft
2008-05-26 4:37 ` KOSAKI Motohiro
2008-05-23 16:33 ` [PATCH 2/3] slub: " Andy Whitcroft
2008-05-26 4:40 ` KOSAKI Motohiro
2008-05-27 14:53 ` apw
2008-05-27 16:06 ` KOSAKI Motohiro [this message]
2008-05-23 16:33 ` [PATCH 3/3] slob: " Andy Whitcroft
2008-05-26 4:41 ` KOSAKI Motohiro
2008-05-23 17:08 ` [PATCH 0/3] explicitly document overloaded page flags V2 Christoph Lameter
2008-05-26 1:23 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2008-05-15 17:19 [PATCH 0/3] explicitly document overloaded page flags Andy Whitcroft
2008-05-15 17:19 ` [PATCH 2/3] slub: record page flag overlays explicitly Andy Whitcroft
2008-05-15 17:29 ` Christoph Lameter
2008-05-16 0:21 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0805270906x35a1f15eu7fe7414bbfe5c4b4@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=jeremy@goop.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).