Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu()

KOSAKI Motohiro
2008-10-24T05:51:34Z

> On Fri, Oct 24, 2008 at 02:29:18PM +0900, KOSAKI Motohiro wrote:
> > > > > I don't see a better way to solve it, other than avoiding lru_add_drain_all
> > > >
> > > > Well,
> > > >
> > > > Unfortunately, lru_add_drain_all is also used some other VM place
> > > > (page migration and memory hotplug).
> > > > and page migration's usage is the same of this mlock usage.
> > > > (1. grab mmap_sem 2. call lru_add_drain_all)
> > > >
> > > > Then, change mlock usage isn't solution ;-)
> > >
> > > No, not mlock alone.
> >
> > Ah, I see.
> > It seems difficult but valuable. I'll think this way for a while.
>
> Well, I think it would be nice if we can reduce lru_add_drain_all,
> however your patch might be the least intrusive and best short term
> solution.

Yup, thanks.

I also think my way is the best solustion of 2.6.28 age.
and I should work on your better solution for long term.