Re: [PATCH for mmotm 0414] vmscan,memcg: reintroduce sc->may_swap

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

2009/4/19 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
> Hi
>
> Hi
>
>>> @@ -1724,6 +1728,7 @@ unsigned long try_to_free_mem_cgroup_pag
>>>       struct scan_control sc = {
>>>               .may_writepage = !laptop_mode,
>>>               .may_unmap = 1,
>>> +             .may_swap = 1,
>>>               .swap_cluster_max = SWAP_CLUSTER_MAX,
>>>               .swappiness = swappiness,
>>>               .order = 0,
>>> @@ -1734,7 +1739,7 @@ unsigned long try_to_free_mem_cgroup_pag
>>>       struct zonelist *zonelist;
>>>
>>>       if (noswap)
>>> -             sc.may_unmap = 0;
>>> +             sc.may_swap = 0;
>>
>> Can this be directly initialized?
>>
>> struct scan_control sc = {
>>        ...
>>        .may_swap = !noswap,
>>        ...
>> };
>
> your proposal is better coding style. but I also prefer condig style
> consistency.
> I think we should change may_unmap and may_swap at the same time.
> Thus, I'd like to does it by another patch.

Grr, I've misunderstood your comment.
Will fix as your suggestion.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>