From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A1BEB64DC for ; Mon, 3 Jul 2023 10:47:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA9F46B011C; Mon, 3 Jul 2023 06:47:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D59F56B011D; Mon, 3 Jul 2023 06:47:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C228E8E00BA; Mon, 3 Jul 2023 06:47:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B37B66B011C for ; Mon, 3 Jul 2023 06:47:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 87D7C1C7DC5 for ; Mon, 3 Jul 2023 10:47:40 +0000 (UTC) X-FDA: 80969974680.20.2EED5C2 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf24.hostedemail.com (Postfix) with ESMTP id 9253D180007 for ; Mon, 3 Jul 2023 10:47:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688381258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0pgiVTiJV85KYdFZsn/u4+OjbChkIzO5jipDAA2eIs=; b=fSh2tW4zOpOdDebBT89/xVGkd970PG2Pj/C/2B2tcIDHeUykNcd47ljYwU+gibiBVj+vSd XoIbqBXQ8Z2W6iMgeZp0DtwweDCLHVHJX+iNX2hi740ZRKDdbNWBXbIVjav2yLiSD+AKx2 MB0uAeKVK3+7MQu8WALJDH9bQrB8/gs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688381258; a=rsa-sha256; cv=none; b=Zu8WuyQ5DuPbt86Umv8LY35azFmg0dLq/ZJA9NvVqJd18VeieLKJp2m28/ah8R1pyZeLA5 X2Ega++sRl7M96ntO9a+EHTJ5AA1eliXj82sAxMq1ulIeGmXNj8y10WEZg7OT/Z9FABYfq mE98PvTkpPpQDJ0wLLxnJX6f+uMG1uQ= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4fb7769f15aso6660797e87.0 for ; Mon, 03 Jul 2023 03:47:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688381257; x=1690973257; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q0pgiVTiJV85KYdFZsn/u4+OjbChkIzO5jipDAA2eIs=; b=CCnBgGmKT5yfVohWHJ70TxgEdFBNTZpy85nWJPxsn6BOrxIuV7w7aVzwNGzqkug1kw tgRt52aJQxqzPDotgVAYjAYi4Wc6oKNlW6Ld0QAIQSLtYtGIyNVG5CxVLEBGQCESeYwL h/bZmRNmBeMl+hQJdLul56hhRR2DuBDf6Z5hHieMXEfJHzTjI9H3cJu3Crnz13c/vxhB 83bMrLGuHuzRehuQT/G2JYn22X5kQ0cqotOyVfLa5VHnUmjJ2eG1yURes9jdxJUw5hpz ANALciYjYylWu3lUf5Yu3Uc30IOLKmFZ7nXjEyTu55Fi6hc6LmmZtLBOAEuEPkpxb40N Pk7Q== X-Gm-Message-State: ABy/qLYgJnvZaOFDvfjrjctkuNWRAW6D4dghsuzEExxIT+nTabmGbZjc klBcLVVL4VgfvP8w0APt+Ug= X-Google-Smtp-Source: APBJJlHQ/cbXe9ha7CIPXP3O2bAfXoMcUZ/X0EY7P046JU2Y4R8qaIbjyO02AceXRYrZ0C013Zie2w== X-Received: by 2002:a05:6512:3e29:b0:4fb:73b5:e1cf with SMTP id i41-20020a0565123e2900b004fb73b5e1cfmr8329655lfv.64.1688381256424; Mon, 03 Jul 2023 03:47:36 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003f90a604885sm26673425wma.34.2023.07.03.03.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 03:47:35 -0700 (PDT) Message-ID: <2f150512-e460-a9ae-65db-39dc54fe99d6@kernel.org> Date: Mon, 3 Jul 2023 12:47:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, jacobly.alt@gmail.com References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-30-surenb@google.com> <9a8d788c-b8ba-1b8a-fd79-0e25b1b60bed@kernel.org> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9253D180007 X-Stat-Signature: xjmcmkwbe8zz86odkpyyo5d3ynx5cgij X-Rspam-User: X-HE-Tag: 1688381258-701882 X-HE-Meta: U2FsdGVkX1/R3kEPUDyFfPSWFbcEeSUOp5ZDNNpnjzfgWWVRyZ7XYV3bDfH/l99MYQdJ6RRHv5v+DgjYQ7QTalhS0Fomof1AW3BEjGdcRG3o/rsiQ8rArNGyBKkbWw4tc+tHqaaLiPpJ4HjVDBpAWF66/TEAoVj6pspXNMucLdGfre/0KBLx7Xnixee2bnXkhK9pl2WzMJbazgFs78SNCkrN5v7zF+C6/ZF7NsdJeLB2vYOtabB+BY61A0TUDvZcbF8hw9/ZxvWuG0nAUe62sThslHX39ejGJZhbRswbYY95pz1McgFfmyrelZuADnTEtym2A08bELJ2sGA8U81H6TqyalyEbH5qgpBpPLJ/M4Swcg8iAX3WEtmt/YOrJl3ns582PU5+FtfkseDmzyt6NxssjDRipyCoevltS9oRaxD+N+x6rIJdxiZ9fOJTxdMvCZ5sPWOrtzVEYMVCOCS5j3U62ndK+zunFQ0hR7g4iPZxStmwSb6QZ1i3C+D6W7djLjSTJjdvy1HGVQTf3yJUcdsAEUSO4r6soeFG5d6bzevWPTiwHKYIxr95N3ano8EgBjHq32kK/QDUqiuixvjw2HMouDRt/FGCmAcVPLpyFbmbV7ebah2Na1LF7Wpe+wUy2I7hTWn7ZVeFueSWWfRdj9PD8YsMM8kYHOnYLPU4/JrQ6zlAkCC6aFlR3KCPuZOvqpqyPWztDeSDQK5ZW75V9MxkQ1NqtWDCu8R1hV4u/Cr+A68QylssS7W+Mlf/aemPq/A9IFriI3NIZiEyeVYEGbmq1V4a4XHcbINOlvSEykG02XW9vB8/InA9VvkREw07q6A1zHN5IAgqLXtS7R9O5vogJ/JgEpqzk37XGswGrp59GIUciHmwafqLL0LbIS4pnk/rqmuHUBeQxhMx6C2ZOfcCIR8wiKizTt7c+gsfuk/l9JPIdiMVsxYUQgC9aC3T3IuwE2YIjoNvrf88riQ 5saR+oUp Fn+kUD+QKAC0ePAOZPI7xrKlB7lCSTzFh3kb6YWezznzssXkgI4Xkmr/h9n8isTSnWA3zp/MXMHEjxsK6/AwzFt+sHr4zMdL3TDTU7lgyVkEpsLz2pbqZPhJTc7jvm3P9KvAEXOuAWsE8xHhOjBTOj2WNvbKms+v9jL1DWrrL741UXWxs7dnebUgWfau9Yak0MO/mRWkXPS/3HBh3/o8ue5xGneV9CD29+Up/w1/+p/fqxC7PYwD6vX5k40+QKiMHd0kLXlw+KY3CCQMzR5iFKg4atL2/ELby/bEmRoHURmIE/fbB2TuHM3GVaXYc8wpLrz24ku456B8qRG1gxNNGayBo0AFUJ27wynbM+TNdOEJjdX+vDLf7L1K3bCHbUl0jU9cfzjPgpIWxgtYf4VCWnwYFOBDnfEc3hxQDH60jMhcjK1dHny8guz7td2YgyCeJ82ueeW+pQCBfrmVvvWdxk+qbTbeme0Jn4VzjQZr5ZWAYqP5jzhbTxDeTI2FhhrlVZZpUm0MrlHyWrBdrE3KMP63DJCDocJzgHuxmFFNRKToQgsDVN2zIA3aVOGss29YhHquhv0b/113X8buku/YFFN0YRo+Pm2YwDqrxS8W2+FNa3yGzTanaWDxt4rjftm4BEUMB/n3aEkeKw5k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Cc Jacob Young (from kernel bugzilla) On 30. 06. 23, 19:40, Suren Baghdasaryan wrote: > On Fri, Jun 30, 2023 at 1:43 AM Jiri Slaby wrote: >> >> On 30. 06. 23, 10:28, Jiri Slaby wrote: >>> > 2348 >>> clone3({flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, child_tid=0x7fcaa5882990, parent_tid=0x7fcaa5882990, exit_signal=0, stack=0x7fcaa5082000, stack_size=0x7ffe00, tls=0x7fcaa58826c0} => {parent_tid=[2351]}, 88) = 2351 >>> > 2350 <... clone3 resumed> => {parent_tid=[2372]}, 88) = 2372 >>> > 2351 <... clone3 resumed> => {parent_tid=[2354]}, 88) = 2354 >>> > 2351 <... clone3 resumed> => {parent_tid=[2357]}, 88) = 2357 >>> > 2354 <... clone3 resumed> => {parent_tid=[2355]}, 88) = 2355 >>> > 2355 <... clone3 resumed> => {parent_tid=[2370]}, 88) = 2370 >>> > 2370 mmap(NULL, 262144, PROT_READ|PROT_WRITE, >>> MAP_PRIVATE|MAP_ANONYMOUS, -1, 0 >>> > 2370 <... mmap resumed>) = 0x7fca68249000 >>> > 2372 <... clone3 resumed> => {parent_tid=[2384]}, 88) = 2384 >>> > 2384 <... clone3 resumed> => {parent_tid=[2388]}, 88) = 2388 >>> > 2388 <... clone3 resumed> => {parent_tid=[2392]}, 88) = 2392 >>> > 2392 <... clone3 resumed> => {parent_tid=[2395]}, 88) = 2395 >>> > 2395 write(2, "runtime: marked free object in s"..., 36 >> ...> >>> >>> I.e. IIUC, all are threads (CLONE_VM) and thread 2370 mapped ANON >>> 0x7fca68249000 - 0x7fca6827ffff and go in thread 2395 thinks for some >>> reason 0x7fca6824bec8 in that region is "bad". > > Thanks for the analysis Jiri. > Is it possible from these logs to identify whether 2370 finished the > mmap operation before 2395 tried to access 0x7fca6824bec8? That access > has to happen only after mmap finishes mapping the region. Hi, it's hard to tell, but I assume so. For now, forget about this go's overly complicated, hard to reproduce case and concentrate on the very nice reduced testcase in: https://bugzilla.kernel.org/show_bug.cgi?id=217624 ;) FWIW, I can reproduce using the test case too. thanks, -- js suse labs