From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDA6C4332F for ; Tue, 18 Oct 2022 12:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 519F46B0072; Tue, 18 Oct 2022 08:30:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C9ED6B0075; Tue, 18 Oct 2022 08:30:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B8426B0078; Tue, 18 Oct 2022 08:30:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 304696B0072 for ; Tue, 18 Oct 2022 08:30:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E9E3DC0CBC for ; Tue, 18 Oct 2022 12:30:32 +0000 (UTC) X-FDA: 80034003504.13.61A1DDC Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 3A90D1C0034 for ; Tue, 18 Oct 2022 12:30:30 +0000 (UTC) Received: from [192.168.10.9] (unknown [39.45.244.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9A9C96602363; Tue, 18 Oct 2022 13:30:24 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666096229; bh=XrK7UDKQ26rBS+50UH9ViTCAxUXkpLoN+e1Isa94oQo=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=QbVvAvx10uxuWUCVHvhs1nQxY/ad3dXtF4UyVrCk2MXOXAuSEVbcXs9cd73OP4YXr wM7H8NGGpGLD4oUdIseZ3LsUAczfdh9qzrMWaCbkQbmcnKieBM0DVnZ3wQle7DmiXF cHVxJilap0ln6QEcpOPzeNAdG8Q+u/lxwPW6gG6cD+ylvCpiVZa1lESAk4jC9MN3z1 4f4af2QTKx/nh7uN7WV1BOygZH2Ic8NOjJXf+0058dY9Y1l98r/u3jhfDziKEAh1rj ho4jNAbFe87KcNnQ9eNp6OzphKzopvg37e9G4FppvyqmfaYkWKQYqHfaN/FjiJWeoE KymKxN3Z6ZMFQ== Message-ID: <2f95ed2d-6dba-850c-7ae9-5c0ebc05191c@collabora.com> Date: Tue, 18 Oct 2022 17:30:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Cc: Muhammad Usama Anjum , Danylo Mocherniuk , avagin@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org, corbet@lwn.net, david@redhat.com, kernel@collabora.com, krisman@collabora.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, peter.enderborg@sony.com, shuah@kernel.org, viro@zeniv.linux.org.uk, willy@infradead.org, emmir@google.com, figiel@google.com, kyurtsever@google.com, Paul Gofman , surenb@google.com Subject: Re: [PATCH v3 0/4] Implement IOCTL to get and clear soft dirty PTE Content-Language: en-US To: Greg KH References: <20221014134802.1361436-1-mdanylo@google.com> <474513c0-4ff9-7978-9d77-839fe775d04c@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666096231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AgFEk/ZNs5FzM0J0bRYuQ1IDKi9PlD2CvM9HOxWYEEQ=; b=xJ96FJC1e8A/Me++sfcUwrsxOFOsm8WluFK2BSTekfu8SxzO4aT0OggjDPgslrLy2HztCn SkQZ0WEn6r1YjrqyZR87ySBe2hTEosQSfCyqzCp5Lf091Z4+WP1gEroRzI/DsJ3U4Dxaer WZ72Q/boskISyHefltp9anVY9zVGknQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=QbVvAvx1; spf=pass (imf18.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666096231; a=rsa-sha256; cv=none; b=CYfLFl1P19J8L7C9M/VpskhmuxIwKk/jHCIGi4SeR0yqi5mDC0ruF/e6tgEKfGDB9T/cZH 4EltzbgMdlkiLEaA3nKyNbiyNx57NDLAkCM+g7clYpAorHksLL9L0AFUmnpG1ord4pImiq bFf5Khhjjqgb4+XIhEtyBCFbRoHcu0A= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=QbVvAvx1; spf=pass (imf18.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com X-Stat-Signature: n9krpmoh3ik6kb4ch6cxid8nyoim3q97 X-Rspamd-Queue-Id: 3A90D1C0034 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1666096230-911482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/18/22 3:48 PM, Greg KH wrote: > On Tue, Oct 18, 2022 at 03:36:24PM +0500, Muhammad Usama Anjum wrote: >> /** >> * struct pagemap_sd_args - Soft-dirty IOCTL argument >> * @start: Starting address >> * @len: Length of the region >> * @vec: Output page_region struct array >> * @vec_len: Length of the page_region struct array >> * @max_out_page: Optional max output pages (It must be less than vec_len if >> specified) >> * @flags: Special flags for the IOCTL >> * @rmask: Special flags for the IOCTL >> * @amask: Special flags for the IOCTL >> * @emask: Special flags for the IOCTL > > What do you mean exactly by "special flags"? Sorry typo in the comments above. Optional flag can be specified in the flag. At the moment, there is only one flag(PAGEMAP_NO_REUSED_REGIONS). /** * struct pagemap_sd_args - Soft-dirty IOCTL argument * @start: Starting address * @len: Length of the region * @vec: Output page_region struct array * @vec_len: Length of the page_region struct array * @max_out_page: Optional max output pages (It must be less than vec_len if specified) * @flags: Special flags for the IOCTL * @rmask: Required mask - All of these bits have to be set * @amask: Any mask - Any of these bits are set * @emask: Exclude mask - None of these bits are set * @rmask: Bits that have to be reported to the user in page_region */ struct pagemap_scan_args { __u64 __user start; __u64 len; __u64 __user vec; __u64 vec_len; __u32 max_out_page; __u32 flags; __u32 rmask; __u32 amask; __u32 emask; __u32 rmask; }; > >> * @__reserved: Reserved member to preserve data alignment. Must be 0. >> */ >> struct pagemap_sd_args { >> __u64 __user start; >> __u64 len; >> __u64 __user vec; // page_region > > __user is a marking for a pointer, not a u64, right? Now the fact that > you treat it like a pointer later in the kernel is different, but that > shouldn't be on the uapi header file. You can put it in the kerneldoc, > which you did not do. I'll update. > > thanks, > > greg k-h