From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C178CE7A88 for ; Sat, 23 Sep 2023 18:53:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 592186B025C; Sat, 23 Sep 2023 14:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 541BC6B026D; Sat, 23 Sep 2023 14:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40A026B0284; Sat, 23 Sep 2023 14:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3340A6B025C for ; Sat, 23 Sep 2023 14:53:15 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEC3E403EB for ; Sat, 23 Sep 2023 18:53:14 +0000 (UTC) X-FDA: 81268759908.01.233EB19 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by imf29.hostedemail.com (Postfix) with ESMTP id D3980120007 for ; Sat, 23 Sep 2023 18:53:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="WtXP/FF0"; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (imf29.hostedemail.com: domain of deller@gmx.de designates 212.227.15.19 as permitted sender) smtp.mailfrom=deller@gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695495192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6WatkCxVRfx2QnWJoXIgfgYjP1SX0zghThykffwiNAY=; b=BhlJX20PeE1izAzTdmbH4womXfFTGPNEctkB3b1nb6hwmXpUI63nCTzT74PMXA9IKuuyKm uhNA/KIX4leme4J4mPacomdtmpfoGPdUcQYO2Whc5yKC37532nJrNyiSgvm1JtfBh60ghd N145lxkCBs63NsHws22sEzW02bqEvlo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="WtXP/FF0"; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (imf29.hostedemail.com: domain of deller@gmx.de designates 212.227.15.19 as permitted sender) smtp.mailfrom=deller@gmx.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695495192; a=rsa-sha256; cv=none; b=KlyE3oNKmeA6nv9SUiye2GiDpmUEgd19ioF6kiy1KMN4dwUtuurtkaCzKLsUjRR6oZ2Cyh C6CTpCQNt8mWSXRrBBvM/dgZoLgZeIvVqPukiIgBlPQG7Xq289ik+Qe3XIkgMBEvFVT1E2 F8U0gxtxtXaFUujoh3bI4s0IYVOigko= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1695495189; x=1696099989; i=deller@gmx.de; bh=ZJtTrb7Sq+FmrmCPQSiH1SQiFHbV/uTZSgLibn8MqvI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=WtXP/FF0gTV3krMPKlozhyT9cCbVvNVGnUDybv+ELn1I2kayyLKd1ClDYXeCR5btw9fN5xQr+WI +JImi7HLFZVDAZtBbKWT+z4CViQTpvl4Hm5YEefu49VVSKPjgfVg9iJ4l2U/U/ezyCFN0qGTPYSVE lyUe0/iS+SRsMOHOARfw7OwWUYMUcaQht1ID2diG2Suy78NLIaaPmgkScBfVcodF4EIxwXNJ4QcMJ d/8m6PRSWF/kyMEvSgn+k/tvrELHfRBIFfN2sTH2We8lsEPOghTyHSWe2Cb1yCN2CpVDYtJrv0AP/ inZi9kqNE8l3GQ46mSf0026xz85WZkYUJVYQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.158.25]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2DxE-1rg38V0FiA-013cUy; Sat, 23 Sep 2023 20:53:09 +0200 Message-ID: <2fc195c7-f68a-e4e4-a122-4d68f31343d2@gmx.de> Date: Sat, 23 Sep 2023 20:53:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Content-Language: en-US To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, arnd@arndb.de, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, tsbogend@alpha.franken.de, f.fainelli@gmail.com, Thomas Zimmermann , Christophe Leroy , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230921110424.215592-1-bhe@redhat.com> <20230921110424.215592-2-bhe@redhat.com> From: Helge Deller In-Reply-To: <20230921110424.215592-2-bhe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iYbDbg/qbmEkvsjiXB0WMmbZFhVM9vL3bJja5JuI4LGOuhlYh9K vqgr69Jux1RsXhRJ2yZWJDYZu7NY9WrY2l0Zoy4Wy0CE48q0junLTjbRRVukzNZL2+PI1jE fbxV70iMHfMDXycuyHZBhqYGNiDUvBP/GtylIwohPqwwkP1sohfcBWtq+ufoGhBDALmHSHX qvwwKrIkfVI9uXC7Imf+g== UI-OutboundReport: notjunk:1;M01:P0:JTu5Qk0Qo2U=;aQUF38hNFB4gHf+A2OmqpQk1z+7 4R5BiH0KKfP1NtJtJZQZJYAqc5wHiP3GU1him/4fb/7YaVi/yhjSj/evdvoU4jaurR7CBbkDA zVoje1G5iBEISuRWTzU+xT1mNuu1ezpBQ/jwqvRZ0O2SAkeRvDEpzeXLNEJux5Lqb/+F44l2N 1AGV0dnBT71Pgrn1EYnHK0fzsBg6stVggmUOTqej4csdNCGuX1OrCKRKgw9MgGHMdzjmru2tI CWgTVNKyCPZ+NXjyX8l9BzPPlNJdmWjtR3typZfAc3MuCiecliwqyw0hIzz4pEKPeLEuNRAxv HL4d4OKYG+bN5LR9jPgy9aQYXlIOOZWbPERJQ6Sh3QdqIrL1Sd4VJ81L666EjQhha886S+K2t uhHtpZeU6O6Ot9bhz/IgvU5LvoGGpzdNcFTKDRSxiL4zUfFt+iuZ7zUF/yZMmIjJITL5xWPAL J0kZ5CQ9dDt11Ec54XdlXDqkNUMtpN28bvmMIioAHXP/T2uv/pMx/5BM7rL1HMZZtNkavNHhw qekhiLK/mHoGvIHGPzcNgMkhrnaifslsJ8G1Xzezy7GPmDV+1/twLTwrSBherfMBW4N7i3p3A mAXY3oXedTwDYwuy/3klDe/d6xWGSTee4aFyB++QDxJRv66CXYQgqsTGbvJtsmH4skHrqUlSm ChVUd0dCmOf/fxFbxyRmFUQEnAKh82mAZIzExl9sntUNp3eGTpjZi6zd6n+TS5hi9bC3cGsLf 0Wo2GyII5SNZ/8ik1biQMd9UO4OsFv9BwEvj/5CsJ3Da4LlEXFjYGhqziuAETdqNiF4abRxPe dcvJHuGlchb4EnFMP45YNW+FtcautHkpl4qWowF1EfEOC54EIA9PKQPxY4s0l76rXf4XjnME+ L/mCOseOgV4Ab+Adfok9/pDUSdvOY9sTsq/V4umV6vqANcTyUCfzY7sz2oEbUORrv0nSyGpRv HoPcJlL3XXcgposXzTk9VepWSBw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D3980120007 X-Stat-Signature: 4wwry6agobsscydnwctyhstwy1r7xr5m X-Rspam-User: X-HE-Tag: 1695495191-303103 X-HE-Meta: U2FsdGVkX1/+2wwAkwPGmR1nSyPRmPjTgurlmVDjSbfkO/bkPpZ2WqLDlzoZ6OFowTJtmnFRq6QnBGZWyUqJa7/GFvCLBGF6SB/nzM412XpBjA+XWM95mMq0NhFBMIanekcnWGyUG3+L5G1QluNcXVN3g6z/s6MyR5naObyDyKntzCvsscPHwMWl8Dop01pMheQ+itTSvFikd778SxEEJQH7jh1YO9aaCKOiEFF4EUBadvkXkmL+qk8U4y5Djbuu0X52pub/o3ilXMbSVIPtV/oqJnVCj+HiVzj4uKcldncxLAln/zRYZ6KbEVo35V4ek6EJKXw07qwH1FVfqfm6mdyuSdlHzxu9+zFmxjeQC41Ipqp0kkApBzTR93N2L/EQXBDT8fgRwH3ef5S58OjS/wxIXn/oVZophPnZwcD/ff4BswOi565FhjL4QfRqJec0tHGqyuLrjQuJOeAymtmz6pX8SFcXpbFwTBGGkLlYtqtq+thMKrKOC1I8ZCO39AYlQrqRajlhNq/OiAfznzGcHQHEWXjn3wkouhB7ayX3Kfv7sGDJgDims1faSn5OOOpg1bi0pGQYSr+BquJW86FK+Z4o4vV7NadBSbukEskq0/2CTWe9SiQgVEk4LNU7ga5Xdhb7FnePHrg+G7Xmif+RvezaD88LmPGV2ruGlFZ/WHuicVh9yQa2cg9Jc8MGgxppf9dKaktnKa7pDicb54pmkg1AQFMwGGKbeCctQX3QWVfjM+7XQIop+2hrDDn9Iy8JdNQdctZS/ebdhvin6NB646rMvs7zE47HmSNPwaH7yqXIzdWkJsBIBD3Xze3WEW1YrbkCaqN71W8dmkDdvdKDXMlP+NFKbAFw0JpHYvrz6NqST8uZSPoWU/O92U6mOkfBPV360/WOcOCR1dbPb3ewZkpojAv4FoyvFHvtzAJzOvYgsqNrRY3yxmKoWhvSJgvieUhtUfWjiJzpxTPZKbd jvqKZTav eR2Y9CmKNP5dOH2W/Zgd4SOzNvmlShqS+/ycmWWcAQAhIWV23XQY4kJsPeo570vG6tk6igtxGSPKdqUkikywUrhyDa1W+Km+U5QkxCaEiSN30sUU3HOmpuSamkrybBv9Cy2rMqqUo4yzkDy/2C2EICjuUO3UmeZY9vo07qFWfxOqiP2GQuIuTPa98JRNU0sOaDZ61DRlv/6ynKMs7q8iqv12xbLBKpl9MTxAZw8lEF6l7OxOf68MHlk8a7I3Ey4djP+HR96bIXJHVYQsf3MjZRDl4oS+cWzMpLWyVw8oH+l6XQumGYAThZWnOVWL7f5aqCb3+JT6mOjkex2WuBN2X+xwYPW6Ij8ea+PsxBpNaocU872GPFktE933X2IKUatYl335nztB8J9QFXF+LSY6GiUB/2X6MQ4b/PyF3APxF1AgF6tbPVD5K+74a+KDbUx6fho7Xwahkq9nFYhSudCqn5gFAWMK+IA+oAK3suLQRPtmg+LJyC1IB48aFSJh1A5tLwRBUDM01BKyLZ+ouyM3t9zeNCFabA6oADJ8FdyvPnHkb4oo+37D9ZNc5I/DaPJVZMLQHUxWWKvKPwD+aCDGeFDl7vKN6HY6kCwDte0iJ5bQfowjtBjsLtNO+MRTLlH8S2PU5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/21/23 13:04, Baoquan He wrote: > From: Arnd Bergmann > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior, everywhere else this is the same as ioremap() anyway. > > Change the only driver that still references ioremap_uc() to only do so > on x86-32/ia64 in order to allow removing that interface at some > point in the future for the other architectures. > > On some architectures, ioremap_uc() just returns NULL, changing > the driver to call ioremap() means that they now have a chance > of working correctly. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Baoquan He > Reviewed-by: Luis Chamberlain > Cc: Helge Deller > Cc: Thomas Zimmermann > Cc: Christophe Leroy > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org applied to fbdev git tree. Thanks! Helge > --- > drivers/video/fbdev/aty/atyfb_base.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/= aty/atyfb_base.c > index 5c87817a4f4c..3dcf83f5e7b4 100644 > --- a/drivers/video/fbdev/aty/atyfb_base.c > +++ b/drivers/video/fbdev/aty/atyfb_base.c > @@ -3440,11 +3440,15 @@ static int atyfb_setup_generic(struct pci_dev *p= dev, struct fb_info *info, > } > > info->fix.mmio_start =3D raddr; > +#if defined(__i386__) || defined(__ia64__) > /* > * By using strong UC we force the MTRR to never have an > * effect on the MMIO region on both non-PAT and PAT systems. > */ > par->ati_regbase =3D ioremap_uc(info->fix.mmio_start, 0x1000); > +#else > + par->ati_regbase =3D ioremap(info->fix.mmio_start, 0x1000); > +#endif > if (par->ati_regbase =3D=3D NULL) > return -ENOMEM; >