From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894ABECAAA1 for ; Fri, 2 Sep 2022 06:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29158800C8; Fri, 2 Sep 2022 02:53:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241788008D; Fri, 2 Sep 2022 02:53:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0944D800C8; Fri, 2 Sep 2022 02:53:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED04C8008D for ; Fri, 2 Sep 2022 02:53:16 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CBF1B1A1117 for ; Fri, 2 Sep 2022 06:53:16 +0000 (UTC) X-FDA: 79866228792.18.1BD8C47 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 876E480056 for ; Fri, 2 Sep 2022 06:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662101596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h+57PdWMxpBWbQjargyaqlxNH+Zcmno8dXbh3sZc6/c=; b=Za8uw/Y83J5zfod883Kf2VS0AywiUl8XfM1HzTxO9A6wP02JoCRCwnCFe0mLNOCAaud+Yp lk1vb7oXTFEgj+e1vrEKAuGTza18MsQWBleCLS+lpz3XhN1zPbGPiLEKb/j5gS51u3UtLW niBsldR3p4VzHbiQDrCUf+I/MwnCzKk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-261-9MYw1BA-MBaubD8DG0RHNA-1; Fri, 02 Sep 2022 02:53:13 -0400 X-MC-Unique: 9MYw1BA-MBaubD8DG0RHNA-1 Received: by mail-wm1-f69.google.com with SMTP id j36-20020a05600c1c2400b003a540d88677so744805wms.1 for ; Thu, 01 Sep 2022 23:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=h+57PdWMxpBWbQjargyaqlxNH+Zcmno8dXbh3sZc6/c=; b=cyKM0jqjtfSwPelLG9GOLmew3w3tEW/VvE3vMNeC/pIHIMfEG1/3yABi5EIJZecZGP z/BSuM8soarQQLpTI+FiDpG5O8wMMluTbQ7Zvaf7w3wTOCCWAnenIQ+CmngvCY3d7Xpy sN459J1IaPnSx45QjXEmxX1R2GndzyTijVSJDueQKlMs4GSomZPEPAKRdMlr//wA1urJ jCli8sNlHyvZYGwq9gP86uleWI6YTkXAEk6/6ZDTRTL+NCNv2UYHrKuLXheXiqSFU2Bi xSn+f5OmHa/E9GfmjMYLIHBv5OSQT2F/UO8P+ejhTqbUR4WfYwVQic+7aFLnGgoreeHw twrw== X-Gm-Message-State: ACgBeo1htbrOps9AY+wjWt2TD17+fsPrqHQwWQABjxj6oAmxK27AYv9R o9RoOHrhOhtUa/45zkATeC2YwPzcLF2whF36GUYYVslci0/MIL4bkEzXSf4Q58+cj5RL3IIOp8T bQsePOxTpuMc= X-Received: by 2002:adf:fb0e:0:b0:21a:34a2:5ca9 with SMTP id c14-20020adffb0e000000b0021a34a25ca9mr16886164wrr.472.1662101592037; Thu, 01 Sep 2022 23:53:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR72FIltlXb2TQPeyqyCZoaRVMW4kclo3DOPj63oymphdPfUvZp/uulcrUG16hwS6UnSef2yNw== X-Received: by 2002:adf:fb0e:0:b0:21a:34a2:5ca9 with SMTP id c14-20020adffb0e000000b0021a34a25ca9mr16886135wrr.472.1662101591768; Thu, 01 Sep 2022 23:53:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:4800:2077:1bf6:40e7:2833? (p200300cbc714480020771bf640e72833.dip0.t-ipconnect.de. [2003:cb:c714:4800:2077:1bf6:40e7:2833]) by smtp.gmail.com with ESMTPSA id z15-20020a5d654f000000b002211fc70174sm842621wrv.99.2022.09.01.23.53.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 23:53:11 -0700 (PDT) Message-ID: <2fccd4c1-d12f-334c-3fab-24a84bcac007@redhat.com> Date: Fri, 2 Sep 2022 08:53:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 3/4] mm/migrate_device.c: Copy pte dirty bit to page To: Alistair Popple , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Peter Xu , Nadav Amit , huang ying , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, "Huang, Ying" , stable@vger.kernel.org References: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662101596; a=rsa-sha256; cv=none; b=QTg3IsKbxrk3dNG0yiVNshxQYM2modBnDd+YenPOWcYcNjlyAZvy1C3LwFxTtVrTN45jQ+ o/Q6fdRY3EAZ8uVqGQ4/O6rnhe3MlA96z6udwmVGbCShL/9Za8YFoGui6XqhN7KvnM/bSP wBIMu4GLAYwV0XWY9qeHAdj5cuBpZzw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Za8uw/Y8"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662101596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+57PdWMxpBWbQjargyaqlxNH+Zcmno8dXbh3sZc6/c=; b=jgylXzyy0xq5Kf05NiQvyNka3aXKzIgLy7kcY+vkkA0BufTFvOjgAV3bDrW8UClbD41TGS 3z5zB63F9Cuw326R46EstWCK17ETL58V4xDU3Xc8CLaFcJTuLCBO9imMzanKnOby3FzEuT NIpTIyBJbyphd0+odoAAsG8OrQS1l54= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Za8uw/Y8"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 876E480056 X-Stat-Signature: pyaz1wdthewreuidszw9y8ph63p5uyyp X-HE-Tag: 1662101596-951405 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.09.22 02:35, Alistair Popple wrote: > migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that > installs migration entries directly if it can lock the migrating page. > When removing a dirty pte the dirty bit is supposed to be carried over > to the underlying page to prevent it being lost. > > Currently migrate_vma_*() can only be used for private anonymous > mappings. That means loss of the dirty bit usually doesn't result in > data loss because these pages are typically not file-backed. However > pages may be backed by swap storage which can result in data loss if an > attempt is made to migrate a dirty page that doesn't yet have the > PageDirty flag set. > > In this case migration will fail due to unexpected references but the > dirty pte bit will be lost. If the page is subsequently reclaimed data > won't be written back to swap storage as it is considered uptodate, > resulting in data loss if the page is subsequently accessed. > > Prevent this by copying the dirty bit to the page when removing the pte > to match what try_to_migrate_one() does. > > Signed-off-by: Alistair Popple > Acked-by: Peter Xu > Reviewed-by: "Huang, Ying" > Reported-by: "Huang, Ying" > Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") > Cc: stable@vger.kernel.org > > --- > > Changes for v4: > > - Added Reviewed-by > > Changes for v3: > > - Defer TLB flushing > - Split a TLB flushing fix into a separate change. > > Changes for v2: > > - Fixed up Reported-by tag. > - Added Peter's Acked-by. > - Atomically read and clear the pte to prevent the dirty bit getting > set after reading it. > - Added fixes tag > --- > mm/migrate_device.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 4cc849c..dbf6c7a 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -196,7 +197,7 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > flush_cache_page(vma, addr, pte_pfn(*ptep)); > anon_exclusive = PageAnon(page) && PageAnonExclusive(page); > if (anon_exclusive) { > - ptep_clear_flush(vma, addr, ptep); > + pte = ptep_clear_flush(vma, addr, ptep); > > if (page_try_share_anon_rmap(page)) { > set_pte_at(mm, addr, ptep, pte); > @@ -206,11 +207,15 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > goto next; > } > } else { > - ptep_get_and_clear(mm, addr, ptep); > + pte = ptep_get_and_clear(mm, addr, ptep); > } > > migrate->cpages++; > > + /* Set the dirty flag on the folio now the pte is gone. */ > + if (pte_dirty(pte)) > + folio_mark_dirty(page_folio(page)); > + > /* Setup special migration page table entry */ > if (mpfn & MIGRATE_PFN_WRITE) > entry = make_writable_migration_entry( This matches what we do in try_to_unmap_one() Acked-by: David Hildenbrand -- Thanks, David / dhildenb