From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E44C0015E for ; Tue, 15 Aug 2023 07:36:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6B2D900022; Tue, 15 Aug 2023 03:36:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF32490000B; Tue, 15 Aug 2023 03:36:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6C41900022; Tue, 15 Aug 2023 03:36:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B4C5C90000B for ; Tue, 15 Aug 2023 03:36:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B19DA0D43 for ; Tue, 15 Aug 2023 07:36:54 +0000 (UTC) X-FDA: 81125532348.10.7EE19F9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 57F421A000E for ; Tue, 15 Aug 2023 07:36:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DcyxvPot; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692085012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xYsmOFje5yTGttZ6v6G6PZw9DbgvJ1RnyLESMQbsig=; b=DvfP9PKnMCO+8WFWqQcG/1uw9TePBfOarGfIh7eaAYvokHi3kGKzYUNMzgYRFMBoacFnnb 9kCuqMImKLEdZpckpRxJocwbuD2JPTyZZSE+4aJIGXQ/GZtimy9zcvKEBPYIXUjJADt6eY 0AIBAGUlOc65Q/uW6pWXQX5tJTI3hfE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DcyxvPot; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692085012; a=rsa-sha256; cv=none; b=VP50ITWRUQx+CE+ERSOnVObr6KTI4vMJYe3mFabKyYjkrZ4Qtbl9A04MfP3eq/sG/k2K21 N8rzjdrcFmE+iMZMt4PJPszXav6aPzgWELQBKr1UyTc/R/d0IjHo6nEHs/YZyvNh6QOSaG FMq+IoFBcp7iWMi6mr0Ybsfa0ADi1N8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692085011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5xYsmOFje5yTGttZ6v6G6PZw9DbgvJ1RnyLESMQbsig=; b=DcyxvPottNhdPCoCPHNqTsgjfZT5qkc4kPTbapLgb9CVYBd6L1td4dbS0DZyOCVrjK6FUB sXi0QfOskUOzRWpskLxB1fKXGMxocJ/YaxQ0w6NVNG+R1Camwke3C9NXE7PQzuIlDTxvD1 U3YGpTlv5fDna/m0dYKEI6THOW+ymMk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-DRYd_g4qM6KZ26pbyvAbAQ-1; Tue, 15 Aug 2023 03:36:50 -0400 X-MC-Unique: DRYd_g4qM6KZ26pbyvAbAQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-317d5b38194so2347754f8f.0 for ; Tue, 15 Aug 2023 00:36:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692085009; x=1692689809; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5xYsmOFje5yTGttZ6v6G6PZw9DbgvJ1RnyLESMQbsig=; b=ZsXuGtbNwubNWCsF3iohASBT0s+UvgWN+H4T5SLBlUvlooHm7WkWZlJGbNkKEYEgAJ 2pXC+zZkIdu4zIQoCQLccqiWW1dDqAWnshOxwWjSfUYKr3kyf0v1OJawwtRva2ObwjX/ 1qaFBrB11es10GddsI0DXxSza0+Q5ruMWqvpb3uGzqGCW0e1zV5LtgLg+z7usODIn1++ KFfTzQjmg79yDywSACiO7zfxxmo7sgnEfl237Mg1Dyp04+22VE5WEqdIPbC/DeHsyMXg x45Nyt1OJ0CJAl9fszvlifBr7xO/L2ENEDsR46OU6Gs1mrdGmmaoVlhmqRZ4T6YgHAcK 4x5g== X-Gm-Message-State: AOJu0YwxNSY8u2sbWlKjX+G77qYn6WPN/Y7VSGZXtWzoYBW08MyAGnVw Ng6I9CV2SGlNX/appfFpU1cLe1Bz76vsHRetJScwHz+LSSSuTyOnG6C6+l69bf3DKgp/DoX2QdE h5RHD4UyXiF4= X-Received: by 2002:adf:e912:0:b0:317:417e:a467 with SMTP id f18-20020adfe912000000b00317417ea467mr910008wrm.6.1692085008886; Tue, 15 Aug 2023 00:36:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4BLbc0ajsG2PUQkkYbOcqfYBJBCjFQA/1JcmpTjMqb2JosO9nATgJcn3uasJezff3hjVvyQ== X-Received: by 2002:adf:e912:0:b0:317:417e:a467 with SMTP id f18-20020adfe912000000b00317417ea467mr909991wrm.6.1692085008522; Tue, 15 Aug 2023 00:36:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id v9-20020a5d6b09000000b0031759e6b43fsm16970637wrw.39.2023.08.15.00.36.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 00:36:48 -0700 (PDT) Message-ID: <2fef37cc-1fd7-e8b1-28c4-becd131f82b7@redhat.com> Date: Tue, 15 Aug 2023 09:36:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/9] mm: Call the hugetlb destructor directly To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-3-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230815032645.1393700-3-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 57F421A000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fip4qszryiarcq3cakgzuw7agjpahjdn X-HE-Tag: 1692085012-635932 X-HE-Meta: U2FsdGVkX18Dh8Eqm+OtHQHeVTKLmvjqx4buykwXRAPCr7FxFHeIL2PStp8DpuUIT2y+qThk+S+Sn8X3hi4lxxUQgKfF+velHH0Qqe2t6qdfc/QxRC0K/aRj34xZCJqUtLKhaUEhbeoNjVxpXZrRSyrdir6tQykPWEY3LfvPU5TdEPQ/IKUVU0xE6w+9H3fd/DJS6sEovs0aZJLCU0kHo5OJDvKYRrfB83Un84omP+0kw2erzudFVBbwBz3zUxcqYheoWPc6njYaGW713WNemYG7zQYgFp558IqCrVCS4hxtiA4aS8GuJ2X3liTxwmrhzuWo3swQ8Ih70SqTCS2KNiouUSL2eRbBy3xbjcwAc8i0f+IAyZuz26xPdoMwmMDdukDy1nwMUbV08KtFyC/LrrXsJIgRvFJyEQX4e7dKV3Qp2Layuw/Dr8DMB7a2nLQdlzMVVfWCx1GnvtNHf/IkMeC+JcZm6rqIA2yKJjvx+UVpiluwEVOyV4SffenZCPrmip21ik6fiKje67rkS0M/Vg1f6flw0dAoZsnrrx/U69J4DILDqDxZgIP1DW7ed389+RgadOkUnfXrkt0VxEgjT2REQUyFESAk9W4y+Ddylgf3oN0naWxRheEM+TdKH6gTknqTDIIw47OKvRIBjCMU8hAkD4GZ2Kd3CBMakvyScGWbK6VBbxBqXwL+y3+ncpLE4hOcOe0uK15jgM6RNl17FJ5AsOtjLFliKhljRYtuHczPRbhaQZ6kDsDBZ2yVWX/Qw0fjBexyYNXWcWVMJwyqUBbmZQGGJnsmxuoMtA4/gX0byox7CCx9WlMrdOoGZXBbd8vKl/zuYbusEfceT4P4pDlqJ76S0BsDRrI2vAQGU6Ks52+YxKxK+VEYaTQHxNgyjsyfPWgPXPoIaa99oDCGLT8UMg9MboEMLKFT9EduzCSQ3EZHQiyOUsbx5ceDNscCcfnTmpPiJWp2Njg+K2x 9HEfNxAu SQ/FJcLtPLGStBA1xZqu5UXkJllL468GugC7Zz9XQquVkMeeGZJzTXB7/NyUSiUX+WDtDMS0EpKc3hS7j7VZPUrcq2NTvFoypXO1rXh/nhOTJEQpIaBVRts8xDBEE89pDTOdih5zrT8g7JWuzvyowlGxQeG7z1YJcPTnV0+GG7SAOaet5ah4fph/aQRYdGSQ6XXLx4zSef78PX9pvKuz9ze+r11gO58oc+YoqDFnANlFMXmh0WNV7vQj67rLDcTDh9VeEAYTGWKyx0VfBntpCzJ+s2LDsOrjwtcRVLNPj0+38D7FGndrCbGpiKG6IIstwe24yPndjox5JffbH+GouVIcRwSuf4PqzjLjUHNeMkcS8P4jWIiMOJyZ++Ko6bI0qkw07lVy7M4TAo6pu6mHUipNAMXVCGpMNfBAhhnKsO4efEtbTH88b/xMmMUnM+cGAhec1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: > Indirect calls are expensive, thanks to Spectre. Convert this one to > a direct call, and pass a folio instead of the head page to save a few > more instructions. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/hugetlb.h | 3 ++- > include/linux/mm.h | 6 +----- > mm/hugetlb.c | 26 ++++++++++++-------------- > mm/page_alloc.c | 8 +++++--- > 4 files changed, 20 insertions(+), 23 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 0a393bc02f25..9555859537a3 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -26,6 +26,8 @@ typedef struct { unsigned long pd; } hugepd_t; > #define __hugepd(x) ((hugepd_t) { (x) }) > #endif > > +void free_huge_page(struct folio *folio); > + > #ifdef CONFIG_HUGETLB_PAGE > > #include > @@ -165,7 +167,6 @@ int get_huge_page_for_hwpoison(unsigned long pfn, int flags, > bool *migratable_cleared); > void folio_putback_active_hugetlb(struct folio *folio); > void move_hugetlb_state(struct folio *old_folio, struct folio *new_folio, int reason); > -void free_huge_page(struct page *page); > void hugetlb_fix_reserve_counts(struct inode *inode); > extern struct mutex *hugetlb_fault_mutex_table; > u32 hugetlb_fault_mutex_hash(struct address_space *mapping, pgoff_t idx); > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 19493d6a2bb8..7fb529dbff31 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1278,13 +1278,9 @@ typedef void compound_page_dtor(struct page *); > enum compound_dtor_id { > NULL_COMPOUND_DTOR, > COMPOUND_PAGE_DTOR, > -#ifdef CONFIG_HUGETLB_PAGE > HUGETLB_PAGE_DTOR, > -#endif > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > TRANSHUGE_PAGE_DTOR, > -#endif > - NR_COMPOUND_DTORS, > + NR_COMPOUND_DTORS > }; > > static inline void folio_set_compound_dtor(struct folio *folio, > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index e327a5a7602c..bc340f5dbbd4 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1875,13 +1875,12 @@ struct hstate *size_to_hstate(unsigned long size) > return NULL; > } > > -void free_huge_page(struct page *page) > +void free_huge_page(struct folio *folio) free_huge_page" but passing a folio, hm. Maybe something like "free_hugetlb_folio" would be better. Apart from that LGTM. -- Cheers, David / dhildenb