From: Pratyush Yadav <pratyush@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Alexander Graf <graf@amazon.com>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Miu <jasonmiu@google.com>,
Jork Loeser <jloeser@linux.microsoft.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 01/22] kho: generalize radix tree APIs
Date: Thu, 30 Jul 2026 13:50:34 +0200 [thread overview]
Message-ID: <2vxzmrv87l2t.fsf@kernel.org> (raw)
In-Reply-To: <amsN9_4LTNFBxaFE@kernel.org> (Mike Rapoport's message of "Thu, 30 Jul 2026 11:40:23 +0300")
On Thu, Jul 30 2026, Mike Rapoport wrote:
> On Wed, Jul 29, 2026 at 04:55:46PM +0200, Pratyush Yadav wrote:
>> From: "Pratyush Yadav (Google)" <pratyush@kernel.org>
>>
>> Generalize the APIs by taking the key directly and doing the encoding at
>> the callers. Rename the functions to kho_radix_add_key() and
>> kho_radix_del_key(). In practice, this removes a line each from the
>> functions and moves the encoding function call to the callers.
>> Similarly, update kho_radix_tree_walk_callback_t to take the key
>> directly.
>>
>> diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h
>> index 84e918b96e53..f368f3b9f923 100644
>> --- a/include/linux/kho_radix_tree.h
>> +++ b/include/linux/kho_radix_tree.h
>> @@ -34,30 +34,24 @@ struct kho_radix_tree {
>> struct mutex lock; /* protects the tree's structure and root pointer */
>> };
>
> sashiko: This isn't a bug, but did you miss updating the kerneldoc for
> struct kho_radix_tree?
That's new, sashiko didn't find this on v4...
>
> And indeed "DOC: Kexec Handover Radix Tree" talks about addresses and
> orders.
Yep, will fix for v6.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-07-30 11:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:55 [PATCH v5 00/22] kho: make boot time huge page allocation work nicely with KHO Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 01/22] kho: generalize radix tree APIs Pratyush Yadav
2026-07-30 8:40 ` Mike Rapoport
2026-07-30 11:50 ` Pratyush Yadav [this message]
2026-07-29 14:55 ` [PATCH v5 02/22] kho: make radix max key width more obvious Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 03/22] kho: disallow wide keys in radix tree Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 04/22] kho: return virtual address of mem_map from kho_get_mem_map() Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 05/22] kho: store incoming radix tree in kho_in Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 06/22] kho: move all memory retrieval logic to kho_mem_retrieve() Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 07/22] kho: add a struct for radix callbacks Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 08/22] kho: add callback for table pages Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 09/22] kho: add data argument to radix walk callback Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 10/22] kho: allow early-boot usage of the KHO radix tree Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 11/22] kho: allow destroying " Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 12/22] kho: add kho_radix_init_tree() Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 13/22] kho: expose kho_scratch_overlap() to kexec_handover.h Pratyush Yadav
2026-07-29 14:55 ` [PATCH v5 14/22] kho: initialize kho_scratch pointer earlier in boot Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 15/22] kho: initialize preserved memory map radix tree earlier Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 16/22] mm/mm_init: simplify deferred_free_pages() migratetype init Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 17/22] mm/mm_init: don't rely on memblock to get KHO scratch migratetype Pratyush Yadav
2026-07-30 7:23 ` Mike Rapoport
2026-07-30 11:53 ` Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 18/22] kho: extend scratch Pratyush Yadav
2026-07-30 8:37 ` Mike Rapoport
2026-07-30 11:48 ` Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 19/22] memblock: always include KHO headers Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 20/22] memblock: make HugeTLB bootmem allocation work with KHO Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 21/22] memblock: add memblock_reserved_hugetlb_size() Pratyush Yadav
2026-07-29 14:56 ` [PATCH v5 22/22] kho: exclude hugetlb memory from scratch size calculation Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzmrv87l2t.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=graf@amazon.com \
--cc=jasonmiu@google.com \
--cc=jloeser@linux.microsoft.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox