From: Pratyush Yadav <pratyush@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Alexander Graf <graf@amazon.com>,
Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Miu <jasonmiu@google.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/12] kho: allow destroying KHO radix tree
Date: Fri, 22 May 2026 15:24:09 +0200 [thread overview]
Message-ID: <2vxzwlwv7f2e.fsf@kernel.org> (raw)
In-Reply-To: <ag-Xa-bDOouXAFXb@plex> (Pasha Tatashin's message of "Thu, 21 May 2026 23:46:23 +0000")
On Thu, May 21 2026, Pasha Tatashin wrote:
> On 04-29 15:39, Pratyush Yadav wrote:
>> From: "Pratyush Yadav (Google)" <pratyush@kernel.org>
>>
>> Add kho_radix_destroy_tree() which allows destroying the radix tree and
>> freeing all its pages.
>>
>> Signed-off-by: Pratyush Yadav (Google) <pratyush@kernel.org>
>> ---
>> include/linux/kho_radix_tree.h | 3 +++
>> kernel/liveupdate/kexec_handover.c | 34 ++++++++++++++++++++++++++++++
>> 2 files changed, 37 insertions(+)
>
> Generally, in Linux, recursion is avoided due to statically sized kernel
> stacks. However, here we are bound by a relatively shallow KHO tree, and
> kho_radix_walk_tree() is already recursive, so I think it is alright. We
> just need to be mindful of local variable usage (frame sizes) within these
> recursive functions.
Yep, recursion is strictly bounded and the depth is no worse than any
page table walkers for example.
>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks!
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-05-22 13:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 13:39 [PATCH 00/12] kho: make boot time huge page allocation work nicely with KHO Pratyush Yadav
2026-04-29 13:39 ` [PATCH 01/12] kho: generalize radix tree APIs Pratyush Yadav
2026-05-04 14:44 ` Pasha Tatashin
2026-05-05 11:20 ` Jork Loeser
2026-05-05 12:54 ` Pratyush Yadav
2026-05-05 13:12 ` Pasha Tatashin
2026-05-11 11:32 ` Mike Rapoport
2026-05-11 16:25 ` Pratyush Yadav
2026-05-13 10:32 ` Mike Rapoport
2026-04-29 13:39 ` [PATCH 02/12] kho: store incoming radix tree in kho_in Pratyush Yadav
2026-05-11 11:43 ` Mike Rapoport
2026-05-11 16:28 ` Pratyush Yadav
2026-05-12 6:46 ` Mike Rapoport
2026-05-21 23:27 ` Pasha Tatashin
2026-04-29 13:39 ` [PATCH 03/12] kho: add a struct for radix callbacks Pratyush Yadav
2026-05-11 11:47 ` Mike Rapoport
2026-05-11 16:35 ` Pratyush Yadav
2026-05-12 6:48 ` Mike Rapoport
2026-05-12 9:11 ` Pratyush Yadav
2026-05-21 23:31 ` Pasha Tatashin
2026-04-29 13:39 ` [PATCH 04/12] kho: add callback for table pages Pratyush Yadav
2026-05-11 11:50 ` Mike Rapoport
2026-05-11 16:36 ` Pratyush Yadav
2026-05-11 16:40 ` Pratyush Yadav
2026-04-29 13:39 ` [PATCH 05/12] kho: add data argument to radix walk callback Pratyush Yadav
2026-05-11 11:53 ` Mike Rapoport
2026-05-11 16:37 ` Pratyush Yadav
2026-05-21 23:34 ` Pasha Tatashin
2026-04-29 13:39 ` [PATCH 06/12] kho: allow early-boot usage of the KHO radix tree Pratyush Yadav
2026-05-11 11:56 ` Mike Rapoport
2026-05-11 16:37 ` Pratyush Yadav
2026-05-21 23:37 ` Pasha Tatashin
2026-04-29 13:39 ` [PATCH 07/12] kho: allow destroying " Pratyush Yadav
2026-05-11 11:57 ` Mike Rapoport
2026-05-21 23:46 ` Pasha Tatashin
2026-05-22 13:24 ` Pratyush Yadav [this message]
2026-04-29 13:39 ` [PATCH 08/12] kho: add kho_radix_init_tree() Pratyush Yadav
2026-05-06 10:51 ` Jork Loeser
2026-05-11 11:05 ` Pratyush Yadav
2026-04-29 13:39 ` [PATCH 09/12] memblock: introduce MEMBLOCK_KHO_SCRATCH_EXT Pratyush Yadav
2026-05-11 12:06 ` Mike Rapoport
2026-05-11 16:46 ` Pratyush Yadav
2026-05-22 0:48 ` Pasha Tatashin
2026-05-22 15:02 ` Pratyush Yadav
2026-04-29 13:39 ` [PATCH 10/12] kho: extended scratch Pratyush Yadav
2026-05-17 10:17 ` Mike Rapoport
2026-04-29 13:39 ` [PATCH 11/12] kho: return virtual address of mem_map Pratyush Yadav
2026-05-11 12:13 ` Mike Rapoport
2026-05-11 16:48 ` Pratyush Yadav
2026-05-12 6:51 ` Mike Rapoport
2026-04-29 13:39 ` [PATCH 12/12] mm/hugetlb: make bootmem allocation work with KHO Pratyush Yadav
2026-05-17 10:05 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzwlwv7f2e.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=graf@amazon.com \
--cc=jasonmiu@google.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox