Re: [patch] generic rwsems

David Howells
2007-04-13T14:49:06Z

Eric Dumazet <dada1@cosmosbay.com> wrote:

> If space considerations are that important, we could then reserve one bit
> for the 'wait_lock spinlock'

That makes life quite a bit more tricky, though it does have the advantage
that it closes the reader-jumping-writer window I mentioned.

> Another possibility to save space would be to move wait_lock/wait_list
> outside of rw_semaphore, in a hashed global array.

I suspect moving wait_list out would be a bad idea. The ordering of things in
the list is very important. You need to perform several operations on the
list, all of which would be potentially slower:

(1) glance at the first element of the list to see what sort of wake up to do

(2) iteration of the list when waking up multiple readers

(3) seeing if the list is empty (so you know that there's no more contention)

Moving the spinlock out, on the other hand, might be worth it to cut down on
cacheline bouncing some more...

David