From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B975FC3DA45 for ; Thu, 11 Jul 2024 17:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46D8A6B00A6; Thu, 11 Jul 2024 13:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41F8F6B00A8; Thu, 11 Jul 2024 13:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 296CC6B00A9; Thu, 11 Jul 2024 13:21:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0B1E56B00A6 for ; Thu, 11 Jul 2024 13:21:47 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9875C0759 for ; Thu, 11 Jul 2024 17:21:46 +0000 (UTC) X-FDA: 82328139012.14.F67D784 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 371A812001A for ; Thu, 11 Jul 2024 17:21:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iDt61y48; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ToJzYEyg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iDt61y48; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ToJzYEyg; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720718471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e1tsKfUsWamP1++J53rRBbgIxTAdcWCi2IaUQ2jUMkw=; b=sne98QsLv6eTSfaYhhqmRH3Xm0dhOidiexxI0o9SPOhlHUYRI50Gh5WWUXjuWBLMu5iZrq oNEMSSvCeB6PaqChwU3XMmqZpURcDSLcSa3+jcNh0xFuVQVr77dBnCiZnTWlworI9ErspJ RXkG82xya3Z0BI65eRuiuVA6TXfEqAs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720718471; a=rsa-sha256; cv=none; b=Ip1v5tmEGtNPpN56L06nEJRb6nQYmx5R/NIDWxXxwdgMLIT1zt+p3/Jh82bK4MY3AaibxK vxHzVif6W2fpuGRP3A4OAsN3rW2Fs61memoT5YVjafqf/EU0rvVqbnMRafuQ6PF/TF3Dng fnlqdSvrqrJZe3YdxqgFVbrgzZD/yqs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iDt61y48; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ToJzYEyg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iDt61y48; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ToJzYEyg; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F09B1FB3D; Thu, 11 Jul 2024 17:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720718501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e1tsKfUsWamP1++J53rRBbgIxTAdcWCi2IaUQ2jUMkw=; b=iDt61y48u8mOAHAhs9f08l8s9m9GxoiKpQ2fRDWEgMBTfOYUt1kQ5idaIdTc9iL4Zmc/R2 fK1uVet/4UN82gTMb0+c1PNemD+7wdg+lu8tsEYcci7aqXYSMIrv1CYRD6igiC70Z5c6UL KPJ4HRQlNOrVE7dP+vS7Ps3JfwHfRJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720718501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e1tsKfUsWamP1++J53rRBbgIxTAdcWCi2IaUQ2jUMkw=; b=ToJzYEygZ3FOI8D5361LGiS/iDoi8zBq6JGePEX+DLb7KG6GcJ2YG6RE/kcr72bqPHFUR3 Gu/rTRTf66PHdEDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720718501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e1tsKfUsWamP1++J53rRBbgIxTAdcWCi2IaUQ2jUMkw=; b=iDt61y48u8mOAHAhs9f08l8s9m9GxoiKpQ2fRDWEgMBTfOYUt1kQ5idaIdTc9iL4Zmc/R2 fK1uVet/4UN82gTMb0+c1PNemD+7wdg+lu8tsEYcci7aqXYSMIrv1CYRD6igiC70Z5c6UL KPJ4HRQlNOrVE7dP+vS7Ps3JfwHfRJQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720718501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e1tsKfUsWamP1++J53rRBbgIxTAdcWCi2IaUQ2jUMkw=; b=ToJzYEygZ3FOI8D5361LGiS/iDoi8zBq6JGePEX+DLb7KG6GcJ2YG6RE/kcr72bqPHFUR3 Gu/rTRTf66PHdEDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1C163139E0; Thu, 11 Jul 2024 17:21:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ob+BBqUUkGYoRQAAD6G6ig (envelope-from ); Thu, 11 Jul 2024 17:21:41 +0000 Message-ID: <30aa2414-3d73-4be5-adb3-10b1fc64f2a0@suse.cz> Date: Thu, 11 Jul 2024 19:21:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm, slab: move prepare_slab_obj_exts_hook under CONFIG_MEM_ALLOC_PROFILING Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: sxwjean@me.com, xiongwei.song@linux.dev, willy@infradead.org, nathan@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot References: <20240711170216.1149695-1-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240711170216.1149695-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Bar: + X-Rspamd-Queue-Id: 371A812001A X-Stat-Signature: urz7yknebn67uafubp7qkfzf4c5sons4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720718502-433856 X-HE-Meta: U2FsdGVkX19i0tb2mPP1DQz+t/38YgMSXNTyQjW9jGnWoxe1BbTkli4Lrt4k73xbaC/kU1ZRsKRnn77mJjauitbHEHnB8Ng2QqOBI56Zlk5T1nymIrFQmIubslr8bK3JRDn0wrrbDReuHPlQHbT9AhVmholzPykGoSfwxaCIHFd/0FgWCBOwtxTOv/giWW5n2ev3sMFxVJ9YdZLKeRAHjGqQKMHjRPDRMFGGOmQmP46cCNr9v9yezn8YKuy1zMkvflEjrqtYIUpPOFyGP7MFrgWjECctjx4iMQTl98a0U8cefG0BmWyI+W4ujJOehMMfloupCI73ONdMrNpxyn3buYkK2NfbxJu1W0B/3pm6DwPDuh11Rctf43wLEbTBakNRH0+ZKARkKCcG+nOGu7KlYgxVPq9QzBE57ttEmSvWbaSRP7FM+eetFUJuYDe33Ad91gLAqH0QL423hV2U+7Y7HeyjVOqgF7qua9DNhCRicHHvQ9Az4llVxfSV/B2SRfFBf8N9bWsJciT3kgQs9Y7OlbSC/yQgogsfwH4p1P9cQE7O2rR1hl4V6tAeuLF5NBweYF4DWUDwQuAYip8mZPZ6hF80qv/0/2IHDk2+tIAWOfE3XTvaDCb07lAWxGEubgNGswUAjq0L3m0ab9ZPmoHxP/X1/c9COpSTuAxQo9xsOZSqBEb21lspYnVyvteEjcWG5hCW3RGfKT1bq/nbuuYYU4rke6Z8PM3+h5rj3Zm/GOd9Hw6TRkYsvYzvHrD2tfEctL09nHEVBaaBtYcjn3gJOWtWzm/njXQJB/b4UY7Z5LnAj6WLXa0rwKIXlG/BbcgtK1t/m3niERl12LigNV3PYwHkgXa3hID5AxlrAVGaOISo8D1eitfrqOPDvxkUXfixnjKtowktUMeSu9l24pGI2kH93ls3j8+YDXhxPdDfZcWtVgVMWGHwkO9kgamqNT9EyFnokfKRkmSSFWM6qgQ eU2Stmiv cXazZhAtzrWHXqPIP93lMXeURL1bGVAeGZTXwwIVYlJ2KKvNL+d9xHv0x8HHkv1ZKvyVSDfDZEDxC/s7Vovz6scLZGQmjNdDFyAsBtsoi7vP0/8syVxW4sLXAnAZ6R0A0Egb2VOXfzElxWfNuT6p5cfWywdiZZ1d/qMN9DsVeAklSBayDZPFJ215aqt5NBlPiPZ0A+Zw9WleSDRKCTakIg0feD3aZqtVdHCzqliq915G0ZbIc9Z/y7kiglIuTeX+b5/FXqjP7Qg3/+43sdFFiS/qo08BvGwoeuX2ip6xwJsZwIGWuVMMqoqapSgqkjEFkejusac20ev+HsI9bpg60h9Y/+A/JGHm1QOup+ScKjLbkYaOpgbV/fmSYyTpjNrXhxwlRuqKNIY71YeN2rUuXyE0JhS6l0BSWeLeOXMcPlPjKeNfknVpmdzNDhqdVQ34m2mNaUF16wZGMZBFNbRqSPArxu3tDTZLYvktaCQ01ljMqQ5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/11/24 7:02 PM, Suren Baghdasaryan wrote: > The only place prepare_slab_obj_exts_hook() is currently being used is > from alloc_tagging_slab_alloc_hook() when CONFIG_MEM_ALLOC_PROFILING=y. > Move its definition under CONFIG_MEM_ALLOC_PROFILING to prevent unused > function warning for CONFIG_SLAB_OBJ_EXT=n case. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202407050845.zNONqauD-lkp@intel.com/ Hm so that's a mainline report, but being a clang-only W=1 warning I think it can just wait for the merge window and no need for last-minute 6.10 fix. > Signed-off-by: Suren Baghdasaryan > Cc: Vlastimil Babka > --- > Applied over slab/for-next because of the refactoring [1] in that branch. And thus took it there. thanks. > > [1] 302a3ea38aec ("mm, slab: move allocation tagging code in the alloc path into a hook") > > mm/slub.c | 48 +++++++++++++++++++++--------------------------- > 1 file changed, 21 insertions(+), 27 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index ce39544acf7c..829a1f08e8a2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2027,6 +2027,27 @@ static inline bool need_slab_obj_ext(void) > return false; > } > > +#else /* CONFIG_SLAB_OBJ_EXT */ > + > +static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > + gfp_t gfp, bool new_slab) > +{ > + return 0; > +} > + > +static inline void free_slab_obj_exts(struct slab *slab) > +{ > +} > + > +static inline bool need_slab_obj_ext(void) > +{ > + return false; > +} > + > +#endif /* CONFIG_SLAB_OBJ_EXT */ > + > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + > static inline struct slabobj_ext * > prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > { > @@ -2051,33 +2072,6 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > return slab_obj_exts(slab) + obj_to_index(s, slab, p); > } > > -#else /* CONFIG_SLAB_OBJ_EXT */ > - > -static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > - gfp_t gfp, bool new_slab) > -{ > - return 0; > -} > - > -static inline void free_slab_obj_exts(struct slab *slab) > -{ > -} > - > -static inline bool need_slab_obj_ext(void) > -{ > - return false; > -} > - > -static inline struct slabobj_ext * > -prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > -{ > - return NULL; > -} > - > -#endif /* CONFIG_SLAB_OBJ_EXT */ > - > -#ifdef CONFIG_MEM_ALLOC_PROFILING > - > static inline void > alloc_tagging_slab_alloc_hook(struct kmem_cache *s, void *object, gfp_t flags) > { > > base-commit: fe4e761669ab4d8b388fdb6e9dbe9a110eed8009