From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90997C636CC for ; Thu, 16 Feb 2023 12:56:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D56C6B0072; Thu, 16 Feb 2023 07:56:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 085976B0073; Thu, 16 Feb 2023 07:56:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E69726B0074; Thu, 16 Feb 2023 07:56:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D68046B0072 for ; Thu, 16 Feb 2023 07:56:19 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9CD7A1602E6 for ; Thu, 16 Feb 2023 12:56:19 +0000 (UTC) X-FDA: 80473153278.27.FB266D7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 78CDC120019 for ; Thu, 16 Feb 2023 12:56:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hwwdyHcZ; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676552177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0brO8VK06ZnIcshoHVvytI1fhIpz6iPLFoXabkZbK1Y=; b=DkTmlmfs1wMWYLBBsAJhtvAq9Mqov8TesVUxmzrHt1QDmgkkuDL43Tr56JbHOPScCK7phD Xek1KZ3oiLFBPnNkeIWgc7wX9l20CbjagOEXFLH2aDJDbC7kupFE/2I9nKcCgWndPusqlD OxTr8E+zvnIdkrtHC/or+8j6wXlL/7U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hwwdyHcZ; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676552177; a=rsa-sha256; cv=none; b=3CCTTkcNyIl1zVJ17n/tJZc5QLXZq8iOOrDdSQqtj7yv6vkTr8vXTm11R22ADCSRLeMypu 7rtZ63jlbSwHisRdlREaF3HCUHsYU/aFENBmcq1Wo9eq60vq81ynRHgxNYN4Ui9QZvX44p 40m2Dz/Cj058BxHXsn9S0uGH+DK0vok= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676552176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0brO8VK06ZnIcshoHVvytI1fhIpz6iPLFoXabkZbK1Y=; b=hwwdyHcZsebtKDs7I9jLlFB315caVPD1Uc4RvNeQoxG5AgZ3ec6hO7Bsz6u0UNemtNzfFL ucy8IHdZRggpsdj8qdF9gFtSojDsJYdOubkIdzkB0Wij9COsbDfhh0dRSKLmnc6o+z4ZdU 0AySlsP9A4zXVcftVcfNGo9S3CfNHg0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-563-zA2JlBnNNO-rkCEMizyCCA-1; Thu, 16 Feb 2023 07:56:15 -0500 X-MC-Unique: zA2JlBnNNO-rkCEMizyCCA-1 Received: by mail-wr1-f72.google.com with SMTP id p6-20020adf9d86000000b002c5400f5c76so227416wre.14 for ; Thu, 16 Feb 2023 04:56:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0brO8VK06ZnIcshoHVvytI1fhIpz6iPLFoXabkZbK1Y=; b=qTm5r/UTJJt0/Azpfq2syu3K4aQ3JjZxOpncqppQADuy8G1fHTlLR32OH/kNh5LTvn hle4GJm17rPco/OyfX07Kg3agvUjrr/KAGzc7Zy4kLMOPCO/iZtQcBbmffQV1YqqECTz N3w724AW87UiGsmeTqSmChbkgREXMh2H3Z59f0FiOdEg5ZrNIFvZ6l7l8MNYp7iPR3T3 NO2NyLL9Qhu+qs4XXi9eAcLw5IzdNDgVyZ1eWk2kOcy0HEK8fsZhE1AsPjF95fqXej7h Y1or7GODBXghwbpv1ST19NuFsU1zB4DWpQQV2Sh5bwYADJuZyXOIiThZYp8L0WqSphJz 1gow== X-Gm-Message-State: AO0yUKXPYZqzfPd733euIIbEOZcEa/0Xd5hTo5nHaMnz+jzrjfpvRkgJ 6BYBlNmOU7DcOxeskf9BR9rYdhU5iBbVH9yHHYwiJiuRfbNeLz2LppxGZ5x9JjR7JXww02bjseK T0+JBGoqJx7c= X-Received: by 2002:a5d:4382:0:b0:2c5:5da4:a3b1 with SMTP id i2-20020a5d4382000000b002c55da4a3b1mr5067820wrq.69.1676552174378; Thu, 16 Feb 2023 04:56:14 -0800 (PST) X-Google-Smtp-Source: AK7set8ga4/l/6qx8d8pgKP4FREWjdTFn59p9XK8gw6tuQF/ZAJU23f5WU3594HK3YmofYUfawVPeA== X-Received: by 2002:a5d:4382:0:b0:2c5:5da4:a3b1 with SMTP id i2-20020a5d4382000000b002c55da4a3b1mr5067803wrq.69.1676552173996; Thu, 16 Feb 2023 04:56:13 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id e14-20020a5d530e000000b002c553e061fdsm1373550wrv.112.2023.02.16.04.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 04:56:13 -0800 (PST) Message-ID: <30bc98f3-2048-1b2e-88b5-4e54dff8e0fa@redhat.com> Date: Thu, 16 Feb 2023 13:56:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] sh: initialize max_mapnr To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Greg Ungerer , Guenter Roeck , Rich Felker , Yoshinori Sato , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org References: <20230214140729.1649961-1-rppt@kernel.org> <20230214140729.1649961-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230214140729.1649961-3-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78CDC120019 X-Rspam-User: X-Stat-Signature: 7dqt5kjdni94bb1htobffhe93zgjyay5 X-HE-Tag: 1676552177-187354 X-HE-Meta: U2FsdGVkX1+yVJfjcMYtDKz+pOyrC0iP0GK/GhdEUm2SG4BVanNVXiyvo9gxy2U5mxfg47l5ACAGB+6O7FIeoIotliE+rulY29OOyEZ3W87sy4pRZxz7H+Wj2cifrfLtZHoYgbFP5oCeSy2G7fMo/5gcdYtlm//k4KvEoRakQblN5LlPFCFsZD46LbhpduBYIVFOziFtBwKPc3fHXbfOJuuJ/h9Kz3gMBt9V9nQr3lOXWIiwhIRGkrfR8RgALgmLbCjRQVyFn2hvFszklFRnXskCBiRGKP6k7Ir11PQPYsj6isTzSUQpqZM6ZASr98LYJYsFMQZ8NpJv1cfwBkNSepan1LQwGMBEI615gHa1XponUQuhEwQTjWOGZJQFKVTkbUiZC+yoSZSt49yvlE8hTsKuOjhJtPhB4eLz9GNt0INGQOWlBRAxNdTR6vDXkrkVehV14OFmjEt/FvWKOIETQB/0UYm0KuTmBBFzljd0fKr03/MYJivn44iDEyF0dEjI8c5sH0Z4qVHpglQQCqs/Tr6y96uyRt9w5/cCb+dumusTFcJieQfd42fMFtyiP5cRpSwxZBtqeigkbSNcynrkzBb2rq0rCQvX6lRAmsoeU27De4hTrIjCkTZ2/IFdHnKTnJdhUe57hxSACV3c4uLrl8XjHB2i3KQK6KRV4RBuACF8cCG39zaCk5sS8lKvJRA7OSYiFqgkzTL3BVwc7GbfEvpPO0z7kSqk1IfgFvA10wBuMYzmsa1AJkk4td9vLWdvjgw56mOTCkmdo2DxlcdgAj5ay0JBbjZ2ZXNLQ30pz+/rpgPad/LsB33MO3nciqMeEM+DR3SwOB4w3o+KAql1CDcJLWJkQ4oQURpwyR49lla6eiBckrA/Q8m3asZyuEVCkLfENa/wxT0bzepQ+CvYgzUxK+yAuu2jpd8p+jukAQxFY/jmdN7yEoYwfHfUmLObLo3bM/XcdJjqyMb2S+e tt6BjT87 qrOWghFpKXLGs7EKRKLQ/iuqd+HINDoD+DMrWE0/4Q8DzJoH6GZhpFWxQWu1guFDz1oq5+fqNEWUvM+Vjc5Pd4bpMnHJdX2RWUTO2x5EJACt16mXMaVMoDBQNEYouI6sFfmGQYrC2pkINrZMts0USgMhhgynls7/AKfOJSdCrN34yMMTQ/JGdMzs8YTJlUlueDrhUMKhEa53SeQj/2mkh2LToll4lbUCwpuvgfiCCJI2l54ryTe36+vwZ+IH3hdbp0+NP5USCC0T45xih9cx9/sZSLdPWKxRPb8tJtlvw9aZp+/J/BXH00EaV4oTAcOAC0xaQh7zHYW9cGclnSrkfYi0gSpYo5bO0pzUQ7CmpX30y8roEHDMUWcYUOrEWqBb+DgVz+DyFXWleENtnv3MPctNfD3lpKX3TPYff8beho9Zeyie6JoqHtxn8CqgRBJ7v4GzgzPyQn4j+UA9Obk1SSSiCywSolp7A4ysX4ZLADWwHAUsrsavpPci8qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.02.23 15:07, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > sh never initializes max_mapnr which is used by the generic > implementation of pfn_valid(). > > Initialize max_mapnr with set_max_mapnr() in sh::paging_init(). > > Reported-by: Guenter Roeck > Fixes: e5080a967785 ("mm, arch: add generic implementation of pfn_valid() for FLATMEM") > Signed-off-by: Mike Rapoport (IBM) > --- > arch/sh/mm/init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index 506784702430..bf1b54055316 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -301,6 +301,7 @@ void __init paging_init(void) > */ > max_low_pfn = max_pfn = memblock_end_of_DRAM() >> PAGE_SHIFT; > min_low_pfn = __MEMORY_START >> PAGE_SHIFT; > + set_max_mapnr(max_low_pfn - min_low_pfn); > > nodes_clear(node_online_map); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb