From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C00AC433EF for ; Sat, 14 May 2022 01:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E3706B0073; Fri, 13 May 2022 21:41:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5908F6B0075; Fri, 13 May 2022 21:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47FA96B0078; Fri, 13 May 2022 21:41:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 380236B0073 for ; Fri, 13 May 2022 21:41:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 03DDA20EC4 for ; Sat, 14 May 2022 01:41:38 +0000 (UTC) X-FDA: 79462646718.13.C3E6D5B Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by imf03.hostedemail.com (Postfix) with ESMTP id A4C3A200AB for ; Sat, 14 May 2022 01:41:28 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VD5SDVr_1652492488; Received: from 30.236.14.33(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VD5SDVr_1652492488) by smtp.aliyun-inc.com(127.0.0.1); Sat, 14 May 2022 09:41:29 +0800 Message-ID: <30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com> Date: Sat, 14 May 2022 09:42:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page To: Anshuman Khandual , catalin.marinas@arm.com, will@kernel.org Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, songmuchun@bytedance.com, willy@infradead.org, christophe.leroy@csgroup.eu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com> From: Baolin Wang In-Reply-To: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.56 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A4C3A200AB X-Stat-Signature: smanupmwtn3ae5gpdqptkw5iraoirmuo X-HE-Tag: 1652492488-127402 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/13/2022 6:50 PM, Anshuman Khandual wrote: > > > On 5/13/22 09:07, Baolin Wang wrote: >> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(), > > Right, as arm64 does not enable __HAVE_ARCH_HUGE_PTEP_GET. > >> which will not take into account any contig-PTEs dirty and access bits. > > As expected being operating on a single table entry. > >> Meanwhile we will implement a new ARM64-specific huge_ptep_get() >> interface in following patch, which will take into account any contig-PTEs >> dirty and access bits. To keep the same efficient logics to get the pte > > s/logics/logic Will fix. > >> value, change to use ptep_get() as a preparation. >> >> Signed-off-by: Baolin Wang >> Reviewed-by: Muchun Song > > LGTM > > Reviewed-by: Anshuman Khandual Thanks.