From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC3EC5B543 for ; Thu, 5 Jun 2025 10:44:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681776B0598; Thu, 5 Jun 2025 06:44:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 631D96B0599; Thu, 5 Jun 2025 06:44:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547A46B059A; Thu, 5 Jun 2025 06:44:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 382B56B0598 for ; Thu, 5 Jun 2025 06:44:06 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E435B1A0453 for ; Thu, 5 Jun 2025 10:44:05 +0000 (UTC) X-FDA: 83521012050.20.6757362 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf26.hostedemail.com (Postfix) with ESMTP id E13AB14000C for ; Thu, 5 Jun 2025 10:44:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lyR9dchs; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749120244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y+t2wiktu8oav5PiZk75RVzZOPx88NbHUYhuBSZZX8k=; b=YsBN5DRwDdSfmY5i7to7p/U/lkcTJ5YngpafWdEQ6xGVI63b3QfEdTAnr1L+wP4RpeLYlP xmct5Tu11WViXMYvJnVkSTSOmFAaYHlDV2GwWeSxeoanvO5SxCOvjPBC7uo9iuTNfV+D9W aAVsnlUnuk7BHdNj/PR5jHxYDpA1jDk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lyR9dchs; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749120244; a=rsa-sha256; cv=none; b=mXk16glFNk/p1GILp/iAM6QYdmdfAar6X7gCoQG/298FLPeS/l4LXVN06+YGLnS8GAtBOr xpBCQSfKg6xpRRiSWC2fspTyiicBJGUl++LvmnWL+DxLq2Vf42zjfayIugnRW0BG8Wl+6H PinliDdAOZH/7ui6dyfe20z8OvWrmpI= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-adb2bb25105so137689466b.0 for ; Thu, 05 Jun 2025 03:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749120242; x=1749725042; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y+t2wiktu8oav5PiZk75RVzZOPx88NbHUYhuBSZZX8k=; b=lyR9dchs1y4fxXI2EK5G86TzW8ozHNhNbghvvyQlqIKBa8zG9+KPPrJFmSrX4g0Xtg 5HIrnUxJqq3sstW/PlbUvSmW1663AvJhJ1FwcmVmKaOz5nMl0Lo+mNBT8H5D97WGAn16 ZV6Ifjv5JCsva3oBSNgpQV5Jd6E90/B6ZCXfnI77sABXDcSYEMd2Koa6LWKYTF9MfB6d zasM0E0AuaPGRzUtToc7U9POlbf1tpLblL0bocmw9IWE6X/DZspDKUF7GDWuUHCEPvMY gmqp86TWDDTZ+9Yrsjb+wyEjEdFQcWVVxtW7MMLe8IzAYcVtzJcJ7pY2uEkkqM9KJjpy HG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749120242; x=1749725042; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y+t2wiktu8oav5PiZk75RVzZOPx88NbHUYhuBSZZX8k=; b=K2ZoSBOc9lD+3OTtXriqGgxcYjqUNvBQcwKKG2/LeycQZr8U/WmRHommEE/OnHHtoV FMOeZwMr1kanvmsdyBRvTqd0xE62LLpAP+W1NIo1Zl6SGIJnV0CthZRsEQloFxm8k7a9 5z+mtofZ/yC17/1heyzMMpsjMGm+PFntUBUNMF/Ar71vkHiT7M9xfQB9Amx6ttzWd+Pn KjSL6AiYJ9MEMnAWyCyduG1O6IIUfySRu6h/kCmiDBoGBYr0mRA3ZcixrD9A+NLbcd0Q IGjyJ/8LIW1ZhypzeRN+j5Aqt3lB3iRra3WLTiODK1grPUMqBNnvhZOUvXqUnLxXjQDt RVCA== X-Forwarded-Encrypted: i=1; AJvYcCVuDUADFrBbDidylXYW52ZtxENC6bP1PAjj4Y1phdTaE+EnHs0ohSOIcS5xH5YyVIghgxZygcATMg==@kvack.org X-Gm-Message-State: AOJu0YxoFk0SywMVGXxt/z6uBwMe48TpqubxU4RwbYThHQlo2jbazOeZ j4hjvrajbqAOvd3cr3QW7OuwJom07kPYKUesNSCJpe15xnhat/oO6tGe X-Gm-Gg: ASbGnctXboPJzQn+VQNXSBrnextsvByXYnYzpqV7f8lQ6z2N0mztdvxOaWDGlOuHsmn f4gTpd6YJrF5MxVAYs48dsdVVT8WGNmrD/Nc2g2JeYK6dFcFPzWJYh1G8dW16pr5kXaxyyY7Hzz O2s4cO7HtmSKEYd0BV92l0XdF6TZh57TcvHYl4dLqWA2QgqlAdleia7Onyrlql4v7L2/1LvW4i3 CHRi3dsu9P+m/qtLj12NRk+WWZg5SZC9nY+4Vd63fSvHc7i+nU9mCl09pCzzXQAOGhKeYsf83M5 dNJYEYNKLHghPxZUvkRmhGtrKDKRQrxV1WjS7xh95DSexdkoGW5hwQ+wmav5Yx/n/PPgKTyvOWQ = X-Google-Smtp-Source: AGHT+IEnMT7KUgk1GoKIavHcGDuyVSsgBYtYpTLhKdHUW468TE4aLkLxghZM1WmYjvjcIB/15ct/4A== X-Received: by 2002:a17:907:7249:b0:ad5:e18:2141 with SMTP id a640c23a62f3a-addf8fe4640mr573586866b.53.1749120242177; Thu, 05 Jun 2025 03:44:02 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::22f? ([2620:10d:c092:600::1:d66f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada6ad6aa17sm1253730966b.175.2025.06.05.03.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 03:44:01 -0700 (PDT) Message-ID: <31224f51-1457-4a71-a5b4-880dfcbfa659@gmail.com> Date: Thu, 5 Jun 2025 11:45:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 14/18] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-15-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250604025246.61616-15-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E13AB14000C X-Stat-Signature: oripcs6yk3x1kbyjcpc8447p6y49zetr X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749120243-709236 X-HE-Meta: U2FsdGVkX18QUtbgii5pK5WOc8CVkCZ+A/8Qmuz20CpN108+6e32fE3YNIm6A4d3HU6qEHmUa9fIoo1Y5SJlScGy4HZMXDdbkcJ8I9yZLR/+lAS2WkIiuix+PkmZSQn6bWgRpIjGmH+vmG5YwR7QFix1LkTiCkTXkncvd1RVJPmPXe2VR5g/zFqfXs5nN+U0vRD4BK+Hwe9lAxxO3hfYnDWPXQCbp+jxDBDSLepzl1ZXShdV/uz0w3c+LVEgwAuNvMp/H1hR++NmdF6mSe7D3Cv7Y69B/mJYKXYmaoLw5gC3R5qFcd9jCwHvs+5W6XuuT59KaSYMYyf1K9ECN2ymk3P8fLgoGseS1mmokv+Qp8JpmI4rjRZye0IIJvX5j7EtaX3EebKBhJvuUj4oBT47ltHndyqM/Od7PPRojPfvvOSY5bNIdNlBlcdZCeo2KMMozYIIDVd0TbkhcCUOJz7oVmXbdjqnLO766F5nV0L9Di4Q+IeXzaokb1V6uWojk8694K4LBKfGephMY3aqBFBg+YHHhFfLtEeiamoqVtc5u7Ybls3tVSdi4mOyizOVlPiJtDwDsQpP7Th2OQk5tMgoN3u2+NecCXiAmwL0CkhAPLxt9PG1nYP0lVAqh9gRjx5D5KUm0TXZiXGuEpZTExU/ActopoXXyefyv0sS+PLB+qfwAxgCXOBArUTnwZ5jVbz0Ap9dOEKaXhpqOsPH8LsvTDDREcD7Tf/m4Z8mu9q9G2W079iZhazhHaPvoHLYVepvnBLGfjBJdU8T/hhWMxDnF6MA5OQWNDAXhoJ87rb+S7eWvZxigbLfdu0VHX9WHqkzg3PG2LOWAex4+4JurHNj7JbEosBy0kBylEd7NA4aAxc+LMJlXL3bmKtedtGrhTud4JqiaRpdi9SimezOT+F7+ZozrcK8BAxAE49uMZEWGcuYR3HbAdqWf4VsdWpeEIZ6JtN5ZcZc2qX/6+x6SCH 1gEOTn6K 5QDuV0s9bup7DbULd6O1MdTAMh4Fx+mt+NeB+moGiGaAmv8BHyn/6gilS5l+aqQkjf/igCFQwYUgER7MDRqWJaPWAFAneOU6mxQSsKtaoydONZtBV20Dgyv+c06qICWFpNIOFcxHagS2DjzS8vQsojLwNfPsMCCbMbLWnVyfGaOWFICPysm3JItrvmKZuUDZwzU+DyXzmyAbA0OM6yZqFTDNQXE0R3kaYB0Ry2GbDJy0xgEe8u8VVBTBfSkVvnzNcXmsSibCoLiGdj5/R+sHXcVOun0SgQv7R/pVtp2uiku9z6oXq8YraR9AXPZ8lvRtRUWxMPxqXjWJqB9olR9Ld3YXiVrQNMab8Y6SaiqIonb06NcYaqNxmftuYyJ04GduStR3l1vqvInLHgvWwdYKVbhZbD5AnkKmOuIKsb4jRcgM0hI99mPUiv95JWljUc9ZLwRxtevMFThqVdt6EOJCzMFiIytcxAOsQHf/PMjDvwIgeTFcUybbaBKswa60upCr5QDXxm3kwLtc/MoHz6OhTcK4YPfn6VUXsqNn251JTtjx2UrCYFNhEiqgE67tF7jjwACkfde8QIgKpJ2pHd15iHyM4HAZcIctou7jrntmqFB0yMmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/25 03:52, Byungchul Park wrote: > The page pool members in struct page cannot be removed unless it's not > allowed to access any of them via struct page. > > Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but > just wrap page_pool_get_dma_addr_netmem() safely. FWIW, it adds small extra cost to the function, but that should be fine Reviewed-by: Pavel Begunkov -- Pavel Begunkov