From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C49C4345F for ; Fri, 26 Apr 2024 17:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C36DB6B0093; Fri, 26 Apr 2024 13:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6E36B0096; Fri, 26 Apr 2024 13:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87E06B0098; Fri, 26 Apr 2024 13:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8B7976B0093 for ; Fri, 26 Apr 2024 13:36:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2C43A1A09F9 for ; Fri, 26 Apr 2024 17:36:42 +0000 (UTC) X-FDA: 82052387844.30.87F2FD3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 159154001E for ; Fri, 26 Apr 2024 17:36:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/aSISpZ"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714152997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4VuHb1gFmXIB/FeEfholHCYEuftXxlfe2solR5B5lW8=; b=ZBVf2Q4URkkRaj5wiYvrErYmu6aSCvtvD2KhwakTgQ7vmHZDTYWfoKgaYGrExXY5DzJ5G3 a3A1nsFsvPg8bP7+NuyZSrKOdEN+idCMMx+rUNgZDuhD+Niv77NQ7HjanmY/iLQG2cMNIp tif+oiNgnx/DmJmWb9PWi6krl4VXeZY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/aSISpZ"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714152997; a=rsa-sha256; cv=none; b=hTAnLgkv+gTuLxa3eq+uTzi0mxM/mOsTTzfXBzR8QrqkneNK2Y02u0t7bJxvCSOF6c7e6w fMtH/tlwI43v1vxuyAXHJP2LKr0RLw+YLIOJfXDcclRpPwYs/B5fZhYqDr2V6ho3NGOlgZ ZyzbQTlyp9csMoXsW2YHXyDbDfAVQuU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714152996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4VuHb1gFmXIB/FeEfholHCYEuftXxlfe2solR5B5lW8=; b=S/aSISpZDM4Atgur/WH1FR30OtqgxJ78E8YTProdC5dl05N5vrPp+JpbDmtJEHPaeVWWGT gtLyAaa7IfpNlgK+IG/oxkSyqGIpraULOjPS3ng1b8SaOe0vf995ImjYAswXV1nWGh3Rfo mkIvwRcfnPb4BdgA8MfTwHPkUzMmNWo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249--cp_ZTEUOWKmJFHWwYglmQ-1; Fri, 26 Apr 2024 13:36:34 -0400 X-MC-Unique: -cp_ZTEUOWKmJFHWwYglmQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-419f572bdbdso9786705e9.2 for ; Fri, 26 Apr 2024 10:36:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714152993; x=1714757793; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4VuHb1gFmXIB/FeEfholHCYEuftXxlfe2solR5B5lW8=; b=wwG+8r+rL4Rs/vDcYmJW4vDOCKN24xiLQEvQ6VDnvAgd48gbqH4QLlrz06cek7kPry XycDmQWTlhqKkqwHNSVO/dcuRn6+UKwkALzoSnQ1N2HKvxtqSpy/9xlt6m6khYElDL3n OeBn1QKEKxkb9uUXTQqSINuN3PiBMDoAatxN7H4LeM/0v2VtHIiQB/mAVe26cvd5GwOX hxKmjYGl2Gfn2dRFKpxhoQEHSsm5P11ADpIxPnaLomcqv43PKKGMPBCtlg3w5AVu3+Gd 8XcGCCr3hzARz42DLymG8op66xQHAJqHk7VpW89a9up6LZRiJaZHLpQ2ZKDUgI5zHYx+ loHA== X-Gm-Message-State: AOJu0Yy6jZI19EiIIG1+ZL42ZMxCyNEr1k5nRPQsdVZthvlrg7Jh9x4y l7Z5D1yThp6ubm2MAg9SRkRaGr/JRi2d4uoaq9/ikG3KJmo3/8MdnvkZ3HeBeIWofnyCB8vI12p C/5LLGwtLsDpBXJk5RT5Rg+OUv7af12zea3noHkYGVbtec7mi X-Received: by 2002:a05:600c:1394:b0:41a:8b39:8040 with SMTP id u20-20020a05600c139400b0041a8b398040mr2943865wmf.20.1714152993273; Fri, 26 Apr 2024 10:36:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNNgIDudDwqyvI6rxOrWgWJ8NW7tjiTOvzKJvhKOitiIk2dcvrJOLcFtFRjPACrfIlTFt9hA== X-Received: by 2002:a05:600c:1394:b0:41a:8b39:8040 with SMTP id u20-20020a05600c139400b0041a8b398040mr2943851wmf.20.1714152992848; Fri, 26 Apr 2024 10:36:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6100:20f2:6848:5b74:ca82? (p200300cbc726610020f268485b74ca82.dip0.t-ipconnect.de. [2003:cb:c726:6100:20f2:6848:5b74:ca82]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c1d8e00b0041bab13cd74sm1505014wms.17.2024.04.26.10.36.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 10:36:32 -0700 (PDT) Message-ID: <31813228-4d2e-45f5-98d3-10cae826130a@redhat.com> Date: Fri, 26 Apr 2024 19:36:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Optimise vmf_anon_prepare() for VMAs without an anon_vma To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Peter Xu , Jann Horn References: <20240426144506.1290619-1-willy@infradead.org> <20240426144506.1290619-5-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240426144506.1290619-5-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 159154001E X-Stat-Signature: ufrkjhsz8bp1mi4hwapggu8dnooigra5 X-Rspam-User: X-HE-Tag: 1714152996-589920 X-HE-Meta: U2FsdGVkX188WUYZi0ikLAJFVK8ZgNhvwpaEgcsxVFjFmXCc97Ctt4k22S9ZdQ9jVuzdL50tbYRMOJ3uqQ+x+L/hzqSHff274zMFV//42hYya02HoOvGrJ9/P/KCRu94lehgOLoMOgt+qzaL5kN+2iB1mqYAmoUi2Y3ETnmQzphfYc9bjeYLFlA9wo0eDTnCM70FL9oKHkTiwS8A5kTsVMw0a+jMS5FCaRQQHylxWMqnWYaw+VNrOD8dDKrzTlKXo7dKBEyKt/RPEOQOeCO6GnXJyjcM7s8HvGtyRJluNqq9+mg4nmisDWucJnmmw52YW+gwEo9RDfKxSX5TNxAhNBZ6l8alyxwTaAhp9Lip7ZGNuHWCkW7Mn0rN9l+9y0s6doksjulzVAykZPE1fQWewA2/IL2OTvUZYeYxYDPFVg64liVWAZRtwCSNEIr53HLwUfMArMSOleiamrnUgKo+OBLxMqCzifsCI85qIeS5cNyDl2YrKzDBqvxI7j5+9succkAgr8NNI5fYnofATnfKztN3avbSBQe2cqRGKTnzpmgjErHvEbRYukOJY82VCpacGnunwWZiokHrEXnOeLcfbKMjkRciuXV12RY9GGVOdpqsuaIKzXHKO70xlXDHq4u2hTqOr948YzqSx6WMgzWEm3jVjEUS0SWdogyTybWeo2/wD0+b34N/O4rTQkfZHVm3b/ri3F3T0NYqrZgVE5m/2le+yEJf7VZjWIjVMV5prSbq1czHkDSThTl7Wb++dAaEwnVopqcrNqZMPhS0AYLX3ROJ8OnP7Eo7PTp7loH91eLCTf5CVxYFiiZtXlLK4/6uUNzGUnrNclXGhzvOcXomxHmOgM8ITkIiS8QROGcEVtdjR3t/B9FYfCrTXDuWfeX+QKKWlRuSOIS6q2Le0IUHODXpxbVr3g6KOI/3ypsNVhxLRoJgABGNMt/ty20haOoFQeXqrSTl0EMTVTnc6w5 ew8UDMtM hMGqPEsnggjUbpyKjohpm/tsGxOk8BHgiik61Ig/lDq+21pJ+oAbw+FLaJkAIHgWJfIeYS7V3BuO9jyO0UoFM2zXA1ebnllx43JZNjc4zZLXzx7HIaLlw1QkuZ0i51Ukm3pAf6MDRpby3gmSpVPdw5l26xorBFMlocel9hsKktfknvRYveUBTtw/35BOx6wNK1AGcDUXRjgsoZ6zrgbKyUwuuku6pvRRsN/ltkCLLj689WOxWY9tOaT+8VrFaYoKy1M5Wh1pnj3b0mQPMht2/nDskiMM+FfyZZrUgpHb1VJKtREAR/Cna1wz2o//v1u0o5X7nAJkcUJ2CEvfe1ou0QYF6vfqD3d4qqaMmmjGgqpESkNPLRV1aIzQR2YpxXGwJSQMNZ1RbgZY2u4atvvd2T7FdN5ac+lJbp3WiUmUYHb127lTHXIr42/yPzOo6WXDMXyvA2UTfHN5kAmwPncLyRwsbntd+TOXqmkyiPhG+XPsRFoXYvREcw/mlyJTJud+DFRkxmd7dHSha9CjfpJFdkpOJSOt8q6PkSH8Kln4IANwMcV7gZXN0Re0BG56kGVX8gIrhNwcfdrV/mEXK5/IkOcu2V1ZelwlByaReE19l2hDSqLaJGUjUkule9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.04.24 16:45, Matthew Wilcox (Oracle) wrote: > If the mmap_lock can be taken for read, we can call __anon_vma_prepare() > while holding it, saving ourselves a trip back through the fault handler. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Jann Horn > Reviewed-by: Suren Baghdasaryan > --- > mm/memory.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 7dc112d3a7e4..b5453b86ec4b 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3232,16 +3232,21 @@ static inline vm_fault_t vmf_can_call_fault(const struct vm_fault *vmf) > vm_fault_t vmf_anon_prepare(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > + vm_fault_t ret = 0; > > if (likely(vma->anon_vma)) > return 0; > if (vmf->flags & FAULT_FLAG_VMA_LOCK) { > - vma_end_read(vma); > - return VM_FAULT_RETRY; > + if (!mmap_read_trylock(vma->vm_mm)) { > + vma_end_read(vma); > + return VM_FAULT_RETRY; > + } > } > if (__anon_vma_prepare(vma)) > - return VM_FAULT_OOM; > - return 0; > + ret = VM_FAULT_OOM; > + if (vmf->flags & FAULT_FLAG_VMA_LOCK) > + mmap_read_unlock(vma->vm_mm); > + return ret; > } > > /* Fancy Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb