From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F33C678D4 for ; Thu, 2 Mar 2023 09:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7B06B0074; Thu, 2 Mar 2023 04:41:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 977826B0075; Thu, 2 Mar 2023 04:41:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817486B0078; Thu, 2 Mar 2023 04:41:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6DD4E6B0074 for ; Thu, 2 Mar 2023 04:41:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1DB50160BD1 for ; Thu, 2 Mar 2023 09:41:19 +0000 (UTC) X-FDA: 80523465078.09.5E2B624 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 03F161C0009 for ; Thu, 2 Mar 2023 09:41:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMAzGAo7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677750077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Hjvoc1rI0mNChL06OP2EkJBsd0IDPnqcUCuNFEfHkQ=; b=DN5SZrEB6oG7mot4aXpOHlvUoomqwLIw3kU7XD7uPk/MR07MkU36xUBogmRux6Jo/hUJQk Bv2QWYVzWKJcFzrwbYVYhPLd+9Yyw/JVTtxX1bprv7OELie4dfBFu9yNFTOdoyvhXigbf0 JA/r7InRU0bb3xjAwHTYfE0sJeMHp80= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMAzGAo7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677750077; a=rsa-sha256; cv=none; b=LCXB+8dIt/pfoI8Fa99WY5q2LzcWrtYBl0rWNrMxNDVzbuhLdp5A4ZfQ1X0kXy4XDzcNtL zFCz8CHp90KaRvMAP7/SWGM7zOaCaf54mZG3RH/hzYGTgfbUoPFPewCo3t4rn7kFrSVM3d 8dsG3btvGly7HJSGmC8/aQdRWXy6+TY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677750076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Hjvoc1rI0mNChL06OP2EkJBsd0IDPnqcUCuNFEfHkQ=; b=NMAzGAo71lV/dMcMxturJ3umvWDxEM18Co8UMDJLEQgjrF4MOJ4MaBua0CBKiAJXt0D3sK ensIyho/+uwY40sDwqRgXLm0lC45SlI+u8/NSxNlbsW1RoFPKultz6WBO9MLiKAXOkIphw 4bPNoQKcWNd2pgFQoErzOYf/5lVNWmo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-NbSsX6irM-GYKqYteseTpQ-1; Thu, 02 Mar 2023 04:41:13 -0500 X-MC-Unique: NbSsX6irM-GYKqYteseTpQ-1 Received: by mail-wm1-f69.google.com with SMTP id t1-20020a7bc3c1000000b003dfe223de49so1010168wmj.5 for ; Thu, 02 Mar 2023 01:41:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Hjvoc1rI0mNChL06OP2EkJBsd0IDPnqcUCuNFEfHkQ=; b=7cC6TlgFFYv4tEvT3yzBofQBfi+hsiUNIWzKnVx+A5TpGMiwJKkxeQhH1gNnwGceDm kueM+YEsILo/mC26aeVP4y3W2Pz0Pj2cuUoIrUoxjZNVuNWIcfl5ft8m1GP+pR2DM5iF YY5OYJoiKlbw1wNuaFCBuRM5KcAzk9nR7MY/qWmoJ67J2DYHiC5RHTcrGLWY+T0wn7SS FfVcXOVkPNtUMeAxuVi3umI6qMUF/IIUNlVBT3RRWynj/6C2e1c4HjK7zsjab9TcVrve FESHHgQrBsVF/7YGaFcoLPrDbNUZKw6e8OEQZ2Rf78mV8OOEP3SWUGizqkZUDpeLBG3L 9dZg== X-Gm-Message-State: AO0yUKXZ24Mwfg72ROIrYvmWEk9wH4IrhsCackTDzkbJfGRZ+UAzOhEr JAGTIMIHlnKywV7xcQwvMCj+Rd7VDzziV47DEc6i3ZmmfvcG80LOXzwnys/HXYozQBRHv1wtU68 gUXjQFW6RRmM= X-Received: by 2002:a05:600c:3c81:b0:3df:fcbd:3159 with SMTP id bg1-20020a05600c3c8100b003dffcbd3159mr976022wmb.3.1677750072237; Thu, 02 Mar 2023 01:41:12 -0800 (PST) X-Google-Smtp-Source: AK7set+m2jCmZxrs/r4qdIoc1nGJTJq70PHpt6bJcgP4GAdRKd8i5kpDUdOX8h35tBt+ePXnjDguwA== X-Received: by 2002:a05:600c:3c81:b0:3df:fcbd:3159 with SMTP id bg1-20020a05600c3c8100b003dffcbd3159mr976010wmb.3.1677750071838; Thu, 02 Mar 2023 01:41:11 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:4f00:87ba:e9e9:3821:677b? (p200300cbc70e4f0087bae9e93821677b.dip0.t-ipconnect.de. [2003:cb:c70e:4f00:87ba:e9e9:3821:677b]) by smtp.gmail.com with ESMTPSA id d20-20020a1c7314000000b003eafc47eb09sm2127748wmb.43.2023.03.02.01.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 01:41:11 -0800 (PST) Message-ID: <31a88065-063a-727e-52fd-9fbc7d17fb5c@redhat.com> Date: Thu, 2 Mar 2023 10:41:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/1] mm/nommu: remove unnecessary VMA locking To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20230301190457.1498985-1-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230301190457.1498985-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 03F161C0009 X-Stat-Signature: e9dsieusex6hbbx3oxzk8hqturiuxchb X-HE-Tag: 1677750076-55745 X-HE-Meta: U2FsdGVkX1+Q1eAB09d+Yzlv/nQNSku3IV75dUq8V9XxUY8mgzXot2butYIIImCpsR5/lc68KxO7lKWNsaJb6FcBWajZYyQLIzl26pnu3IMAQHcIMxmx81r7UhIpGM7IJpgZpltzvo0qSyF2FvePfHl3TiDKHY3EIZQVamEWGkFxNaKDwaZByRaq0p6vOSpERGkBtl2SsMsKNJ1Ie2ogivEdit4hqrTjm94XWCq1fHGUnt7fVbhAe1lIVRfhUrT+ioWER/s6LQpIjVAZ8q3jmqDo7cQuST+/ArAhaogNK9ys8XT6IlUMenmxstgDNtp9tt4EyoN/FI+MhIZNXUb8p85blt/MUchjRoS1FUxPPbXBDxCPbxiCU08zNe7664uwPP2h/5E3CQmsLnwduObpdciayZtUiJVaDXpfLa25TSHZrWnM7pZrumzhdf1iiv/6aRd6dM+j1jYNAr6bWz8MwxbcVG91O0MkEyaRSKfVVSGMU/so+nA4FozWx9BfDKlUqeeA/2JheEEFdF0BrCpswhrfQJJXuED0RNRL62Z1BqRlcRRAkWn0C7aqgrxCyXHdNlQm9jo41gQGwzlSFDSMLVS1WrwFh4A5/ToBVYZmEFBhCgSGf/0aUj2eQ6YmN39CkqF4RGDOmkR/yd5yGxF38kIgDnscmj/z7MbojcRoxgHeuY8uLkE/rVEjOttXWEG04r75CNPHK0cBRZeAPVJsoobQ7kYnWEc1fBWZatcrSiuK5uYYkHTTds1cB4XcleVkwInyuXRNQhEo20EQAW2pvX1dfUoqLogl33+rcE78r0uuB++Kg99pPqf5Oepl6swoz3F9b6kaYm9Te9kmQ/KoHH4tKxPDR/JW86QWtLWCdC3ySdHn/kmXAJK/bkJ3vDIOY3WfRSu5QzSGwBVQ5/FFC/BFng/MFry22ZAXMm/20JQKeBQsZU+h1Eeeyw1jcA6MQfkrJ6SDGxpvW7oJmc0 fC3gtXoT XgjwvuB3IXN6XigQfCzISj2BhW/YpHse6RinafdeS1WoI1pMSxz0ivCNpXG1niqzEJY7KrP/poz1tj/rnLUWvvymw6NiZ8O77C5yl3mbwmgnqW+6AsvKqlh5Qn55OFxJ6yZ4tWmfS0ZKFZD8MXQZ0r60v4bNMEbeVwI1/9Imj3ZNXxFwEkmvd1EkVCocmaBRxQqNKFojBUZ/JrreOfye8ZO0ocLzIpIq1vAPODRFR1I7vxxk1jtzO2SmwUPH5X5qm7eJbeWDIcIDKEydIXOkJdXba8F9XpkjP4Z0nYAixYxVCv4TFHD/XN4yms2mKzXZ7v/XgiwfrYHWlxrV/uX0ZComkBUNE3oEgodeihUEzPGb15dcVwBRA404bsPbN210MHU1O+a5pepc3d3OQniptCfCMUgegYltwp0S56zHJsOL6Ea91vNDw6Qr2LGycYePanxjAX3CuptIks9lWJEtQONHPeu0JaFJOGeBqqUeedw0WZyHLh/fYiMvrHKbaqw7Oykxj2kR+Kphvz9Fe1RNOqkf6rTOwKIxsDFTx0wSK7hvCosr0K8GndDIwOLGW/PSrYgWg6Urg5QMfpIuxFYBHzTmQqiSFhUABxDC2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.03.23 20:04, Suren Baghdasaryan wrote: > Since CONFIG_PER_VMA_LOCK depends on CONFIG_MMU, the changes in nommu > are not needed. Remove them. > > Fixes: bad94decd6a4 ("mm: write-lock VMAs before removing them from VMA tree") > Reported-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Link: https://lore.kernel.org/all/Y%2F8CJQGNuMUTdLwP@localhost/ > Signed-off-by: Suren Baghdasaryan > --- > Fix cleanly applies over mm-unstable, SHA in "Fixes" is from that tree. > > mm/nommu.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 2ab162d773e2..57ba243c6a37 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -588,7 +588,6 @@ static int delete_vma_from_mm(struct vm_area_struct *vma) > current->pid); > return -ENOMEM; > } > - vma_start_write(vma); > cleanup_vma_from_mm(vma); > > /* remove from the MM's tree and list */ > @@ -1520,10 +1519,6 @@ void exit_mmap(struct mm_struct *mm) > */ > mmap_write_lock(mm); > for_each_vma(vmi, vma) { > - /* > - * No need to lock VMA because this is the only mm user and no > - * page fault handled can race with it. > - */ > cleanup_vma_from_mm(vma); > delete_vma(mm, vma); > cond_resched(); So, i assume this should be squashed. Reviewed-by: David Hildenbrand Just a general comment: usually, if review of the original series is still going on, it makes a lot more sense to raise such things in the original series so the author can fixup while things are still in mm-unstable. Once the series is in mm-stable, it's a different story. In that case, it is usually good to have the mail subjects be something like "[PATCH mm-stable 1/1] ...". -- Thanks, David / dhildenb