public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Ryan Roberts <ryan.roberts@arm.com>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>,
	Wei Yang <richard.weiyang@gmail.com>,
	akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
	Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, npache@redhat.com,
	dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
	Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm: use standard page table accessors
Date: Wed, 26 Nov 2025 10:19:09 +0000	[thread overview]
Message-ID: <323987c5-aecc-40c2-9837-9630186367b6@arm.com> (raw)
In-Reply-To: <506e7a41-a199-461e-91b1-035ebd5d5527@kernel.org>

+ Anshuman

On 26/11/2025 09:09, David Hildenbrand (Red Hat) wrote:
> On 11/26/25 07:47, Wei Yang wrote:
>> Use standard page table accessors i.e pxdp_get() to get the value of
>> pxdp.
>>
> 
> Isn't this covered by
> 
> https://lkml.kernel.org/r/20251113014656.2605447-1-samuel.holland@sifive.com
> 
> In particular
> 
> https://lkml.kernel.org/r/20251113014656.2605447-7-samuel.holland@sifive.com
> 
> ?

Ahh this is very interesting - I wasn't aware of this new attempt! We could
benefit from this on arm64 too.

We have some experience and opinions about this; I'll reply to the patch with
some details...

But as for this patch, I don't see the value in changing just a few instances.
I'd prefer to see it converted systematically, taking into consideration all the
complexities.

Thanks,
Ryan



  parent reply	other threads:[~2025-11-26 10:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26  6:47 [PATCH] mm: use standard page table accessors Wei Yang
2025-11-26  8:15 ` Christophe Leroy (CS GROUP)
2025-11-26 10:03   ` Wei Yang
2025-11-26 10:28     ` Christophe Leroy (CS GROUP)
2025-11-26 12:15       ` Wei Yang
2025-11-26  9:09 ` David Hildenbrand (Red Hat)
2025-11-26  9:42   ` Wei Yang
2025-11-26 10:19   ` Ryan Roberts [this message]
2025-11-26 11:32     ` Ryan Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=323987c5-aecc-40c2-9837-9630186367b6@arm.com \
    --to=ryan.roberts@arm.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=richard.weiyang@gmail.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox