From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80525C433EF for ; Fri, 3 Jun 2022 13:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 075D08D0002; Fri, 3 Jun 2022 09:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 023848D0001; Fri, 3 Jun 2022 09:04:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4EE58D0002; Fri, 3 Jun 2022 09:04:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D38138D0001 for ; Fri, 3 Jun 2022 09:04:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id A9A1861505 for ; Fri, 3 Jun 2022 13:04:36 +0000 (UTC) X-FDA: 79536943752.18.B1D95FF Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf14.hostedemail.com (Postfix) with ESMTP id 7A2E010004F for ; Fri, 3 Jun 2022 13:04:35 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id z17so4071745wmf.1 for ; Fri, 03 Jun 2022 06:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Xefno9BRMaznVjGWpJqFujzBMkdM7h0wTTai3ECWRnw=; b=DSGw+PQnD1zilwmt8UG6eTzMKU/KiULGYnvDBrk9sNsYbtG24Z5PJyRFmRQKDDVFRv JgVgL6yt5+ii1kPjHe8MdjYzvNOxzCkxJGnZ/8/ND5LADeQcHqwxG/aH2rNhEiVxlmG3 puB3M5aKburUFpm7XdPSf304z11btuh6vPQOrlmtBMXZUGaO8t2lY1YJC6zNK19HfQAV XOeQt11YIIs2MQBOeXl7c8WJ9fE9wc2RFPGjQw2BizqZyz2IoZCS6FJ4Cu1mAzx3P73g MXtyWvgLpNMxm0HTT2wwW3BgXOBOIEi1V+XG82LPalMIIS9zG+OWzD9/Q1WAwH635nS+ NvOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Xefno9BRMaznVjGWpJqFujzBMkdM7h0wTTai3ECWRnw=; b=wbv7CzUJYHYeCVz62xuveOXm4TaNv2hARb1LStTnTih0/z68ZMag9xy3lJVAFAm7Q7 OAQxsWlsT0AOYccyzqnWIzAX7OKINWzwudnLAGt+uprskSzIkRCR4WD2nbG24YGRjD+Z 5k4T6yDVgrWdfro+ARbY82JtfUK0dOFo5TMk7eThCxDFmK+N2khKXWsWwnJajznapw6y XKHcVlmzXPR4g69wxlIDU7P0jLAkQuFue6gYss0xmozxlEwqbWYftF+OLgTybbXI0/V4 4jYLyRYDgN2QSmjmllriDlUBvPO1WLPK0F6/HhGcLCP2A8xOoziZzmo5//7/RmK+5FKP nKIQ== X-Gm-Message-State: AOAM530sZPtmVfcUleSAMn74dhvQxVEv8oLysbx5YzgiPW8HS9SaKlP2 BRSjSFHVY3XkE7D5yz23wGxIuA== X-Google-Smtp-Source: ABdhPJyFiUIiXqa6BnyIIt8MXwIskAfhmGqYHLaz1nxTa+gqvCOZ9W8kKM3ThR27pu9THilhOOyoaw== X-Received: by 2002:a05:600c:35c1:b0:394:8621:a1d5 with SMTP id r1-20020a05600c35c100b003948621a1d5mr37855746wmq.196.1654261474422; Fri, 03 Jun 2022 06:04:34 -0700 (PDT) Received: from [10.40.36.78] ([193.52.24.5]) by smtp.gmail.com with ESMTPSA id h21-20020a05600c351500b003942a244f53sm11611241wmq.44.2022.06.03.06.04.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jun 2022 06:04:33 -0700 (PDT) Message-ID: <324b506e-ad35-797d-d7d7-cfc8bec26e8e@kernel.dk> Date: Fri, 3 Jun 2022 07:04:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 00/15] io-uring/xfs: support async buffered writes Content-Language: en-US To: Dave Chinner Cc: Stefan Roesch , io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org References: <20220601210141.3773402-1-shr@fb.com> <545ab14b-a95a-de2e-dbc6-f5688b09b47c@kernel.dk> <20220603024329.GI1098723@dread.disaster.area> From: Jens Axboe In-Reply-To: <20220603024329.GI1098723@dread.disaster.area> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=DSGw+PQn; dmarc=none; spf=pass (imf14.hostedemail.com: domain of axboe@kernel.dk designates 209.85.128.51 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7A2E010004F X-Stat-Signature: xy88t7yu69ayabzne473z91kpjsnus7t X-HE-Tag: 1654261475-973226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/2/22 8:43 PM, Dave Chinner wrote: > On Thu, Jun 02, 2022 at 02:09:00AM -0600, Jens Axboe wrote: >> On 6/1/22 3:01 PM, Stefan Roesch wrote: >>> This patch series adds support for async buffered writes when using both >>> xfs and io-uring. Currently io-uring only supports buffered writes in the >>> slow path, by processing them in the io workers. With this patch series it is >>> now possible to support buffered writes in the fast path. To be able to use >>> the fast path the required pages must be in the page cache, the required locks >>> in xfs can be granted immediately and no additional blocks need to be read >>> form disk. >> >> This series looks good to me now, but will need some slight rebasing >> since the 5.20 io_uring branch has split up the code a bit. Trivial to >> do though, I suspect it'll apply directly if we just change >> fs/io_uring.c to io_uring/rw.c instead. >> >> The bigger question is how to stage this, as it's touching a bit of fs, >> mm, and io_uring... > > What data integrity testing has this had? Has it been run through a > few billion fsx operations with w/ io_uring read/write enabled? I'll let Stefan expand on this, but just mention what I know - it has been fun via fio at least. Each of the performance tests were hour long each, and also specific test cases were written to test the boundary conditions of what pages of a range where in page cache, etc. Also with data verification. Don't know if fsx specifically has been used it. -- Jens Axboe