From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7BBC83F22 for ; Thu, 17 Jul 2025 09:22:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076FE6B00AC; Thu, 17 Jul 2025 05:22:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026A06B00AD; Thu, 17 Jul 2025 05:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E312A6B00AE; Thu, 17 Jul 2025 05:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C81C16B00AC for ; Thu, 17 Jul 2025 05:22:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 792B01104B5 for ; Thu, 17 Jul 2025 09:22:07 +0000 (UTC) X-FDA: 83673215094.06.27EC34F Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 5CD531A0005 for ; Thu, 17 Jul 2025 09:22:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RvADlRDa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752744124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i00DCL7LArMdrcvWGazqRQUXotNFwoxDDFzCPluiP0Y=; b=plQRJnC883PynzSwAcAKJZ9bXWkwF25VX8HFT4Y4ZYmEYtpGp8c5Dz5rZgKHsTz9cYH+5J dhkzH+iNAgrnZHxQ5+DjgKmB5JHh+7+SrzUOlwFyta6dX0Fv/f9VYXxmP47359MAvAYNjT WGTkl4TmG3u2k/na7EXK/Lr1Cc8S4+U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752744124; a=rsa-sha256; cv=none; b=qe4AxkvWwkHU+jaA8KcD9W8LWUm8/f4yEvD4z8NQvWvxXYmVAVBDxl9on+ZQY3lOfGJkEd TDUfSkXWiLC6kkhFyo2HXsqD8fFi/AXixYnAzfo6NJ+x8EdIgvhzEFR+GcOqAbPcgPPQzv +28XrECbUqqdT02sp9+MFMvNWKRmJm4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RvADlRDa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-60707b740a6so996637a12.0 for ; Thu, 17 Jul 2025 02:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752744123; x=1753348923; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=i00DCL7LArMdrcvWGazqRQUXotNFwoxDDFzCPluiP0Y=; b=RvADlRDaHH+04YrhdfAbC9VL76Rlq0xMuugkViItpo+4By5DmYpxTPEIIslndxxesy OSuvSNm94Awb3CrHo8kUr0C1TXaqLYqIubvmEaZmRNKPcjGVmb2lVPdaZznD8vSgLEQH UMC1Gyn/3fHbZpFVmx5xRokUfgP+y0VGxNd+0mL/jQvuQU0idngtBBR7kNvK+a78FAEc oSVk4KOVlcAr5RXir/Q4+wNL0+OzIWk4slYEoiG0OTx2jvAJEmn9R/hYf0/IetDW21wm YhZ1RUPHb9wB7sFYI3A0UZWRLYD7Q1qvznZgGK7w+JaGpMp6H66deLSYye7s4n++27qr GJAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752744123; x=1753348923; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i00DCL7LArMdrcvWGazqRQUXotNFwoxDDFzCPluiP0Y=; b=De+3JnxuKaCyIFsRDJnMF9ddTThmSdf8xIHQv5U+6rpn09yZ9rpj4AiwX3XfzSBkiU +gf/YiHERsSbsgnZUfGcxc1hcrEHiiVn7259mivkpa0fLMgF2sJCHGWOCPNTZFA7fME5 ocA+NypLMymmZ+gEb0uWn+/tdEmPX0nWPmI/XpejKJQgnvBQnMP3Hk1F+RRGOoh/4EDM Q1SgBDQCYwQoM2N4ke/4kbc+gRE+Xk1jqO0y4MdsbX0sOmHaABCo1J/Jb0RHO9qP0SRR IOjWGpCKq0Iwac7AdpqlpmzpD7UssOvrJtI14aBZb/YcsItwug8Q43Jg0lajdRVLkKhv fW7g== X-Forwarded-Encrypted: i=1; AJvYcCXwNSXziqL06bcLO3XoVfKoKuKcFOG5CkxqTqBiXUyBratfcSKHRaadvA3smDgn/adtd6nz9eN/2g==@kvack.org X-Gm-Message-State: AOJu0YwQYjaSGj3qM6qua9oLmRY620uy+YYp1iLCVzaUhJ4psoHUZcUe jOwL3icq+ozIk7vC1pWVkQZZIBqyQYL+Ku5JebYiBUYiwa4Xz4iXYwrQ X-Gm-Gg: ASbGncui4qFs9RurjW4F4JzvRW8H8JOV/Yr9D4VvvgGICNJSvmHRDdCI8L/OfcepTNV CtStNwShOccyYtDohrJziq1cPFQ1R4SBhnl5M3lCiM4cqnKIz7TsOqp5QsNjfY1mHKKvdF/WHsf U3qwHtvDItQFlB8BaQx1lU+RH7qUQjB/Tfakb+VnDEYNKVjvbQ+kIEWoSZxnmdTmOoTIHbUIDYc 0/MLaz0E485K1vnMQ+Jyf9qyKQvY9WFq3WSnoRvpJP2hkN4g57J4vmwz/X7PG/EtLR2n6+6S+ql h0pHhywT+EQLbyL1cf6hl3AiXdxwFXjVlwWrjADQ2KSEhQMBPMfLBgIPpj52cw+oHHSXs+gE3fS F0trW4XPEfYYXAK1Z81lnzQmc1CfXJUkLS7oDBf9ukNkgmQ== X-Google-Smtp-Source: AGHT+IEm/CZVfnHKhdEovv47xnxQCwkLFXlL7R6Fz8Q/9sjCF0i+Wwcn8Nmka6MicAHPOBghKdtX1Q== X-Received: by 2002:a17:907:3e9c:b0:ae3:c968:370 with SMTP id a640c23a62f3a-ae9ce1e8c11mr471633566b.59.1752744122539; Thu, 17 Jul 2025 02:22:02 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:72cc]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7eec2a0sm1338371766b.67.2025.07.17.02.21.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 02:22:01 -0700 (PDT) Message-ID: <325c6297-b47f-43ad-8d2f-276cf70f3d57@gmail.com> Date: Thu, 17 Jul 2025 10:23:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v10 02/12] netmem: use netmem_desc instead of page to access ->pp in __netmem_get_pp() From: Pavel Begunkov To: Mina Almasry , Byungchul Park , "Lobakin, Aleksander" Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, toke@redhat.com, david@redhat.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com, wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, bbhushan2@marvell.com, tariqt@nvidia.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, saeedm@nvidia.com, leon@kernel.org, mbloch@nvidia.com, danishanwar@ti.com, rogerq@kernel.org, nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, horms@kernel.org, m-malladi@ti.com, krzysztof.kozlowski@linaro.org, matthias.schiffer@ew.tq-group.com, robh@kernel.org, imx@lists.linux.dev, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20250714120047.35901-1-byungchul@sk.com> <20250714120047.35901-3-byungchul@sk.com> <20250715013626.GA49874@system.software.com> <20250716045124.GB12760@system.software.com> <6e4a4ae7-b84e-470d-81e9-a58ecf9c9157@gmail.com> Content-Language: en-US In-Reply-To: <6e4a4ae7-b84e-470d-81e9-a58ecf9c9157@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 1es9iypd1kxz8y6m6nsaegx4n7fkwsks X-Rspamd-Queue-Id: 5CD531A0005 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752744124-643533 X-HE-Meta: U2FsdGVkX18xt+BwY9xhDrXRN60pW2QXifyHf025R1UtE7fqTb/RQe7YwYUvRdsxsZlihCqXX788xR1aGrg/mu8UDmCwKTfw2d6JCGta7ONstv97tGJIHWRdkr1Il+sG2IesMKBXv5z9FtGVTEieZHMEYfYoT88vWHNAe/vpKG+lcXQG7a+Qg+HcnxYHfOfP3EvRniPb6FCoKpd+xGYfclBciVVGnqxARY7+QrOKW1ri4heVqjmmZsI0JwQxyfTiafxpbXos0BpcU0Chd5rvCQssExeGDG6DkSLR0wIEl4m7BqFcFWTDuDg7LAUKdoGhHoFWIKvRA4eo4i9UTCpRn8xuqhzgF7e0rJbtDc9EM4TD7zV1B2L4OW5UWBaAlSvJDC+eVogKnJwS9hZxFfc9gKYrZYmLh/EjaMa4ombsMmoc6s6/xUNN0SEsbQZp1X6bETk5CZO+R0reQ9yMqD1KZry70fhq8jXSfzdHRIOCpmjUDOdvpSmrsKQdRmYyo7Ta9l/0Be9m+l+XclVrfyX89aSov4W7F7PMiW/WO2SYunpGK9Q8Znan6fGj5vuGzBMYTr5YC52jk5jv5tOdPogONCTdP6OXHqsxxeg8GZG4NGGMn1x8glfPgvTOUb7QWWfanIWefcMhw5WoHHAr6RN3ROk16O1/eVxS8taMZFLMkrZWMhJLF0EPx81pmPWSUqaQX2Bu5EeSZY7POure81WPZ3ds9CfSEF5RGI5TAMG60SpkBtp08lstWw8zxGTBdgF0FvDeSry+/kieJvClfoZBxyKPwzh7s1+YBm4CEzzE39iyP/zTkgOxsP5Smpt7BlQZE7m/2/lW1VcCNPkM/gn1BO4XPDENLuTb6AeEnuaR75JgJjL5y3t1ayvF8Cg9x0B/Gig7l97lk/3D4CHb/f+TBFU+TO6QOKNmAZeF+bWazvh+JBCay+QXHlCVgnuQ1UZ2tIKn4WrrcWi1IaaBJem rzKzgjIF U2VX2lJ2vRRTBhY5K0gbEr4bAwaZSkHfDL6mTKTGm7vDNTF2xZUFUH+FklJ8DeX7SQPO+UN4qdJNTawDL+hmz93ayICUmXE/CeIsPN6GNgrsk/4CPt47wqJbJtB1KPuChCExeOPf6z9Mj9FU2oyQialnOaLxZXxcMsPQoGBf41oPx8Q+QdYnuiHok4+EJi4RDJOFlTIrVcdGSFv8UEio1yaiuHWsomFC45+mboL0h3QK0DXLwpWzAlbjbb94MvAQdwfhoXou+sAxP6G43ok7fLDhHg8yZ/Wv/GQr5fBi02mDqoYr6x84K7ZAxiM9C1FyYkeDt6O/JOTVl/QNX/nq8PTWE/YGLHKknazoHLVKEnTaQpPUHxvzlPLnmXvEBbA14lUWqZcF03F3+CGxSZZNfdoGL4hueTc/fYQhRV/pSsBOopRDH7j4mXFJxKMLokfU6LwG8pN8J/cZkBnEZziQcFxizakAb/Ljoy//LD7wcjpcAuxRDaGjcSXT9tM/rILRfL5T3ArZLzjn/pbmPINGW9jOxpqT+zSTEbOephIi5mppgVPugL/guerx1YHXC3st+spGjTGvbhWW8CoTz92Inkcq6MjXa5tQCsrq03iEOKyVwq6P4r68TemxEO5s5ra+eYekhI8Dg6r9onrTeq7JatXAuyoNcdeYjMF4b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/25 10:17, Pavel Begunkov wrote: > On 7/16/25 20:41, Mina Almasry wrote: > ...>> I will kill __netmem_get_pp() as you and I prefer.  However, >>> __netmem_get_pp() users e.i. libeth_xdp_return_va() and >>> libeth_xdp_tx_fill_buf() should be altered.  I will modify the code like: >>> >>> as is: __netmem_get_pp(netmem) >>> to be: __netmem_nmdesc(netmem)->pp >>> >>> Is it okay with you? >>> >> >> When Pavel and I were saying 'remove __netmem_get_pp', I think we >> meant to remove the entire concept of unsafe netmem -> page >> conversions. I think we both don't like them. From this perspective, >> __netmem_nmdesc(netmem)->pp is just as bad as __netmem_get_pp(netmem). > > Yes. It'd great to have all of them gone. IMHO it's much better > to let the caller do the casting so at least it's explicit and > assumptions are not hidden. E.g. instead of > > pp = __netmem_nmdesc(netmem)->pp; > > It'd be > > struct page *page = __netmem_to_page(netmem); > > page_to_nmdesc(page)->pp; > // or page_get_pp(page), or whatever the helper is > > That might be easier as well. FWIW, no need to respin a v12 for that -- Pavel Begunkov