From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFB9C5B549 for ; Wed, 4 Jun 2025 12:18:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F1D06B015F; Wed, 4 Jun 2025 08:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9CE6B0213; Wed, 4 Jun 2025 08:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DF166B0246; Wed, 4 Jun 2025 08:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 091736B015F for ; Wed, 4 Jun 2025 08:18:17 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A32E214134E for ; Wed, 4 Jun 2025 12:18:16 +0000 (UTC) X-FDA: 83517620592.30.0A770DE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf28.hostedemail.com (Postfix) with ESMTP id 0B6E7C000E for ; Wed, 4 Jun 2025 12:18:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RnFsKzpb; spf=none (imf28.hostedemail.com: domain of thomas.hellstrom@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=thomas.hellstrom@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749039494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JfaoRG57LFIS/dd8Kog1/eQFr8Bx0dcUrQuHslbLOmY=; b=u6lde3fUaKfm/fb0+wo5xXB3Un1CPfJoH8rSErcjr/KhKFyvaGWdFy/umWzMqCRFDvvD4J FM41QCh9HnLmjpJt3y4G0MUxvQjqBpjqBCH4xMcf4E1rPQCuMkuK8E5qauofzmjayDzGxJ iO2fWKl7+iHdsbXxeWJwO6onSxZQ9yE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RnFsKzpb; spf=none (imf28.hostedemail.com: domain of thomas.hellstrom@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=thomas.hellstrom@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749039494; a=rsa-sha256; cv=none; b=xX718iWi6zB0Xxvxj6t+UNINCVojya52zldiRM7eaB60xtO9te6Wqh75RvzJyHYi9Q0toU XKMvlZ+P9ahYhgYPQXKflyzYXUMcHuZOYjkvZkBuz6Wy4CjEFrkyE4OUjmelVvJT3pNteD 4BMk3w6c7R71qCulhFeLEI+XDbq19uU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749039494; x=1780575494; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=JfaoRG57LFIS/dd8Kog1/eQFr8Bx0dcUrQuHslbLOmY=; b=RnFsKzpbKJohUcvz3prwX3oeZ2xjFZrgDRLurwQDX9/Lvd/m7NxLCvRb 9CSOFjUWERbrTAn59lRz2ZBT8U4pfOKP4ev5xbvPYakkPBALglCfOuHtm IFCVDIgEyRnKMur09pW2UBvxc158xe9KGrbUBytdo+ACYWf1rDms91Q2w NrmsBoeP/+SP+2OwfyjUpGWl9vagYYE/sKcyJDT4k0sqIFISD8um+M02w 3sKa5x/TzfIOcFMPZRVcc1ZWtaW4MMZ4LRrrzrWSwdT9ZygHtyFrR/VP5 C5opfO1ziO2uaLNGdc8D1QexgZUw3/oD+u3xSfbXSMl7rQwXC+i8MU8aC w==; X-CSE-ConnectionGUID: WJUWR4vURVSUGFc6YHDyig== X-CSE-MsgGUID: gn6fF2aeTiGIHTig4VUbOA== X-IronPort-AV: E=McAfee;i="6800,10657,11454"; a="51188745" X-IronPort-AV: E=Sophos;i="6.16,209,1744095600"; d="scan'208";a="51188745" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 05:18:13 -0700 X-CSE-ConnectionGUID: vUOPYx5oQuixYIIMdrWXhg== X-CSE-MsgGUID: x63ZjyzkTBO+WtX82pS7Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,209,1744095600"; d="scan'208";a="182345818" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO [10.245.245.121]) ([10.245.245.121]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 05:18:09 -0700 Message-ID: <3262455c0ac3bff64522fff47c0281943c9f76ea.camel@linux.intel.com> Subject: Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Steven Rostedt , Hugh Dickins Cc: Linus Torvalds , Matthew Wilcox , LKML , linux-mm@kvack.org, Andrew Morton , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Date: Wed, 04 Jun 2025 14:18:06 +0200 In-Reply-To: <20250604080409.448a27e4@gandalf.local.home> References: <20250602170500.48713a2b@gandalf.local.home> <20250602171458.7ceabb1c@gandalf.local.home> <20250603102959.20c85adb@gandalf.local.home> <20250603132736.554f611d@gandalf.local.home> <20250603140632.168190f9@gandalf.local.home> <20250604080409.448a27e4@gandalf.local.home> Organization: Intel Sweden AB, Registration Number: 556189-6027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 0B6E7C000E X-Rspamd-Server: rspam09 X-Stat-Signature: b8erpg7unny5nfw79ykhgrb71p7hejpc X-HE-Tag: 1749039493-451428 X-HE-Meta: U2FsdGVkX1+MMh9vIoyUc1dAXCSL/KiQX9J6OMIvJcnK6olMeyPDYHEvJZ9wI5Tjdr7TwfGT2Lponxm7Yg6pzqumMI+kbJ9crRZo2XuQ8/KoeuSGH8AZaT1awqcn5XMCJU/C6NWjGSLpDOeBsIDSamGkReZtUSUhaHyhEAIoVgqP3XA2Dg8VsLEpcvsWtbzhCf5GvaAbTbjkr/2KyKTGi/AuMYhhuF0CXFX+APAj25dok2ICM8CTB6JsIkYlFbTsFyf6VM2FGyMkggCKByYQoewj1mzu87XvTPh/RRotiWgqdKuf56SNLe3v3EoPDA925FGfMe7Wrm+Xk4dI9f/fNtVTgKcoX0kRc2Mu+sfsHshA0NWhH+61SWiiQsbbl5ARPsHxLApHcDV8r4v+2ZJZtevNAt1k/XsXM8p2ouI/4ooPgBUt4yjzperzS13eKxI0wPL6z5ie8y5Bg53QbXSoJh7Ke/HKaC58Lo5QDYhbhoISja9mmdibZ3Zru/nguDfF+Y2s/5ZQznEVgq6pkrkXrlMCLuZDXtUE5hS/8Igk4VJfKeglDGs/A4LywEdSSWGDDuR91NYl7YZl3AUJAcgN2rsiPJjlXVZuWpGg29Xqwsz9qLg48V6uaIusJeNjvgLk++DU8rvsB9BokbHkYQJbKl1jEDofkBRRezmoR4y9SlgTrg9Y7dY/b69tBR6WvxQ2ORqkPauTtsyuDZhmiYdrbvJCNjhl774/0GJ6gWh3RlkarRy5gvU3Rup0Lr9aNNGem9QmfUMUElWXlkMq8to7bw4NrebW7AKvgCDKZ+Lx0AUYu8ELASFz+nAd04Suv/4FEAHes/r91rM1T17LoHTqd52Vk3XLa7cL2gcJllgI/GlMAjDqaQlI5Natvh/sxmVq9jOIFvjckoECoz2UWEvLT5D+JlG1uQ6BOb4voNcPUClQ5EMFbsTlu0vCbd0faOAVMK3eGHZEshhzHHmuu3e F2AY4OT9 p7DQYa7Cujw7ev4U2EUrhZCGh1Y44ucSYtz1F9B/8622jjblAq6o4lNMA1oDSE+eTtVfFTZqoaA0Urot9qFE8Vb0JjHLMboRvLoNgpXBkFkJ4BnrFhFBmFiKqM7djaIaNsMC+gLgsmZ1MTyJHC3Kvjy3o4ILji2BwxbpyUSmdu1C+q8GEx1uqCEtEKqX+qLtr4oXlahja76lp2VxZK1n7A3pLnVk1zxrhpRsK+sYt4CwzXMgSEVcvtPVEAc/U5f4LjVHEi8ZZNfPZsDqnNGfJBpkFRO3W6f1kkuXHYe0jcX74WTvERI8azxJIyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-06-04 at 08:04 -0400, Steven Rostedt wrote: > On Wed, 4 Jun 2025 00:03:18 -0700 (PDT) > Hugh Dickins wrote: >=20 > > I vote for the "select SHMEM", but Thomas and dri-devel and Linus > > should decide. >=20 > I only tried "depends on SHMEM" which did not work, but it looks like > "select SHMEM" should. I agree. The whole ttm_backup implementation is based on backing things up to shmem objects so IMO it perfectly makes sense to "select SHMEM". Let me know if you want me to send a patch for that. In the very unlikely case someone would ever want a config without SHMEM but with TTM, they'd have to live without the ttm_backup and we'd create a separate config for that. /Thomas >=20 > I prefer this solution too. >=20 > Thanks, >=20 > -- Steve