From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47BBC433FE for ; Wed, 30 Mar 2022 06:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5799E8D0002; Wed, 30 Mar 2022 02:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5023D8D0001; Wed, 30 Mar 2022 02:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 354CD8D0002; Wed, 30 Mar 2022 02:58:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 211EF8D0001 for ; Wed, 30 Mar 2022 02:58:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C5A0DA5BE5 for ; Wed, 30 Mar 2022 06:58:39 +0000 (UTC) X-FDA: 79300149558.16.E438C7C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 54E62A0003 for ; Wed, 30 Mar 2022 06:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648623518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BF9Fr3Hf2Q3seTfZG5uyvCg9ZVloRlsxZukD5j+fS4A=; b=LILja68p93ujgunKcSzMgpDX3ug346qSFD0y+glc5bTbCCYMTwUZxkPKwSQ21xBsZDcg/0 UVJ6edyNVKNbFwOqdDGWq2faDq4mEnY/Lv259GNDI/5bgN9JNPfOM0DtyZUM068QEyx3fn Cyz34CPWzWlJKK/4SOSWh6AKkI7+Zk0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-9FcBiJbsPOuCbBIN-eAHfA-1; Wed, 30 Mar 2022 02:58:37 -0400 X-MC-Unique: 9FcBiJbsPOuCbBIN-eAHfA-1 Received: by mail-wr1-f71.google.com with SMTP id h11-20020a5d430b000000b001f01a35a86fso5578729wrq.4 for ; Tue, 29 Mar 2022 23:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BF9Fr3Hf2Q3seTfZG5uyvCg9ZVloRlsxZukD5j+fS4A=; b=r8sO/It9mOzvBcvhU7IiZuS7DpMl2X+pDksHkKvoV5btS8ZfGWLQpnGqgJQ+aNrAAs yVcsEOGbDbutS/epLbNcuIWNKbxwq9526yFF2ms4Fteji2e55pqzIbzILzHAPfy4zjqE SWAXVW3O+paZDfUWdLLvibSz3fL46NxGkhATDKOdXsTYINkDRLBULkwi32D6aoKfgB+H +t41G0imj1/vf1bB1cl6jWhGR2uPy28gPLxHazZbTonAmaDi9T3KqEWZpvfd+2PbyzcV 98N8tj+Yv/pOKLo1gp8zqx/2IisvKhL5nBrlISaGO6mkp7dNWy8muSrwJgqtnIn/7mtZ 4w0A== X-Gm-Message-State: AOAM530ny1bKqSaUHXfYz2h0T2bnQX5vA1vjGF4F2GQIJlkMN8EpuC3n c+1bAdpp05VjXB4lxj4bct751bNAbaBAP0mShgwi4PpGvz1OMdtXBcfHOXTRDcYpQl0d8eT+o9O 24SiUy+Rim0Y= X-Received: by 2002:adf:f943:0:b0:203:e832:129 with SMTP id q3-20020adff943000000b00203e8320129mr34761284wrr.626.1648623515918; Tue, 29 Mar 2022 23:58:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtto01FveovjFViTUCxDqiAQ+5FDv0R1GlHAedwP32FH88iQTdtwzmDfuXuu4j6BvJ3hJeZg== X-Received: by 2002:adf:f943:0:b0:203:e832:129 with SMTP id q3-20020adff943000000b00203e8320129mr34761230wrr.626.1648623515578; Tue, 29 Mar 2022 23:58:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2200:178b:7244:2a1f:b5d8? (p200300cbc7052200178b72442a1fb5d8.dip0.t-ipconnect.de. [2003:cb:c705:2200:178b:7244:2a1f:b5d8]) by smtp.gmail.com with ESMTPSA id r65-20020a1c4444000000b0038c48dd23b9sm6003935wma.5.2022.03.29.23.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 23:58:35 -0700 (PDT) Message-ID: <3272510e-ff5c-8694-c45c-7be9eaed4b42@redhat.com> Date: Wed, 30 Mar 2022 08:58:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 7/8] powerpc/pgtable: remove _PAGE_BIT_SWAP_TYPE for book3s To: Christophe Leroy , "linux-kernel@vger.kernel.org" Cc: "x86@kernel.org" , Jan Kara , Catalin Marinas , Yang Shi , Dave Hansen , Peter Xu , Michal Hocko , "linux-mm@kvack.org" , Donald Dutile , Liang Zhang , Borislav Petkov , Alexander Gordeev , Will Deacon , Christoph Hellwig , Paul Mackerras , Andrea Arcangeli , "linux-s390@vger.kernel.org" , Vasily Gorbik , Rik van Riel , Hugh Dickins , Matthew Wilcox , Mike Rapoport , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" , Jason Gunthorpe , David Rientjes , Gerald Schaefer , Pedro Gomes , Jann Horn , John Hubbard , Heiko Carstens , Shakeel Butt , Thomas Gleixner , Vlastimil Babka , Oded Gabbay , "linuxppc-dev@lists.ozlabs.org" , Oleg Nesterov , Nadav Amit , Andrew Morton , Linus Torvalds , Roman Gushchin , "Kirill A . Shutemov" , Mike Kravetz References: <20220329164329.208407-1-david@redhat.com> <20220329164329.208407-8-david@redhat.com> <22d3c42d-402f-8aeb-e989-c05d023b2ed3@csgroup.eu> From: David Hildenbrand Organization: Red Hat In-Reply-To: <22d3c42d-402f-8aeb-e989-c05d023b2ed3@csgroup.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 X-Rspam-User: X-Stat-Signature: h5kzjhcu1biyaoimw1qn78y4z3nwp1p6 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LILja68p; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 54E62A0003 X-HE-Tag: 1648623519-918469 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.03.22 08:07, Christophe Leroy wrote: >=20 >=20 > Le 29/03/2022 =C3=A0 18:43, David Hildenbrand a =C3=A9crit=C2=A0: >> The swap type is simply stored in bits 0x1f of the swap pte. Let's >> simplify by just getting rid of _PAGE_BIT_SWAP_TYPE. It's not like tha= t >> we can simply change it: _PAGE_SWP_SOFT_DIRTY would suddenly fall into >> _RPAGE_RSV1, which isn't possible and would make the >> BUILD_BUG_ON(_PAGE_HPTEFLAGS & _PAGE_SWP_SOFT_DIRTY) angry. >> >> While at it, make it clearer which bit we're actually using for >> _PAGE_SWP_SOFT_DIRTY by just using the proper define and introduce and >> use SWP_TYPE_MASK. >> >> Signed-off-by: David Hildenbrand >> --- >> arch/powerpc/include/asm/book3s/64/pgtable.h | 12 +++++------- >=20 > Why only BOOK3S ? Why not BOOK3E as well ? Hi Cristophe, I'm focusing on the most relevant enterprise architectures for now. I don't have the capacity to convert each and every architecture at this point (especially, I don't to waste my time in case this doesn't get merged, and book3e didn't look straight forward to me). Once this series hits upstream, I can look into other architectures -- and I'll be happy if other people jump in that have more familiarity with the architecture-specific swp pte layouts. Thanks --=20 Thanks, David / dhildenb