From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010DEC83F1B for ; Fri, 11 Jul 2025 19:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86A1A6B0098; Fri, 11 Jul 2025 15:22:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840686B009C; Fri, 11 Jul 2025 15:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77D136B009D; Fri, 11 Jul 2025 15:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 611456B0098 for ; Fri, 11 Jul 2025 15:22:07 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 69D685A41B for ; Fri, 11 Jul 2025 19:22:06 +0000 (UTC) X-FDA: 83652954252.26.C295611 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf21.hostedemail.com (Postfix) with ESMTP id C450F1C0009 for ; Fri, 11 Jul 2025 19:22:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lcx+bn6N; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752261724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1kpsaSG3yQHxnE3KhywpzjrmaxDbT7HL8ur2ohsCViI=; b=hWGDvG4yCarn5kkzaR+2r5pUYp3C3gsXLliTyglcDzhWNy1btwa+EhLFGjYUzK8FUiwKoE jyM13qkfYHCsIUPgFSvA1KfbOg+J4lbDskfIhT7NdFQ8lKlZ44m4ApqHvdgB+tzCO97YBN uzm+5xvwrd0MNJbTY7ldyt+NxqwY1zE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752261724; a=rsa-sha256; cv=none; b=bnNVhBf72bO7GifjEsotHyhpHgI/8ewAkLVtZFYvjkznOJLMV94O+fUk9kpc1PUxCC8Azo bnTCaUwxWIkbBTte+GwST7rogrEgA68+4W5m1+qNe+hRCgdzeJF1vhLV0KJU4V+oqAo0+1 O8k1iNrvF7KkfAa//Q0vY0WES2R3+7o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lcx+bn6N; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D35B761425; Fri, 11 Jul 2025 19:22:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9CE8C4CEED; Fri, 11 Jul 2025 19:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752261723; bh=BOzxv2tpSJT1JDhpZa5c0Me9/LPODOuGi4cZnOgJor0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lcx+bn6N6lEfc5XZg1fzBx7VADUil0DXHy4s50tvVqrmGMGsSjIqo3M6L0bQa5XV/ xFvGVOs/pI75K+xJRWPBWiKcI5X6WOkKVYtbt4XFDipL7rn+4pGvzY7D9vTXduoEUO l1CjS73Z08hNsPgX2bg7u7/KlQoIFpoo43z18BXhUPq6kpWh6c6XPZvqlZw24yZZt9 n7GBIwADblBRgFsSd11cUfIZ3Yo2BYgoMCNffUzHA4Wik3eOfN0Mpocku64I1r6aVp d+OlOxmxb/tQjZF8fuGC3gfzURmi50bodPAMIjqUGvb+FHWBIxqSaDSg0brLrhzD+t VDKPVHwjVAeDw== Date: Fri, 11 Jul 2025 21:21:56 +0200 From: Alejandro Colomar To: David Laight Cc: Linus Torvalds , linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: Re: [RFC v5 6/7] sprintf: Add [v]sprintf_array() Message-ID: <327bas45h6nu7jsrod2qnekijq4xrztddzb4wbl7avkquwvwrs@xpwtrozq5o6z> References: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> <20250711184343.5eabd457@pumpkin> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c5hzqt4435udh3dp" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: f6p1pry7myf5jekhqqggsxnksbx4gyg9 X-Rspamd-Queue-Id: C450F1C0009 X-Rspamd-Server: rspam02 X-HE-Tag: 1752261724-299889 X-HE-Meta: U2FsdGVkX1+JywG75BnrxOr74oiyGukSBN1qfB0qXFTkM7uwhZ3s76wrmKwzpUsxf3PFqzzb9nS1ThvaB+j5RsUVw7IDjVbpELX8/oWrdLy/LhHypjPiVXvSYwkOPXFzAU1BfToy7BWSknBhaYiIKNrEYma6g31IGd379/nVXoy8lVWLzLMdO0Ucq1aQm7ifhsisZQSEp8PwuP291GPtQrkcdKQZPSJWgUAvL18yDyDiMCOusZ1v6oSMPpixLjV4nIAavwDvTUeeHO/m9oOdsyTq6OFyO3LD0ftseIa/PxZGlS1VhN6V2+KwF/SqFYA/puKgGLpTEp7BLQc3JrgLXnDmObJsXgqGtakPHSrYbYVOJPvzRzPVi7L5oORXlO/W/i34iSo/vAGAxNmxBnTZuxzFF+DM34wBrBAbh/bpABhRm5BOdODW23zoqoDrPc+ECZagiDrXXJJkeFDQvZSoajSb/+luzajL0rm0kIBF/bbJtAU6R6ZyMQ33/11NfJm9e2b95yCaskqqwi86H3RGUT1dZG9kG/BO1u4WTfNUiDJOR1nfs7skJ7TyDf9WK1aIIET2oDgvV9DfaTCJgNyaK6au8N5QAgtQvQv8A1eF9EDH/NaAvwsE5p5Kh/RfHNQKXpfpryRKvbaIS55hiV/an4A2/EPYqYVkpza2TfjS2V8nHOkr54GPEyka8LLY95/HQF+ErMPNVh/676/RkQUGkU7NCPp/ruXZCkFtsyw7batkAU4LBFBK+K/R3l9wfBZao5z6KOIh8mKT978GUAPAfYr9D14kkFrI/qgTfl7iPGc1tqy2jUsXpq+v8822+rZDCYccEiKP8KmIOTA1PXuaxTFUJoZDh42teD7m8FFch/DdnCYfVAP7JPZaTuM7AuPL4vfA/3k+RhTaa/nLnFrxk0TijTw7fAnB+r7d4zDOKPh1QLiYVCwpn1NZM/hwZoe7LnIc5Man9Aalr21CSM5 7+M6liin h7tGTRoAvOVshn4dPbGBsPIYSLpYfsK2/iH2i8gqhNiQ2jyQ4q8zre4MQF/lbu/kaQzq3UmvP1+83RyAXkAKpxFPAJ9ll0jrqGcrlNK7qxkTRxKbn5dWBy08Xx4ue3jZpQhP6D0wql7u0ff1Omz6rV5ftdnILS9AV2GxbGK/P3NLVdU2f99yQ4u5+m5ycPE8nAgklu294SbqMS2fpCut2o7Ym1PABg7nGlIAt7xivbL44hncW3nnccS9KxDs4GyLpTX4t5/2Rs6Y/hfIyFQODWonrG3XEkVc6VXXG65R8JOPPgkJZjAUE5ZhrFJAO/S3Ud+inl/OPf2LxncWpeVYx1Qn+SicDXeBx6Sa5OR/Ukx4X6YBttk4/TzBjAxpgblADf8rElc1SAdcvxB5ZZxdpcEmMkH8s2l+xPqg9uxsfN2RRNxsLhGQTeGRXBXPFQgMrDUPhyzxXsB5bLqzOd8k87m5cyIu/IykxbIvRlEBgyBbP0WJLxRxm4KyWoE/9JPS6XO2y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --c5hzqt4435udh3dp Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: David Laight Cc: Linus Torvalds , linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: Re: [RFC v5 6/7] sprintf: Add [v]sprintf_array() References: <04c1e026a67f1609167e834471d0f2fe977d9cb0.1752182685.git.alx@kernel.org> <20250711184343.5eabd457@pumpkin> MIME-Version: 1.0 In-Reply-To: On Fri, Jul 11, 2025 at 09:17:28PM +0200, Alejandro Colomar wrote: > Hi David, >=20 > On Fri, Jul 11, 2025 at 06:43:43PM +0100, David Laight wrote: > > On Fri, 11 Jul 2025 01:23:49 +0200 > > Alejandro Colomar wrote: > >=20 > > > Hi Linus, > > >=20 > > > [I'll reply to both of your emails at once] > > >=20 > > > On Thu, Jul 10, 2025 at 02:58:24PM -0700, Linus Torvalds wrote: > > > > You took my suggestion, and then you messed it up. > > > >=20 > > > > Your version of sprintf_array() is broken. It evaluates 'a' twice. > > > > Because unlike ARRAY_SIZE(), your broken ENDOF() macro evaluates the > > > > argument. =20 > > >=20 > > > An array has no issue being evaluated twice (unless it's a VLA). On = the > > > other hand, I agree it's better to not do that in the first place. > > > My bad for forgetting about it. Sorry. > >=20 > > Or a function that returns an array... >=20 > Actually, I was forgetting that the array could be gotten from a pointer > to array: >=20 > int (*ap)[42] =3D ...; >=20 > ENDOF(ap++); // Evaluates ap++ D'oh! That should have been ENDOF(*ap++). > Anyway, fixed in v6. >=20 >=20 > Cheers, > Alex >=20 > --=20 > --=20 --c5hzqt4435udh3dp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmhxZFQACgkQ64mZXMKQ wqnkGBAAjriK3UgFz2uAsA2nQ5DSYgg16hTsoy9M6VaKntUP8JFaRNe4TB4xm5UA /BrfAEO0CKqsO3bz9YLPzmvUlTTwoCDA05ywKnX19tG+DW5Ir0Dar9yqjqid5i8T GuC7z6Y7xujsmcqTBb/6xu7o9g7Ac6dMrRdfSBDlWuIhRtczjpJTzazu6+ONmcdM twvcEs4qftRs5JNls9bfCQfrkemdDR4SKNEQdlwk6tRRBnQgEMUlqfxMxuXNelvX FmKgytE3bSPjRiZRi3zLIBcs7n3XgLMCdzF8UGIbtVq724Gr2CQ7sr/apwbrjGbp Nj16mXhdDg5kroRpnOnQ0rT5nP7PzXpcK1IeAlUCozPilCrZ9K0esN7COdzdJBEx 03r9f22R0Z4PXCbwMmQ12gCbNbMzFiLH5urJe1N14vBGHdx5TihXP0PuUlmKNm4e yaCqb2qwCQKvInTgogO9xnhU5DwPAso8h6gBAidNmUYW5nLL1EHoHWexH0rYC0BB 44yFitPtS7ig1l6XY9I4bIewN7WI6YKLz7ywe57y1cbC5uiTcRXY8U3K/dNmztHn OW60sRMFBdaKWAYfSUMHMIvQwGNPp9LZGrDMLZYsSr4mg7A2/ZjXOevL8MK9AhrL 2oWZjrjrAa+ZT3srhAcQwpZUYRoonAVTgzi6rHWaUa/Vnm1MrTM= =OO/t -----END PGP SIGNATURE----- --c5hzqt4435udh3dp--