From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Harry Yoo <harry@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, Pedro Falcato <pfalcato@suse.de>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 1/8] mm/slab: Mark the kmem_buckets_create() context as a Context: section
Date: Mon, 12 Oct 2026 18:55:46 +0200 [thread overview]
Message-ID: <32d71681-157c-4d86-a019-e08357ce6352@kernel.org> (raw)
In-Reply-To: <20261006092035.166776-1-kees@kernel.org>
On 10/6/26 11:20, Kees Cook wrote:
> kmem_buckets_create() had the same sentence about calling context as
> kmem_cache_create(), but lacked the "Context:" prefix, so kernel-doc
> rendered in the body instead of as a "context" section.
>
> Give it the missing prefix. Additionally fix the "a interrupt" typo
> __kmem_cache_create_args() had.
>
> Fixes: b32801d1255be ("mm/slab: Introduce kmem_buckets_create() and family")
> Assisted-by: LLM
> Reviewed-by: Harry Yoo (Meta) <harry@kernel.org>
> Acked-by: Pedro Falcato <pfalcato@suse.de>
> Reviewed-by: Hao Li <hao.li@linux.dev>
> Signed-off-by: Kees Cook <kees@kernel.org>
Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> mm/slab_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index b19ba1b31484..270408ce5a9d 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -311,7 +311,7 @@ __kmem_cache_alias(const char *name, unsigned int size, slab_flags_t flags,
> * &SLAB_TYPESAFE_BY_RCU - Slab page (not individual objects) freeing delayed
> * by a grace period - see the full description before using.
> *
> - * Context: Cannot be called within a interrupt, but can be interrupted.
> + * Context: Cannot be called within an interrupt, but can be interrupted.
> *
> * Return: a pointer to the cache on success, NULL on failure.
> */
> @@ -422,7 +422,7 @@ static struct kmem_cache *kmem_buckets_cache __ro_after_init;
> * to/from userspace.
> * @ctor: A constructor for the objects, run when new allocations are made.
> *
> - * Cannot be called within an interrupt, but can be interrupted.
> + * Context: Cannot be called within an interrupt, but can be interrupted.
> *
> * Return: a pointer to the cache on success, NULL on failure. When
> * CONFIG_SLAB_BUCKETS is not enabled, ZERO_SIZE_PTR is returned, and
next prev parent reply other threads:[~2026-10-12 16:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 9:20 [PATCH net-next v6 0/8] net: skb: isolate skb data area allocations into a separate bucket Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 1/8] mm/slab: Mark the kmem_buckets_create() context as a Context: section Kees Cook
2026-10-12 16:55 ` Vlastimil Babka (SUSE) [this message]
2026-10-06 9:20 ` [PATCH net-next v6 2/8] ipc, msg: Account msg_msg allocations with GFP_KERNEL_ACCOUNT again Kees Cook
2026-10-09 14:22 ` Harry Yoo
2026-10-09 19:39 ` Harry Yoo
2026-10-10 3:18 ` Kees Cook
2026-10-12 21:05 ` Harry Yoo
2026-10-12 21:19 ` Vlastimil Babka (SUSE)
2026-10-13 8:52 ` Kees Cook
2026-10-13 9:48 ` Vlastimil Babka (SUSE)
2026-10-10 3:14 ` Kees Cook
2026-10-10 22:37 ` Andrew Morton
2026-10-12 16:46 ` Vlastimil Babka (SUSE)
2026-10-13 3:40 ` Kees Cook
2026-10-12 17:55 ` Vlastimil Babka (SUSE)
2026-10-12 21:03 ` Vlastimil Babka (SUSE)
2026-10-13 3:46 ` Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 3/8] mm/slab: Drop the ctor and flags arguments from kmem_buckets_create() Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 4/8] mm/slab: Give bucket caches the alignment of the caches they mirror Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 5/8] mm/slab: Add kmem_buckets_destroy() Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 6/8] mm/slab: Add tests for the existing kmem_buckets behaviour Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 7/8] mm/slab: Provide kmalloc type fallback for bucket allocations Kees Cook
2026-10-06 9:20 ` [PATCH net-next v6 8/8] net: skb: isolate skb data area allocations into a separate bucket Kees Cook
2026-10-08 21:25 ` [PATCH net-next v6 0/8] " Harry Yoo
2026-10-09 6:36 ` Kees Cook
2026-10-09 7:02 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32d71681-157c-4d86-a019-e08357ce6352@kernel.org \
--to=vbabka@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pfalcato@suse.de \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox