From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DB7C6FA8E for ; Thu, 2 Mar 2023 10:47:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 797B56B0074; Thu, 2 Mar 2023 05:47:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 720DA6B0075; Thu, 2 Mar 2023 05:47:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599CB6B0078; Thu, 2 Mar 2023 05:47:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 43D726B0074 for ; Thu, 2 Mar 2023 05:47:42 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1853AA0A51 for ; Thu, 2 Mar 2023 10:47:42 +0000 (UTC) X-FDA: 80523632364.25.4958CCF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id D8BA320019 for ; Thu, 2 Mar 2023 10:47:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TL7wKq/9"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677754059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5S8M7VFiIrjWBjAA3FzviIVL8rgISq30wNe4WT8BzAg=; b=ocIrVz9tzFCo+qi0IAGctDeZqmXXc79/HTffnsT1t3llAaTWtzvV+owByqGm3B/tlevEKt GcoKOiO255ZaJNllTbQkEDU1uCNPWiy8HlhvdV+bYEQqFhBBmXs/rDtSCvMRXYVzU1a2Nq hvtIv4tT31vBG1M5druPEWoPvgpU0R0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TL7wKq/9"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677754059; a=rsa-sha256; cv=none; b=Rdifpugh1P0+ueFfqqL1wrojja8JjSrpFonlKYFX8F6gndgYHpjqi8d1UerY5Dfd3KMHjt Uop+R0W7HnhiV0dx619adUSWBAr+K7psopSSKbyqeGATTi3R1ekaznoaP0hV2QzyH17AEI /BTUuXqTh/hE44AQVdKTw6xjvjD3MmQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677754059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5S8M7VFiIrjWBjAA3FzviIVL8rgISq30wNe4WT8BzAg=; b=TL7wKq/9P7idYtkeYxVycYYw9J69238xmCZxUPCn36vAxian84qTzoCwwLDO2ccTjrxeya XnGspdXp6Xe4wFj5ZlXccGvurrgL+LO79d0ZeHMVecM3Ap4YFa+cxSRacMn+vTqeePISkO 4WxfoETv5AMK3xlvLGvPozY0tKXZEVw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-6BiiciRSNVGyLSxQuuEUGQ-1; Thu, 02 Mar 2023 05:47:38 -0500 X-MC-Unique: 6BiiciRSNVGyLSxQuuEUGQ-1 Received: by mail-wr1-f69.google.com with SMTP id a7-20020a056000188700b002cdd0562b11so708976wri.11 for ; Thu, 02 Mar 2023 02:47:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5S8M7VFiIrjWBjAA3FzviIVL8rgISq30wNe4WT8BzAg=; b=Brat5gdyGoDHJbnW/iuM/QsoZBwQ3hv5Rzcsid7p5A+AL3MtuVKec/ZtVrQaURXToy pIawhzl64QiJd4WTOgfwhiC/1o485Z9TzBIVczeLy1gciydrrAmCzZ/7krbznZDW/QoA UUVUIP/k4SWg1JacHG214wD5ycOYBB32d4SUf2qudb9R7CUOqQxWmn0pu0+MdczsuAwK otF2KCIoTkswfDZD8t28TXGUqNv0McYpLIi4q/op3s6pTSP6F9w5GsmGp/u0BpwcLmdZ Z5QH+T3u94A83Ssy1T6G2z7Rz3YsB4/7Of4atFuhdh7PGOWymtvAzwoPrwVhc1S9FZPs 03sA== X-Gm-Message-State: AO0yUKVOSbFtqZKTfez1SMJINl4aI4HU3uncdLZz4pLWIW/K8D93xsgH XDlR9L04GcEE+X58i20cdyfT7xcDJ9NJw12zmyviGTXLRue9ae0dhaEoJ6BThRjqByfpZS9hU3T dct91UJaWkuFZA9m9 X-Received: by 2002:a5d:63c6:0:b0:2ca:101e:1056 with SMTP id c6-20020a5d63c6000000b002ca101e1056mr6974947wrw.1.1677754056950; Thu, 02 Mar 2023 02:47:36 -0800 (PST) X-Google-Smtp-Source: AK7set8AlFkoEPhUXgQ2qZuUUweAAfw6iklrEvSxh3Ozh0PDQfe1FKMeP5ddXBc216eHMfeobx/RnA== X-Received: by 2002:a5d:63c6:0:b0:2ca:101e:1056 with SMTP id c6-20020a5d63c6000000b002ca101e1056mr6974932wrw.1.1677754056612; Thu, 02 Mar 2023 02:47:36 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:4f00:87ba:e9e9:3821:677b? (p200300cbc70e4f0087bae9e93821677b.dip0.t-ipconnect.de. [2003:cb:c70e:4f00:87ba:e9e9:3821:677b]) by smtp.gmail.com with ESMTPSA id w3-20020adff9c3000000b002c7e1a39adcsm15095664wrr.23.2023.03.02.02.47.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 02:47:36 -0800 (PST) Message-ID: <3331790c-95a1-6ab9-2667-86aae3d28d7d@redhat.com> Date: Thu, 2 Mar 2023 11:47:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 08/11] mm/vmstat: switch counter modification to cmpxchg To: Marcelo Tosatti , Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230209150150.380060673@redhat.com> <20230209153204.846239718@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230209153204.846239718@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D8BA320019 X-Stat-Signature: 5oymk48i6i7xq81etb4q538jccz58wk6 X-HE-Tag: 1677754059-280911 X-HE-Meta: U2FsdGVkX19u9G3qdhIb3Pb/flB4l+pWiBnwkL13SHCjA3hybjb/c60YgcrVvQyXvsk5kssKUJSP31dNofV/KsNr9sZNcIgDCqp82EzpJYxw6kg4wEN+y1TDeM0wO36EKj3QRnCH48o4dkTkzngSHlApBcT3uGvQUkwyKnnZzuFDPVYKJ3yWy5SRHD/ugpeQ7yBq9Tjah7oAaZ3dxeAGfu6NEO2flpXxozb2aMJWHL/AA4p11/MOsilcKl7ybZgA7ndDGrHjvlSSdUMWUEVPTszj9TxXkojIcHnrjb9F3kPo8bPq8dKa709kK5bdYuGpKarYuDbCVwXC6/A15VApeKvpdrtmvW2JWde7cHtDgUdQ54CxHxiNeEJKaXL9QNrsUperkpTibnmrKMDZ+SvIIiOzw2QOew9dpbiXixx5cIEgMPjDKCCQb0UdL76g38h2Bb8L/FJDUxkq/pLPgUWLYyL10JAsT3VweIBK/gknktTZxCgb1YVpXcQFqTQf2XSmf5LkFeOMojo9PZyNI79Gl9b2G3EoReU/8notgLovBnrDsHaDx8D7+hN1iINRUhS+2dXg/iFlAZZ7BKWo49FR0lxmz8QbAyq7GWaLac5yk17IZtJV2zuHWvm2AYgOMpLaYtEJ11H9kA6crlNRXBx3gAIxViNXixJWZuvnXP94yp8LdpoCJHqbXwZLcX+f5iO3iMK4WSwsdierRzxMusC7+LvM4JJr3T02a76RkdXsxuf541hvyvaPF1BA0TkfzUqIE/nWkwt7iGOuVoP+Gnau8MC4++5TQeUomBsUmP1P4s11V9ID71rqPHc5ShMp5Mo8rPNQ8L6gURAojdQg1lzPaPBNkGCR73NhZH59Z4CJRjm+V9FQ0cM9U7kW2Ik2wCHW4c2jzLaya/DKgosEDXi2hslvkVNCg0wAXNEUdlU5fpS4FkttjKLqCy58YeB7kBo/hChD9tRfsupqf8H80eo yjwYVnbl 111PHmMLp9IgAWK356AVPcl1Z+u1XDjyLvYjd0cjjCXVZTXuofYx3APcUogpOWdYdyY3nGUls8upnEcDEY4N42tVQh6fhoqiqcoUar04HEN7qz9U7y0gnxG9aJa1J83I6N33pa5fl9s3L5avjbzLIkJvs+FKwcEUuKv2iyvNa8GQJVXqiqFYPUq0CE/pFPZq+9Nw3rTQXFzmxEVVfj8AeoLjwtaJjOdFbGaD4ilWiid7HHsh4f+J/5Ke80EuI3vdFgmjHwish3UMK+U+7wgj8pmHi5909/891FulYurqgOosocHBxhjsC8XXE7IVDwxWC4mmabb3rmq05b2OAwXYfkEyY21wpoep4fO0xCw4XAtNS7zUGVrxxc0NxyMfgmgarFKmo5qH/gaDUCD9r9SnzfXvYzktBo34frMdAntzWc8ty/LIguZWkJcojKkpOuj52+PT0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.02.23 16:01, Marcelo Tosatti wrote: > In preparation to switch vmstat shepherd to flush > per-CPU counters remotely, switch all functions that > modify the counters to use cmpxchg. > > To test the performance difference, a page allocator microbenchmark: > https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/bench/page_bench01.c > with loops=1000000 was used, on Intel Core i7-11850H @ 2.50GHz. > > For the single_page_alloc_free test, which does > > /** Loop to measure **/ > for (i = 0; i < rec->loops; i++) { > my_page = alloc_page(gfp_mask); > if (unlikely(my_page == NULL)) > return 0; > __free_page(my_page); > } > > Unit is cycles. > > Vanilla Patched Diff > 159 165 3.7% > > Signed-off-by: Marcelo Tosatti > > Index: linux-vmstat-remote/mm/vmstat.c > =================================================================== > --- linux-vmstat-remote.orig/mm/vmstat.c > +++ linux-vmstat-remote/mm/vmstat.c > @@ -334,6 +334,188 @@ void set_pgdat_percpu_threshold(pg_data_ > } > } I wonder why we get a diff that is rather hard to review because it removes all existing codes and replaces it by almost-identical code. Are you maybe moving a bunch of code while modifying some tiny bits at the same time? -- Thanks, David / dhildenb