From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01CFFC83F21 for ; Tue, 15 Jul 2025 14:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C73A6B0095; Tue, 15 Jul 2025 10:18:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99ECD6B0096; Tue, 15 Jul 2025 10:18:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B5426B0099; Tue, 15 Jul 2025 10:18:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B17A6B0095 for ; Tue, 15 Jul 2025 10:18:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 50E391404B5 for ; Tue, 15 Jul 2025 14:18:34 +0000 (UTC) X-FDA: 83666704548.07.923BB63 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id E6A87180008 for ; Tue, 15 Jul 2025 14:18:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elb+dvkp; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752589112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iCz3aFtz9BoXuFwRStITMsUKAM3VRx5ZileAaCmlgUc=; b=Nbz8NW8lAO9vgXQMHnCjSf9DbiJwQXMbtB6+Ns1r6eSiRjgsF063P/u9yWQfMNIqXnQq8M yjYbTxTvHHogDXJYEiJKeozM8elPfGrrHldjxZ+yjYscJSEyllwd20r2I6LKhoqFSOlwku aEzjphn8ysLoqULYocAVdjFLzLZ5wcE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752589112; a=rsa-sha256; cv=none; b=JoDjAhzElx1ouQ9pcAQ370oWJiDIXchnnWNBSNaWR3P0Ppt/u41lkZXbzx7m897kURLnJ9 avVRRJHk8YvUrgulgsv3a3uMAF09/NhGXwiDN7wmddj1J3cxUC6IbvTHm6tlcdy/fXWiWA BvEIYmDvxiXOcI+D9t6NqdIRZ6wgu/s= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elb+dvkp; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752589111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iCz3aFtz9BoXuFwRStITMsUKAM3VRx5ZileAaCmlgUc=; b=Elb+dvkpDrd+BKVrNBAT6k25Yt5h/ApO6tanaXQ546iXtyxfBcf5y3qQwNrgfiuLbyj9Xe QoIDaFGV3HjxmPHBWbX4avMpSaDPdb1aMDifuTSCv+Hf3jIc+lnHe4AZ8Qa+Bn/3bkb0n2 IXQ6G1y6MBgUnUk8YMwq0Mcinctpr54= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-XF71uAL4OImIvTvu_Ans1A-1; Tue, 15 Jul 2025 10:18:30 -0400 X-MC-Unique: XF71uAL4OImIvTvu_Ans1A-1 X-Mimecast-MFC-AGG-ID: XF71uAL4OImIvTvu_Ans1A_1752589109 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so2255785f8f.2 for ; Tue, 15 Jul 2025 07:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752589109; x=1753193909; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iCz3aFtz9BoXuFwRStITMsUKAM3VRx5ZileAaCmlgUc=; b=Tm8PxPsgG14dJ/oQx+I5KAXoMMr869E7IkqY4G/UrvnW2GRn4UFHPcIycUf1/kMOKP KDsh25pqNR16giuJTAd7NS+MZtIN4XDyIdM3vt98v3vSZ5GPS6FQ8pLT2umQOcRS/Pgj Tm7GRA7Iu0ULobiFnx7xajr4X5fXszQr145wE//Czhysxiw8x3KtDxJfrbZHHrBweJmr TslHHaVSaJntq8MnpdiuYYI3SlKtrwTZdGwxFBlc5vqxd0VvxxedOOyiHa6Gr0JOdjkR n5jDeqST2NQQRTMF4uCJ9VyrRx0ztt39URqyJlJVJxLFmekqNWgIQR6Jb/cddkgsqppx TR5w== X-Forwarded-Encrypted: i=1; AJvYcCUzVHneSLqChbCkZtK9/fEs2wZn/DYAwtv60to1z7B4LTPALhn+ohttXl7dvNzqFoHwk15oGIow1w==@kvack.org X-Gm-Message-State: AOJu0YxJdk7KMKXVU8egkfOEPly7Wy4xwN9km4eHRWsIYCGRu60jEDoJ eGolKC02Lfh7Z302+hxUz4DWPFvoSUXYfA8PBdnfejyTz0W6YTVszdnDZGvI+F+91qNfc4S8SpY UHv12xzpHSxv1W6OtdQaw1p2gN00IjB4cvc4D1KTPux+x6zJzdqMp X-Gm-Gg: ASbGncuShd70GuNom6ugJqKoqCfgDaZqh0HXANU1JOOyQMy16YhHr2wk1sQRB+mEeWp 3Xxyf0KdWOSSeEugKBYD3Cw5hiFlf4xPGEVDgI2KmGo0J2loqQSDkZidE26Ss8gGDIKXgpld5xC mFGMhpLBMTXBfIJ5+6HMwM4KzCWEmPrfJ5OJzKYTo0pDTnJIYTVK9pldQZXam/jlHhXuuzW97D/ Pjt5JzV1egYNjZCE43MB9EAX/ghpy2cGT6kC1/dyeopeEdzeXd5a/VsWpZRPqIOnEHiEd52Ic2J VlSXgunIxQO05+AFfRVw8lsv8ZxakNrMf4wDRNx5mH5HdUsVBDxQ7ZkuDxQNpDi+NxdyMi/Oe2F zX6M0TSoaCwcX1EbR4o2yuUQ1wSBdmUkh4ANrvjytc0qy1/jgUJG/Ejx1zf/Mh7uiqGM= X-Received: by 2002:a05:6000:643:b0:3a5:25e0:1851 with SMTP id ffacd0b85a97d-3b5f1875e37mr15346464f8f.7.1752589108640; Tue, 15 Jul 2025 07:18:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiBepijZKJjM02yAnF9OJBk4VUiu5bY/nT8xuLFQ4t33OnHfJOgjJeATj2QBAyc/L6yPLj6g== X-Received: by 2002:a05:6000:643:b0:3a5:25e0:1851 with SMTP id ffacd0b85a97d-3b5f1875e37mr15346404f8f.7.1752589108184; Tue, 15 Jul 2025 07:18:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4900:2c24:4e20:1f21:9fbd? (p200300d82f2849002c244e201f219fbd.dip0.t-ipconnect.de. [2003:d8:2f28:4900:2c24:4e20:1f21:9fbd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc1de0sm15098577f8f.24.2025.07.15.07.18.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 07:18:27 -0700 (PDT) Message-ID: <3336b153-7600-4b1a-9acc-0ecde8d32cdc@redhat.com> Date: Tue, 15 Jul 2025 16:18:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function To: "Pankaj Raghav (Samsung)" , Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , Lorenzo Stoakes , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250707142319.319642-1-kernel@pankajraghav.com> <20250707142319.319642-3-kernel@pankajraghav.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20250707142319.319642-3-kernel@pankajraghav.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J18Ra5oaO9GrWYTP3nFgdB_oiBNX1AUIHu91biktf2o_1752589109 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E6A87180008 X-Stat-Signature: hz1pjn6t8ytmnooywf9ymf3bmbwi5zcr X-Rspam-User: X-HE-Tag: 1752589111-716867 X-HE-Meta: U2FsdGVkX18+Z1X9MpJb9eDGVZHj5p+YY9tpyc6lDMx3wYr+qXtZaULXzwulbP3mqpI7qBN5B6ONmhXCrz6ZYcwcpRAcP/jJ4ifdPk7ITW66etN8KUFXkEq4/v/58+yKzuuqDuo7wnYSvE483yMX4Gt95KqJmd1tqfdv74k1qc7jV3yGL7JUguOMsPDSnqu5KWI+xka//LixEZLwgyov0ho7/DG1Yv4pmnEUa5Fkfui7QjQckeRtEMOMmqyR369PYiXTRNTHm30jXCPBlsYu/dGB+e/m8gFyJLmUnklfqckaWZjBxB44X1nF/qQxSKRk2gexEPn56NZDrMvYUjmDiU41iBA+eJ0V9/DblFXZJlr3bwjGsADUF2JxmKMu0R1fgLOPPMezkvSk4tbsdf8cmUVlV41M8VFPAWsJYI189dD0sGMSSvz87wK9dwd2FCDg7IRO9GU8hU5mJWMxGbyO5sUsWX7YPuLejSe3zLPsmAczuxIXj24NyCjmb7YRu8AqoKfSym3za7+EdYWRllJQhWim0JSYFboUBOIFGx2GDo9ZoSXrvR/7qQP5jUvYiR2DLlhTkhhBQALsXCZKuJsLqLfUOx1/kcj1fTPln0s06HPHw+TgTSM9DdOn5e54ii+iL6ymQfSuqU+eu7lgZ7Q6Lur0o9scXk4P55S9+nTphbMJBd+tMyc1riio5HKk0VzVNMVSKzzZ2kyxHSZIVwDBSB6b7qpqt9L87+ikPgHa50hy/QtI2NHg2LTEFEs/eI1vsCvDJDDP8yRnxcL2lQ0WFzcD7/VALppKpWWU/bmi85pdiymcSOrREYVEmcBzVk5t5h61M6kxi85SCybvqLawXP8bBthAUsW0Bzg8CP4nis7x5Tf/jkrXCWLOJvjK/y3iu5sgwwebGzX79X1v0RNOipulIyPR3ST7Y3mCAaCfhABd9NAxwQLZhwjemml7gmDxyN7wjchecHdS/fbIn06 7SIKjVp0 z1C7k1nkHet+YAw7YMzttbtg78vqSItmB9atA8KHXDw9BvXPRvUcg/KHCrZ9Tn5BYvxKHojZ9oElWgI8uYvVotG5ZTPeYVJUiNTMLVbsGUNCs5tBlCQkETllxycD5tXnmDakKQveKNb1R64uwjblrVbkqsj/J5D0ErvOEpfvqUji2CqGppi9WjX3ocNqlTj8DjEEDqOyw6SUR5nTU/4oYQD5vbsZEnDmkHFpuMuOxvmWaoQhW7QnMXE+rJo5T0Bt6wkjl4hbqqxeAxuoI4bLGtdtQv4/OuII+Rxi4cir32K6EL3BSMC2H+hriBcAn8wR6O37vBz5LNwQGHoAWQ/KWmUxHjd4fHm0hfMde++Fh6d5UcaF1OPmW2hGyrsJ9IXhaWnOORbbo14mqkx6aiwEav9k+KnGBUp7AuLIz90jUCYRWMa5d90uKdyCyjtJFj83grurUZKlM8F/uOogP89V8SyDujKhaL178bd7uOtIB3POAxpPdTGbW4MxIMvyoCW8YfSk06WMd+X57WoejqL5zOGqCuyN87Gk1ZpL7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.07.25 16:23, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Add huge_zero_page_shrinker_init() and huge_zero_page_shrinker_exit(). > As shrinker will not be needed when static PMD zero page is enabled, > these two functions can be a no-op. > > This is a preparation patch for static PMD zero page. No functional > changes. > > Signed-off-by: Pankaj Raghav > --- > mm/huge_memory.c | 38 +++++++++++++++++++++++++++----------- > 1 file changed, 27 insertions(+), 11 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d3e66136e41a..101b67ab2eb6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink, > } > > static struct shrinker *huge_zero_page_shrinker; > +static int huge_zero_page_shrinker_init(void) > +{ > + huge_zero_page_shrinker = shrinker_alloc(0, "thp-zero"); > + if (!huge_zero_page_shrinker) > + return -ENOMEM; > + > + huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count; > + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; > + shrinker_register(huge_zero_page_shrinker); > + return 0; > +} > + > +static void huge_zero_page_shrinker_exit(void) > +{ > + shrinker_free(huge_zero_page_shrinker); > + return; > +} While at it, we should rename most of that to "huge_zero_folio" I assume. -- Cheers, David / dhildenb