From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f199.google.com (mail-qt0-f199.google.com [209.85.216.199]) by kanga.kvack.org (Postfix) with ESMTP id 2A24C6B0033 for ; Mon, 6 Nov 2017 19:46:58 -0500 (EST) Received: by mail-qt0-f199.google.com with SMTP id d9so8178029qtd.8 for ; Mon, 06 Nov 2017 16:46:58 -0800 (PST) Received: from mail.efficios.com (mail.efficios.com. [167.114.142.141]) by mx.google.com with ESMTPS id w134si17624qkw.38.2017.11.06.16.46.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 16:46:57 -0800 (PST) Date: Tue, 7 Nov 2017 00:47:17 +0000 (UTC) From: Mathieu Desnoyers Message-ID: <337041894.6072.1510015637355.JavaMail.zimbra@efficios.com> In-Reply-To: <20171107113729.13369a30@roar.ozlabs.ibm.com> References: <20171106092228.31098-1-mhocko@kernel.org> <1509992067.4140.1.camel@oracle.com> <20171106205644.29386-11-mathieu.desnoyers@efficios.com> <20171107113729.13369a30@roar.ozlabs.ibm.com> Subject: Re: [RFC PATCH for 4.15 10/14] cpu_opv: Wire up powerpc system call MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Nicholas Piggin Cc: Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Andy Lutomirski , Dave Watson , Andrew Morton , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, linux-kernel ----- On Nov 6, 2017, at 7:37 PM, Nicholas Piggin npiggin@gmail.com wrote: > On Mon, 6 Nov 2017 15:56:40 -0500 > Mathieu Desnoyers wrote: > >> diff --git a/arch/powerpc/include/uapi/asm/unistd.h >> b/arch/powerpc/include/uapi/asm/unistd.h >> index b1980fcd56d5..972a7d68c143 100644 >> --- a/arch/powerpc/include/uapi/asm/unistd.h >> +++ b/arch/powerpc/include/uapi/asm/unistd.h >> @@ -396,5 +396,6 @@ >> #define __NR_kexec_file_load 382 >> #define __NR_statx 383 >> #define __NR_rseq 384 >> +#define __NR_cpu_opv 385 > > Sorry for bike shedding, but could we invest a few more keystrokes to > make these names a bit more readable? Whenever I try to make variables or function names more explicit, I can literally feel my consciousness (taking the form of an angry Peter Zijlstra) breathing down my neck asking me to make them shorter. So I guess this is where it becomes a question of taste. I think the "rseq" syscall name is short, to the point, and should be mostly fine. For "cpu_opv", it was just a short name that fit the bill until a better idea would come. I'm open to suggestions. Any color preference ? ;-) Thanks, Mathieu > > Thanks, > Nick -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org