From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0A9C3064D for ; Tue, 2 Jul 2024 13:24:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 460376B0085; Tue, 2 Jul 2024 09:24:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41CD86B008C; Tue, 2 Jul 2024 09:24:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28A0C6B0093; Tue, 2 Jul 2024 09:24:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07F9D6B0085 for ; Tue, 2 Jul 2024 09:24:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9711162230 for ; Tue, 2 Jul 2024 13:24:37 +0000 (UTC) X-FDA: 82294882194.06.DDED91E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6695E140011 for ; Tue, 2 Jul 2024 13:24:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpTySWNM; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719926664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XvO4S11W1NmtnE2CgxLhh4di6Izp3DpvvC0Ysz6zB1c=; b=SZUjlq3kxYMTLnqNWAQ+2fcN4J7ZUp7XyawFe8xz1ODUd3ic26pYrVfvqVfKB5RCMBSrK2 HvVZnUxl2VRjoAzdaSOs9lUVe3F3TGhcjJoakVtIIyq1pNrNilBFL4CbRQ4aukjfmXYH+3 knPjxfXdn7NU+GCXefoamoEUKMlHcWY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpTySWNM; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719926664; a=rsa-sha256; cv=none; b=iQYIuGSTT4+VfP57YLIu9SiiNgQfeD6TQDmoqtH7W9g6uiLEJdow3VIvu2IWAo8w1Sbkzp 5Hz2iS1lE0OlN9XxcjRnm/gqdD/5yNA3lgf1eib0F3qDGIrE2sPIQa3JREvFaatDiC//kR slnUtDaEWdiAVUUbGl67lOFNoUDD83Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719926674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XvO4S11W1NmtnE2CgxLhh4di6Izp3DpvvC0Ysz6zB1c=; b=EpTySWNMNZ+qo3TCr3wXIBWA0AX6VTR0RQ9Rq86RJdhsnhsPdL5swtV4DoYWtyncOatW0n fh1jNY58C4ICbdeHOPkn4flQykgGSf/SNSt3pbpp8CdmNfLs54PNHK7r1jQXmQPIBTwM3K uvO/pCfdj7Z8aJ1W91RTCctpoAZhs0Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-Hzeplx7VPBu51nD2ZtNmtw-1; Tue, 02 Jul 2024 09:24:30 -0400 X-MC-Unique: Hzeplx7VPBu51nD2ZtNmtw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42566c4aa0fso33611225e9.1 for ; Tue, 02 Jul 2024 06:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719926669; x=1720531469; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XvO4S11W1NmtnE2CgxLhh4di6Izp3DpvvC0Ysz6zB1c=; b=E2dtDyCcKl5gBnmIrOoGcc4GloHAIaSUbxHLbTndTpGqhdX+VmM9AJx0THoN29RQcb tzB3IIdtrEoLYEcy25hGv64XumDSZdFt2lDufxX1dkd//u2oJmiYw902dnricYok6oIg nDtvSjGpY103CWQkMx8D8a31onrTIoHOxC8w18tDmrBzMCU7nYLvEkHtJrHoRcR/IQxa S6/pIDBhlGd3cCra6GOjUP5FpkkA/YeB4IMKpPpQeGF8L0QQQCRZBiSCTtJibkL1LPzY EimJmzdaSw6kFJZezBtfCw4fFjoPgvg59dvROePPmA4PIc7L/QVZgYVlyFpjdVe3dA9y L0Rw== X-Forwarded-Encrypted: i=1; AJvYcCVPbT4Ye4Usc4uWtJbZkBFHz05c6AKEUXKFUf5NM+9cMkzKRLxjptWylKqNI8wsd8nZGCgFsOtpGN9f3M7iyYf5LAM= X-Gm-Message-State: AOJu0YziiQA+zHbKY/UaUkuFy7ZKjXgzHtE47zUjPi0KBDiF/o2JzFv+ og6stSJmRyb3UtLTriTkZEQPJ9tObHk92IN8M/oOVg/DZC30yLPNjxcOgcdXEeKfZpT7lPrtiXg WeYtgfJv7gI4jC4StVodFzpzTI/YmUZyI8uGbmf2Se8Eem9TG X-Received: by 2002:a05:6000:1e87:b0:366:553a:92bd with SMTP id ffacd0b85a97d-367756cee8emr4616876f8f.32.1719926669084; Tue, 02 Jul 2024 06:24:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGr9AXVKGIlXdj+W3wfpz20IvvIXXhozxVOy5f1k3z7l0Ljhx6NtfYyxw7Tmbdqh309nBAAdA== X-Received: by 2002:a05:6000:1e87:b0:366:553a:92bd with SMTP id ffacd0b85a97d-367756cee8emr4616853f8f.32.1719926668597; Tue, 02 Jul 2024 06:24:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:2400:78ac:64bb:a39e:2578? (p200300cbc739240078ac64bba39e2578.dip0.t-ipconnect.de. [2003:cb:c739:2400:78ac:64bb:a39e:2578]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36784e3e0f5sm2013728f8f.11.2024.07.02.06.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 06:24:28 -0700 (PDT) Message-ID: <3376f8c8-f76d-4f5f-903f-2e9edc968a76@redhat.com> Date: Tue, 2 Jul 2024 15:24:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v2] mm/hugetlb_vmemmap: fix race with speculative PFN walkers To: Yu Zhao , Andrew Morton , Muchun Song Cc: Frank van der Linden , "Matthew Wilcox (Oracle)" , Peter Xu , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240627222705.2974207-1-yuzhao@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240627222705.2974207-1-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6695E140011 X-Stat-Signature: ym8o5k6xpiab695m49uee8zgj5a9knsj X-HE-Tag: 1719926675-842815 X-HE-Meta: U2FsdGVkX196fdnZyD3XJ22RhxR5cyU4zMC0XJD3AjQwGrjR+58BBSmAAlfEpXlwJJ4vhH3jYtk6PvwWdhkS6lXvMTYr/p7taLLIGugw1J6KrytH27n/ABT/aKxi41B0QsUO3e20h03UW5ZPYVzR+N4nN5uwYUTYftdz+9Z1N1XDoJ58YYE4eAnmF34ufpZE2DWz1V6ZTL1O60M6hinlmxO49EmOyqiZSKLgE6SH4+nGd0t/Yo19CMvThD4t88CK8O19GAYhIhJZDfovsr2spT9KS38UFbBA14uKMsobLjBr9ZVXlhzd4AzO9xajviJnfjMXT/Sq1w8SlTqZ+0S0wErxWzVIfH/oiqNYAMU1QkZVJeZtNPDmiW1a8KOxTj1Tg3k2NxEgVxS1Hr79W//2ghJOajqDu8fXj47OSmGp/MXu61j9hVACQJMvf+Jel7N3Sfe7ZMe571to1L1zDOvvmt2rViuQ3nQNts7c6OkH2EgiBe74ILDfArxMjC7uKV9seGE6srEPkmM90mTbhCQXU1aIYwEXQvZ/ptYeuu7g23SKXz31YRDk3jAwGDty8ecmlWYyqIiz5qSJ2s4omdWpjCH9ZBdHcWuQayVrVApOJ9A5uIbsj/N79oO8tv4ZvQuSvwISQVua4ukTiSVEmEwCQzkENi8/yGPizRhv48QwDQgVc4SF3TDbuwB7wzkipQOQ2aj+JyVQVh4e00vQrJ1lTAbZ7jUp4bJ48eG6Nc9jHX1pHvpiW3ruEPnMuf2mZuNLB749R28ij+Qbj3AzlD7vnBmFqkeYJrcytcqyampbhCdf6RogUATHxwRngPMRKxElxGxHHTq1HYrrepz+uXnhv6iN3lRsi6IIYHc/XLgsD43VUEmw//SBMtFnZWRi3XLzI1h4UxZdBTztwbXwiYwZiCahxcuel3aFjYKfPrEgFud91zRswcb2/ZqDC5A5b+PeIoRf0+yXQv9wtRkqMmj orzF3hZy j8ulR3pokJXRCHWKD468Pu6gXpXRu2vSUx+GyjXH4oUb7JA0YlYVsG/TRsKrsIBhqckaBvTrORdJQmwZXjVwwVfmXssdo9ST2x5asJ1wLKR3pUI/yG7FTKOX4mtJjk74TtgfwxAMQAE3f5IbBadqOjn2MbXEO6uhxmuwjJxMD9o9/vE5AmsoS04WzKPHt9wkJ3VHLQNYzSfRU7hXM1rjdIS5dLYW5acLfOTf3YLXWHVb/HOUIoYTgZwDowWYvB7JhobzhGDWGXkOgNOFFrYQ7RHrsi0lyQwJMx5R6KxyTg0N45Ln2vUxJSyUxBbBCT5GC9oAGOsXyJBBmPZxi1m7+2Hc4FBn8hnk7kZLul+swLt3ecfPuC0t0RSL2uBTyG61kgsM1loqM1XFfgrumhhB2QXekeM/dsxTNinfok/uYmejzvfDFd9HaS/YLNsOa7sNch30a72BIuD6hvud4/M5rcDHgg2IM6ENLkyqaQdHwRHDppaMacq3+AumroPYFleO2SkrcPRRX1rsHU7DwzG8jqjQzRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.06.24 00:27, Yu Zhao wrote: > While investigating HVO for THPs [1], it turns out that speculative > PFN walkers like compaction can race with vmemmap modifications, e.g., > > CPU 1 (vmemmap modifier) CPU 2 (speculative PFN walker) > ------------------------------- ------------------------------ > Allocates an LRU folio page1 > Sees page1 > Frees page1 > > Allocates a hugeTLB folio page2 > (page1 being a tail of page2) > > Updates vmemmap mapping page1 > get_page_unless_zero(page1) > > Even though page1->_refcount is zero after HVO, get_page_unless_zero() > can still try to modify this read-only field, resulting in a crash. > > An independent report [2] confirmed this race. > > There are two discussed approaches to fix this race: > 1. Make RO vmemmap RW so that get_page_unless_zero() can fail without > triggering a PF. > 2. Use RCU to make sure get_page_unless_zero() either sees zero > page->_refcount through the old vmemmap or non-zero page->_refcount > through the new one. > > The second approach is preferred here because: > 1. It can prevent illegal modifications to struct page[] that has been > HVO'ed; > 2. It can be generalized, in a way similar to ZERO_PAGE(), to fix > similar races in other places, e.g., arch_remove_memory() on x86 > [3], which frees vmemmap mapping offlined struct page[]. > > While adding synchronize_rcu(), the goal is to be surgical, rather > than optimized. Specifically, calls to synchronize_rcu() on the error > handling paths can be coalesced, but it is not done for the sake of > Simplicity: noticeably, this fix removes ~50% more lines than it adds. > > According to the hugetlb_optimize_vmemmap section in > Documentation/admin-guide/sysctl/vm.rst, enabling HVO makes allocating > or freeing hugeTLB pages "~2x slower than before". Having > synchronize_rcu() on top makes those operations even worse, and this > also affects the user interface /proc/sys/vm/nr_overcommit_hugepages. > > [1] https://lore.kernel.org/20240229183436.4110845-4-yuzhao@google.com/ > [2] https://lore.kernel.org/917FFC7F-0615-44DD-90EE-9F85F8EA9974@linux.dev/ > [3] https://lore.kernel.org/be130a96-a27e-4240-ad78-776802f57cad@redhat.com/ > > Signed-off-by: Yu Zhao > Acked-by: Muchun Song > --- > include/linux/page_ref.h | 8 +++++- > mm/hugetlb.c | 53 ++++++---------------------------------- > mm/hugetlb_vmemmap.c | 16 ++++++++++++ > 3 files changed, 30 insertions(+), 47 deletions(-) > > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index 490d0ad6e56d..8c236c651d1d 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -230,7 +230,13 @@ static inline int folio_ref_dec_return(struct folio *folio) > > static inline bool page_ref_add_unless(struct page *page, int nr, int u) > { > - bool ret = atomic_add_unless(&page->_refcount, nr, u); > + bool ret = false; > + > + rcu_read_lock(); > + /* avoid writing to the vmemmap area being remapped */ > + if (!page_is_fake_head(page) && page_ref_count(page) != u) > + ret = atomic_add_unless(&page->_refcount, nr, u); > + rcu_read_unlock(); The page_is_fake_head() thingy in page_ref.h is a bit suboptimal, currently it really only works on _refcount. But I get why it is required right now, hmmm. (independent, all users of page_ref_add_unless seem to pass u==0, maybe we should clean that up at some point; hard to imagine other use cases for refcounts besides "unless 0"). -- Cheers, David / dhildenb