From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 419D8D2A520 for ; Wed, 16 Oct 2024 14:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CACCB6B007B; Wed, 16 Oct 2024 10:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C35416B0082; Wed, 16 Oct 2024 10:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87AE6B0083; Wed, 16 Oct 2024 10:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8789A6B007B for ; Wed, 16 Oct 2024 10:54:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D7576140589 for ; Wed, 16 Oct 2024 14:54:36 +0000 (UTC) X-FDA: 82679762004.05.66FCF07 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id A3C2212001C for ; Wed, 16 Oct 2024 14:54:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HdFVqPDZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729090326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=37hwEcXGVTyh0ZV2slp4d1JYhcVVVeKU47/B1Dajg/w=; b=b+Mc8Jpw7lvLPw+o8wYPBPaird/05MzXvlJ+rn6xpm6DLyEUfxomII76aDdi5AK2wEMq5W dAFcObjgJ+ov23aGkWr0SrrIlUtMo0Sk4c4OuouoVshRl6nTy7lV+4966kbmyzAKS6mEX4 m0fx81BOuftieRHj9I1dip/23+HBIgU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729090326; a=rsa-sha256; cv=none; b=VZYLaeRM0wn80MKkLyBwoMpjQs4OHCHSjE/9gJYLGZTljBHoY/DY9epLZfAR0YsfPmy7pA wtlpjBKkF/HGcTrTF3aph9WHutv4UoR+TM4pQgUm4Ec5tauzGkU8veyJn1UKTmHjBUV4OA F2hMhROWrbgIdH7HK00W8XR+lhrVNTs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HdFVqPDZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A22B25C4CA7; Wed, 16 Oct 2024 14:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 044B5C4CEC5; Wed, 16 Oct 2024 14:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729090483; bh=3BCgHcirtEbH3leNmUBYC0xGCArqCYUFgQpSEkV/Le4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=HdFVqPDZP5Kj1wIQuq9y5eThgwvA80RXU9qhQW24GoDFCHFe1FZ9VCFML+ktYqLnX kHFd2Xxxd5jLVpLqUlN7Y3Bj+XdStljiEsJYiytc1X45Iqe7ucDUpRw+TKjSRd6FK1 dKvvpdjtjOLUTRTlqh9M+KbAkKukvm6M32Cg0tdlmtUevNdKXCA/zBULZSULQ6PoYJ 4GI2RV0OutiLzzsDtv9X+7GMPzB7ZeTbTDMy79T8nePVqfI6Z2KmUjjnnX7fn0vuAQ q/SbzWZFiL5t6U+tX7s5sQaXpcb7F1VqBWHigjIugCm43AUSA/qSS5QTJMydevZIvc K7gugRQQCQbbA== Message-ID: <33a6cc271475b0fc520b8fc20ed0b4f7742a2560.camel@kernel.org> Subject: Re: [RFC PATCH v1 21/57] sunrpc: Remove PAGE_SIZE compile-time constant assumption From: Jeff Layton To: Chuck Lever , Ryan Roberts Cc: Andrew Morton , Anna Schumaker , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Trond Myklebust , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Date: Wed, 16 Oct 2024 10:54:40 -0400 In-Reply-To: References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-21-ryan.roberts@arm.com> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3C2212001C X-Stat-Signature: egwm5ziib7414djbifosm7dpobh181bf X-Rspam-User: X-HE-Tag: 1729090473-731003 X-HE-Meta: U2FsdGVkX1+aG/XPqpNgIR6rjEmspv76mNXQ8krLViQwloSVnwqBTp9/G+G3zPkx5WLBe4MMRpqNTAWgcrDH7pl99oH4/fKa0bumUoavBHe3GL5KINGU7K5kmS1B4WbcJ8OceX2ahKBZE526/H+mQSPjIL4BGO0yh84iuTtIfxXNfVDhSrAVEsn5I+OE+fKafx15hyvZJQy5NOW/88fbjePhlGaxOChflMKa7bcqd7bzYYGJbNF0JGjlTmikPDRzG/HTg9o6EgZh10Zk9ApqVRZ5nXJr+uEgwb0uOA1KTmtb1pq/Cn9RRr4XeY4UYQXOmjBjUTruSjAohKduB0wlz/YUKOSMW4nSOa/Ykp94S1OkYA3vylLvAeVtndCl6+Ymo1lb2tpo0yav81PR3W5PcARSkjSjcqPEPFJT+hjqCZaHxj6oU9SI6O2XVUX24GC3vL6Qb2g7qS8eV8ujppejCpvSUw6xBuVmgRsQfW+IgQR2FWnH9jWT3OwFhhUV/nY44YULj+F1yaEbDrymgV2Yedgb2AUJGkIVNxtE4jcwQ+xdQS1D0dYmQz5fBsghyi+T8eTvPHk72ENOiMmxgLvG+3MRteFeBM1qRM1rG5qH6/MynquvfNS7rClE6ClzqVlNeUI4RtIOPSfJA2TO3iLLzgKCNQPqeia6qrusopXmCGCP5OfSRj9udZjApQ5D6W2w8MU5kuxYDADbdHoaxunOnumFFmIowO64Vud1dk4Ak4c2IRJzYsHADpe21ZRb+lFMrXjJdrbZ2luw0paXd+lyOEef4p20PY1CT+fZIWmMaU086+jYPxg0TZTdfI0+JjZevMdf5qbNJAX06uxBVeDtscIgvw/pNWtGc0dEiZR53Ov0up6jsa/ohdbUdGjh12bUjjXtwzLgH4Y00/L0JrOfpYWvgQqs8uH0ETZ06dWO1YA9EzFFQwo7oQprvoF6XjpoHxOrdQ0LzlFSVVKe6+y fCB9RQk+ dlgMJddklYVRbO9zVuh15EA8GLSTZBUOmuwAKazXxFf4Y8m4uMlyufUqX3xCyhVuwvYWnzXKISJlxROADMkv0Tn0EjXGRnxaYGRAHX0e70qGvSw3ne77CAhNCeCsyaLKytL5ie238imeGnWVGtW7E+tnngDrsF9nW5+XGB90F8ss9b5MnoiR4bkzjcfMWj86o4BgMnJkd/mEfjv8itKlP9TPo4IxfCladXwTVBry9dt17Hj+TIrXBXaEU9hcLZiDiE7L873XPdFwuKh5LpKN5AZv7UkXZOG7t7i00eZHvdM0U+ckll3/X9db1lj/9EfXGCzgCNNbLjhK2ywrwueBbgJ3MgkpPH805bUg4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2024-10-16 at 10:47 -0400, Chuck Lever wrote: > On Wed, Oct 16, 2024 at 03:42:12PM +0100, Ryan Roberts wrote: > > + Chuck Lever, Jeff Layton > >=20 > > This was a rather tricky series to get the recipients correct for and m= y script > > did not realize that "supporter" was a pseudonym for "maintainer" so yo= u were > > missed off the original post. Appologies! > >=20 > > More context in cover letter: > > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.c= om/ > >=20 > >=20 > > On 14/10/2024 11:58, Ryan Roberts wrote: > > > To prepare for supporting boot-time page size selection, refactor cod= e > > > to remove assumptions about PAGE_SIZE being compile-time constant. Co= de > > > intended to be equivalent when compile-time page size is active. > > >=20 > > > Updated array sizes in various structs to contain enough entries for = the > > > smallest supported page size. > > >=20 > > > Signed-off-by: Ryan Roberts > > > --- > > >=20 > > > ***NOTE*** > > > Any confused maintainers may want to read the cover note here for con= text: > > > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm= .com/ > > >=20 > > > include/linux/sunrpc/svc.h | 8 +++++--- > > > include/linux/sunrpc/svc_rdma.h | 4 ++-- > > > include/linux/sunrpc/svcsock.h | 2 +- > > > 3 files changed, 8 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h > > > index a7d0406b9ef59..dda44018b8f36 100644 > > > --- a/include/linux/sunrpc/svc.h > > > +++ b/include/linux/sunrpc/svc.h > > > @@ -160,6 +160,8 @@ extern u32 svc_max_payload(const struct svc_rqst = *rqstp); > > > */ > > > #define RPCSVC_MAXPAGES ((RPCSVC_MAXPAYLOAD+PAGE_SIZE-1)/PAGE_SIZE = \ > > > + 2 + 1) > > > +#define RPCSVC_MAXPAGES_MAX ((RPCSVC_MAXPAYLOAD+PAGE_SIZE_MIN-1)/PAG= E_SIZE_MIN \ > > > + + 2 + 1) >=20 > There is already a "MAX" in the name, so adding this new macro seems > superfluous to me. Can we get away with simply updating the > "RPCSVC_MAXPAGES" macro, instead of adding this new one? >=20 +1 that was my thinking too. This is mostly just used to size arrays, so we might as well just change the existing macro. With 64k pages we probably wouldn't need arrays as long as these will be. Fixing those array sizes to be settable at runtime though is not a trivial project though. >=20 > > > /* > > > * The context of a single thread, including the request currently b= eing > > > @@ -190,14 +192,14 @@ struct svc_rqst { > > > struct xdr_stream rq_res_stream; > > > struct page *rq_scratch_page; > > > struct xdr_buf rq_res; > > > - struct page *rq_pages[RPCSVC_MAXPAGES + 1]; > > > + struct page *rq_pages[RPCSVC_MAXPAGES_MAX + 1]; > > > struct page * *rq_respages; /* points into rq_pages */ > > > struct page * *rq_next_page; /* next reply page to use */ > > > struct page * *rq_page_end; /* one past the last page */ > > > =20 > > > struct folio_batch rq_fbatch; > > > - struct kvec rq_vec[RPCSVC_MAXPAGES]; /* generally useful.. */ > > > - struct bio_vec rq_bvec[RPCSVC_MAXPAGES]; > > > + struct kvec rq_vec[RPCSVC_MAXPAGES_MAX]; /* generally useful.. */ > > > + struct bio_vec rq_bvec[RPCSVC_MAXPAGES_MAX]; > > > =20 > > > __be32 rq_xid; /* transmission id */ > > > u32 rq_prog; /* program number */ > > > diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/s= vc_rdma.h > > > index d33bab33099ab..7c6441e8d6f7a 100644 > > > --- a/include/linux/sunrpc/svc_rdma.h > > > +++ b/include/linux/sunrpc/svc_rdma.h > > > @@ -200,7 +200,7 @@ struct svc_rdma_recv_ctxt { > > > struct svc_rdma_pcl rc_reply_pcl; > > > =20 > > > unsigned int rc_page_count; > > > - struct page *rc_pages[RPCSVC_MAXPAGES]; > > > + struct page *rc_pages[RPCSVC_MAXPAGES_MAX]; > > > }; > > > =20 > > > /* > > > @@ -242,7 +242,7 @@ struct svc_rdma_send_ctxt { > > > void *sc_xprt_buf; > > > int sc_page_count; > > > int sc_cur_sge_no; > > > - struct page *sc_pages[RPCSVC_MAXPAGES]; > > > + struct page *sc_pages[RPCSVC_MAXPAGES_MAX]; > > > struct ib_sge sc_sges[]; > > > }; > > > =20 > > > diff --git a/include/linux/sunrpc/svcsock.h b/include/linux/sunrpc/sv= csock.h > > > index 7c78ec6356b92..6c6bcc82685a3 100644 > > > --- a/include/linux/sunrpc/svcsock.h > > > +++ b/include/linux/sunrpc/svcsock.h > > > @@ -40,7 +40,7 @@ struct svc_sock { > > > =20 > > > struct completion sk_handshake_done; > > > =20 > > > - struct page * sk_pages[RPCSVC_MAXPAGES]; /* received data */ > > > + struct page * sk_pages[RPCSVC_MAXPAGES_MAX]; /* received data */ > > > }; > > > =20 > > > static inline u32 svc_sock_reclen(struct svc_sock *svsk) > >=20 >=20 --=20 Jeff Layton