From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01A7EB64D7 for ; Fri, 16 Jun 2023 09:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 314988E0002; Fri, 16 Jun 2023 05:42:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C69B8E0001; Fri, 16 Jun 2023 05:42:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18D448E0002; Fri, 16 Jun 2023 05:42:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 091088E0001 for ; Fri, 16 Jun 2023 05:42:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C92EC160B53 for ; Fri, 16 Jun 2023 09:42:54 +0000 (UTC) X-FDA: 80908121868.18.2AA7DE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id AD623140017 for ; Fri, 16 Jun 2023 09:42:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hg5qTxdC; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686908571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4GafyBkcQzvQIRjmk7wYgo9lMe6LdHodKWm7c/bSeCg=; b=xdic7x2FeEeIdMWHRu1ZqBHcS7LS8tOLQIizLftC4LvR89nQ51iFpo4eFOHOM8UNnimkvP 2u88Qn5s4lSsUCyl+Vs4hihUEVsslh22nxECcWZahsaFjETJtiffxhRrUtMrxHfJ7SNpsU 2GCfiwsdmX3ZsE43s52WAepunjw5TWc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hg5qTxdC; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686908571; a=rsa-sha256; cv=none; b=neXh1wcGXCcFKm6F4BMGChYEAe37L67dCEOogb14J2wkfiLYYvTqfTnMOzAZYiOqWmmIzg A+YMb/9HhkSOxMfWBX1bM08/M1tKLfcoONrBnEGyt8f2Z/DQ82iVyS9IJGxdXAMN+Z4bX1 AwsyLFPh6Hy5e9BkTDZi0LIDbhrdfbc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686908571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GafyBkcQzvQIRjmk7wYgo9lMe6LdHodKWm7c/bSeCg=; b=Hg5qTxdC7VP6kyMhER3GBuc+nS5P9dCAbiKPP+Ol9dievAQw3Yw8Xt42qmcM/AQha9+cj7 OP+DPlWGvyhvE5djPNiNpEXXGlFGE40tsq3pINHyADQ8mpE/iD7Th8yGAqadX8889wSG4v h0xvqmxaA3mY5KPJj5hCY6C7RWD20JA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-qxcEnPZaNVGECiFdyNozDQ-1; Fri, 16 Jun 2023 05:42:49 -0400 X-MC-Unique: qxcEnPZaNVGECiFdyNozDQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4f01644f62eso370514e87.0 for ; Fri, 16 Jun 2023 02:42:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686908568; x=1689500568; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4GafyBkcQzvQIRjmk7wYgo9lMe6LdHodKWm7c/bSeCg=; b=j03BnMFtva8ZRRnsTFsldRvdnfaCNlIzzR9AS2FZ5sDAbwjXH9tCSuTkqt+ivzRKUC WY3APbPlnv7zdeMARt5m0U+Y129S0Q//kZGspyC2ocNx59Wb6tAmqbORG8Fpgm6csKTt AgsUWbYK2kjWxnOXTtdXEj9rAcqxvySnkpsKuLSXACu+wNFCGAEMWzugUNQPU63WZ/x3 xrRbduI+bcpsCxlOvMV20Tbw0NHb6IOaR2fYeYrLbbeyh3Pa/Fk2btxYVv5WuD0XzuWC NVrtPwwCCl3Kxc49yH9yyQZqxK5qyAsZ5QTF0y5ZmmBW8go7HhFuzmdU3qkWu6ct0/2U BMAA== X-Gm-Message-State: AC+VfDz70DzWXosnCMxiS0rhDqSeMoNHv417D5VadWbwrTOyMT17l8mg Zio8CdJfrNLVEe+Ily3negUNqC5f+7fihKeBZYDZypKNjjtXF67hlcstDXXibJdGIkbfcr+0X2p vKg3/GDyGtTE= X-Received: by 2002:ac2:5b46:0:b0:4f7:55e4:4665 with SMTP id i6-20020ac25b46000000b004f755e44665mr830452lfp.56.1686908568259; Fri, 16 Jun 2023 02:42:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5NdyLPmDxaQj9iocCb59FTYF2Jd9Rvljvltgi+G61jCwMtVET3vezM8eR4IooGuIK/sH1kiQ== X-Received: by 2002:ac2:5b46:0:b0:4f7:55e4:4665 with SMTP id i6-20020ac25b46000000b004f755e44665mr830418lfp.56.1686908567763; Fri, 16 Jun 2023 02:42:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9800:59ba:1006:9052:fb40? (p200300cbc707980059ba10069052fb40.dip0.t-ipconnect.de. [2003:cb:c707:9800:59ba:1006:9052:fb40]) by smtp.gmail.com with ESMTPSA id k23-20020a05600c0b5700b003f8f884ebe5sm881496wmr.2.2023.06.16.02.42.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 02:42:47 -0700 (PDT) Message-ID: <33eabee3-f6f4-ee0c-d74b-98815a9567c4@redhat.com> Date: Fri, 16 Jun 2023 11:42:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: vmscan: export func:shrink_slab To: lipeifeng@oppo.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, surenb@google.com, gregkh@google.com References: <20230616092112.387-1-lipeifeng@oppo.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230616092112.387-1-lipeifeng@oppo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AD623140017 X-Rspam-User: X-Stat-Signature: od4s6kfcf36se3yzxzyca14e6bq56jyf X-Rspamd-Server: rspam01 X-HE-Tag: 1686908571-194662 X-HE-Meta: U2FsdGVkX1+lp/mJwmyo4Nh4Ud72R3c1DRZuAuzlbGsX/OtZJN9ggdYntd+/Yp/XQRW2IgHTL/0I4nC1T0DmfSi2Cbbd64JYb2MTEZ7td0aQjw1uuuuCko7h84ZxLxSRHDI2fbeUUYvCG9djisgPQSlkNN9G0ZqDPEru+mi/HQK5kMF648k9AUqVeq1DPxZ77hcg/7mk3zaY8P6SCwgWpViWJPrONBZZ3tTmbh+2KM/7qRASK9vYZWqjGYlhTCRifR6rv+LYtIKJrSQfqXXdLuV0/0jUCU4ykmcIcYGDUhmPz+azVoXI21oIT8QmetsPdlhVS7nH0uEARzlEbHd6ZAzleH64ikzkg0qsYr0MCTAhU+H5yx6Xv3J5pj/Eq/hybalunMTSDeyg48o89P+NZxq2NYLrNK4jqqXAVBuvjY+DXh5fT2llxvBBi0SXpT4RI/3dcU+mxzZNBBGvEHVV1ltiejQxFfFa68MKDMRMpc/LYve0RYr3ZFnXNJ0CpraCO7ixuCSiZ+tnDRheajL4u9FbHAD3RokKSXdFdywfb8NsmUwDR1r3v2BjH76mXf3DkqtVKU/qecDUKF68u/j3c0CbvwugQbHyRpf6mvEpYt4tJ8DU0ilF0JT58xcBhKJUjvZfl5/rj4GtMmu8pqVUYYtkDUwfubcqM0+yNUBR10V9zrdZtPkh4u+w9IjogdYUGgLU756A0oq0vug0WZVNgMkK1qQwuLcDVdZRYN/FPPInENMcP/Va0BWr1c/Jf7ezpdxml7fFJOJsGFzfUxQGutre89W2FQFlwpfUCCCpAjbbgx8hlmC1S+Gjlwd66skdyXXQPvdS3C61eCtenotEinZoFLE1RW45x6lEzxz5OJDWaxTlvehb1XakL8fAUD3ydZNPmkFHRbXayhcsSy81f1wtgRA0GHaAiBXLw49vJIHBJbIezFgmCyoZNqzxcEGeLU74SOqbcp8+Rgyne4S 5Jz+WyV2 YH2naV8r2UsKGQYbiNrygWdSjm1aGdl21Z9jpDuaT6foqWyOv4Ve8qiRzGXgg8iuC4snjpgfmUy3PQMuaFZBtOVRRlJxou3r92SwtgTR/Rxsmmsb4Juoq/qAf6d5th0psJycLluDXRIQoJi39xciz2aS4cVykqoo4C7uyfGhaZK+5F2gIu65HX4VMKZct/MLVPXekMGE37Buc7iI8FMTd/NuZdKTQwDVWrkpZKuDkcBoTn63I4iE0jPoY+qzD7ZCzRUohMh9+KSrIP4If/EX2DsskydJHF2jCluViKixK3JUK8atXl8ZnSeo2vLwfJoqp6LaUL1ol+9jyU+sNDg+kqEpSwgwgtJxVlTYvM0io/UUZ1CD665KhM1HBGqzD68mfxyfMrRPzb7mqjwFK3pxNP2uIaGhSXwbJ1arubILDfVRH0Ha6lPpOJVsevBjxH0BNKxbfi3GbfGa5XZjCUkVJWtOgMXAMh/ZCQ6tsI9+m2PoVYFI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.06.23 11:21, lipeifeng@oppo.com wrote: > From: lipeifeng > > Some of shrinkers during shrink_slab would enter synchronous-wait > due to lock or other reasons, which would causes kswapd or > direct_reclaim to be blocked. > > This patch export shrink_slab so that it can be called in drivers > which can shrink memory independently. > > Signed-off-by: lipeifeng > --- > mm/vmscan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 6d0cd2840cf0..2e54fa52e7ec 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1043,7 +1043,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > * > * Returns the number of reclaimed slab objects. > */ > -static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > +unsigned long shrink_slab(gfp_t gfp_mask, int nid, > struct mem_cgroup *memcg, > int priority) > { > @@ -1087,6 +1087,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > cond_resched(); > return freed; > } > +EXPORT_SYMBOL_GPL(shrink_slab); > > static unsigned long drop_slab_node(int nid) > { It feels like something we don't want arbitrary drivers to call. Unrelated to that, this better be sent along with actual driver usage. -- Cheers, David / dhildenb